fix: changes after code review

Expensify · Jul 22, 2024 · 67a0ab5 · 67a0ab5
1 parent c6765ba
commit 67a0ab5
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/src/components/ProfilingToolMenu/BaseProfilingToolMenu.tsx b/src/components/ProfilingToolMenu/BaseProfilingToolMenu.tsx
@@ -28,6 +28,8 @@ type BaseProfilingToolMenuProps = {
     pathToBeUsed: string;
     /** Path used to display location of saved file */
     displayPath: string;
+    /** Whether to show the share button */
+    showShareButton?: boolean;
 } & BaseProfilingToolMenuOnyxProps;
 
 function formatBytes(bytes: number, decimals = 2) {
@@ -47,7 +49,7 @@ function formatBytes(bytes: number, decimals = 2) {
 // WARNING: When changing this name make sure that the "scripts/symbolicate-profile.ts" script is still working!
 const newFileName = `Profile_trace_for_${pkg.version}.cpuprofile`;
 
-function BaseProfilingToolMenu({isProfilingInProgress = false, pathToBeUsed, displayPath}: BaseProfilingToolMenuProps) {
+function BaseProfilingToolMenu({isProfilingInProgress = false, showShareButton = false, pathToBeUsed, displayPath}: BaseProfilingToolMenuProps) {
     const styles = useThemeStyles();
     const [filePath, setFilePath] = useState('');
     const [sharePath, setSharePath] = useState('');
@@ -158,7 +160,7 @@ function BaseProfilingToolMenu({isProfilingInProgress = false, pathToBeUsed, dis
                     onToggle={onToggleProfiling}
                 />
             </TestToolRow>
-            {!!filePath && getPlatform() !== CONST.PLATFORM.WEB && (
+            {!!filePath && showShareButton && (
                 <>
                     <Text style={[styles.textLabelSupporting, styles.mb4]}>{`path: ${displayPath}/${newFileName}`}</Text>
                     <TestToolRow title={translate('initialSettingsPage.troubleshoot.profileTrace')}>

diff --git a/src/components/ProfilingToolMenu/index.android.tsx b/src/components/ProfilingToolMenu/index.android.tsx
@@ -8,6 +8,7 @@ function ProfilingToolMenu() {
         <BaseProfilingToolMenu
             pathToBeUsed={RNFS.DownloadDirectoryPath}
             displayPath={`${CONST.DOWNLOADS_PATH}`}
+            showShareButton
         />
     );
 }

diff --git a/src/components/ProfilingToolMenu/index.ios.tsx b/src/components/ProfilingToolMenu/index.ios.tsx
@@ -12,6 +12,7 @@ function ProfilingToolMenu() {
         <BaseProfilingToolMenu
             pathToBeUsed={RNFS.DocumentDirectoryPath}
             displayPath={`${CONST.NEW_EXPENSIFY_PATH}${getDownloadFolderPathSuffixForIOS(environment)}`}
+            showShareButton
         />
     );
 }