fix: typecheck

Expensify · Jan 25, 2024 · 691fef8 · 691fef8
1 parent 500833d
commit 691fef8
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/components/LHNOptionsList/LHNOptionsList.tsx b/src/components/LHNOptionsList/LHNOptionsList.tsx
@@ -48,7 +48,7 @@ function LHNOptionsList({
             const transactionID = itemParentReportAction?.actionName === CONST.REPORT.ACTIONS.TYPE.IOU ? itemParentReportAction.originalMessage.IOUTransactionID ?? '' : '';
             const itemTransaction = transactions?.[`${ONYXKEYS.COLLECTION.TRANSACTION}${transactionID}`] ?? null;
             const itemComment = draftComments?.[`${ONYXKEYS.COLLECTION.REPORT_DRAFT_COMMENT}${reportID}`] ?? '';
-            const participants = [...ReportUtils.getParticipantsIDs(itemFullReport), itemFullReport?.ownerAccountID, itemParentReportAction?.actorAccountID];
+            const participants = [...ReportUtils.getParticipantsIDs(itemFullReport), itemFullReport?.ownerAccountID, itemParentReportAction?.actorAccountID].filter(Boolean) as number[];
             const participantsPersonalDetails = OptionsListUtils.getPersonalDetailsForAccountIDs(participants, personalDetails);
 
             return (
@@ -58,7 +58,6 @@ function LHNOptionsList({
                     reportActions={itemReportActions}
                     parentReportAction={itemParentReportAction}
                     policy={itemPolicy}
-                    // @ts-expect-error TODO: Remove this once OptionsListUtils (https://github.com/Expensify/App/issues/24921) is migrated to TypeScript.
                     personalDetails={participantsPersonalDetails}
                     transaction={itemTransaction}
                     receiptTransactions={transactions}

diff --git a/src/components/LHNOptionsList/types.ts b/src/components/LHNOptionsList/types.ts
@@ -47,7 +47,7 @@ type CustomLHNOptionsListProps = {
     data: string[];
 
     /** Callback to fire when a row is selected */
-    onSelectRow: (reportID: string) => void;
+    onSelectRow?: (optionItem: OptionData, popoverAnchor: RefObject<View>) => void;
 
     /** Toggle between compact and default view of the option */
     optionMode: OptionMode;
@@ -97,6 +97,12 @@ type OptionRowLHNDataProps = {
 
     /** Whether the user can use violations */
     canUseViolations: boolean | undefined;
+
+    /** Toggle between compact and default view */
+    viewMode?: OptionMode;
+
+    /** A function that is called when an option is selected. Selected option is passed as a param */
+    onSelectRow?: (optionItem: OptionData, popoverAnchor: RefObject<View>) => void;
 };
 
 type OptionRowLHNProps = {