Skip to content

Commit

Permalink
Merge branch 'main' into cmartins-refactorGetUserDetails
Browse files Browse the repository at this point in the history
  • Loading branch information
luacmartins committed Jul 7, 2022
2 parents 92416ec + 99ed3b8 commit 6ac86ad
Show file tree
Hide file tree
Showing 70 changed files with 12,980 additions and 5,231 deletions.
31 changes: 0 additions & 31 deletions .github/workflows/deployHelpSite.yml

This file was deleted.

1 change: 0 additions & 1 deletion CLA.md

This file was deleted.

1 change: 0 additions & 1 deletion CONTRIBUTING.md

This file was deleted.

1 change: 0 additions & 1 deletion FORMS.md

This file was deleted.

1 change: 0 additions & 1 deletion HOW_TO_CREATE_A_PLAN.md

This file was deleted.

1 change: 0 additions & 1 deletion OfflineUX.md

This file was deleted.

1 change: 0 additions & 1 deletion PERFORMANCE.md

This file was deleted.

2 changes: 1 addition & 1 deletion PR_REVIEW_GUIDELINES.md
Original file line number Diff line number Diff line change
@@ -1 +1 @@
This file has been moved [here](./docs/PR_REVIEW_GUIDELINES.md).
This file has been moved [here](contributingGuides/PR_REVIEW_GUIDELINES.md).
16 changes: 8 additions & 8 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@
* [Deploying](#deploying)

#### Additional Reading
* [API Details](docs/API.md)
* [Offline First](./docs/OFFLINE_UX.md)
* [Contributing to Expensify](./docs/CONTRIBUTING.md)
* [Expensify Code of Conduct](./docs/CODE_OF_CONDUCT.md)
* [Contributor License Agreement](./docs/CLA.md)
* [API Details](contributingGuides/API.md)
* [Offline First](contributingGuides/OFFLINE_UX.md)
* [Contributing to Expensify](contributingGuides/CONTRIBUTING.md)
* [Expensify Code of Conduct](CODE_OF_CONDUCT.md)
* [Contributor License Agreement](contributingGuides/CLA.md)

----

Expand Down Expand Up @@ -86,7 +86,7 @@ variables referenced here get updated since your local `.env` file is ignored.
requests to the backend. External contributors should set this to `true` otherwise they'll have CORS errors.
If you don't want to start the proxy server set this explicitly to `false`
- `CAPTURE_METRICS` (optional) - Set this to `true` to capture performance metrics and see them in Flipper
see [PERFORMANCE.md](./docs/PERFORMANCE.md#performance-metrics-opt-in-on-local-release-builds) for more information
see [PERFORMANCE.md](contributingGuides/PERFORMANCE.md#performance-metrics-opt-in-on-local-release-builds) for more information
- `ONYX_METRICS` (optional) - Set this to `true` to capture even more performance metrics and see them in Flipper
see [React-Native-Onyx#benchmarks](https://github.com/Expensify/react-native-onyx#benchmarks) for more information

Expand Down Expand Up @@ -286,9 +286,9 @@ This application is built with the following principles.
4. Brain pushes data into UI inputs (Device input -> React component).
5. UI inputs push data to the server (React component -> Action -> XHR to server).
6. Go to 1
![New Expensify Data Flow Chart](/docs/data_flow.png)
![New Expensify Data Flow Chart](/contributingGuides/data_flow.png)
1. **Offline first**
- Be sure to read [OFFLINE_UX.md](./docs/OFFLINE_UX.md)!
- Be sure to read [OFFLINE_UX.md](contributingGuides/OFFLINE_UX.md)!
- All data that is brought into the app and is necessary to display the app when offline should be stored on disk in persistent storage (eg. localStorage on browser platforms). [AsyncStorage](https://reactnative.dev/docs/asyncstorage) is a cross-platform abstraction layer that is used to access persistent storage.
- All data that is displayed, comes from persistent storage.
1. **UI Binds to data on disk**
Expand Down
1 change: 0 additions & 1 deletion STORYBOOK.md

This file was deleted.

1 change: 0 additions & 1 deletion STYLE.md

This file was deleted.

1 change: 0 additions & 1 deletion STYLING.md

This file was deleted.

1 change: 0 additions & 1 deletion TESTING_MACOS_AND_IOS.md

This file was deleted.

File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion docs/OFFLINE_UX.md → contributingGuides/OFFLINE_UX.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ This pattern blocks the user from interacting with an entire page.

The following flowchart can be used to determine which UX pattern should be used.

![New Expensify Data Flow Chart](/docs/OfflineUX_Patterns_Flowchart.png)
![New Expensify Data Flow Chart](/contributingGuides/OfflineUX_Patterns_Flowchart.png)

### Answering Questions on the Flow Chart

Expand Down
File renamed without changes
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes
6 changes: 3 additions & 3 deletions desktop/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion desktop/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"scripts": {},
"dependencies": {
"electron-context-menu": "^2.3.0",
"electron-log": "^4.3.5",
"electron-log": "^4.4.7",
"electron-serve": "^1.0.0",
"electron-updater": "^4.3.4"
},
Expand Down
File renamed without changes.
File renamed without changes.
9 changes: 3 additions & 6 deletions help/Gemfile → docs/Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,12 +7,9 @@ source "https://rubygems.org"
#
# This will help ensure the proper Jekyll version is running.
# Happy Jekylling!
gem "jekyll", "~> 4.2.2"
# This is the default theme for new Jekyll sites. You may change this to anything you like.
gem "minima", "~> 2.5"
# If you want to use GitHub Pages, remove the "gem "jekyll"" above and
# uncomment the line below. To upgrade, run `bundle update github-pages`.
# gem "github-pages", group: :jekyll_plugins

gem "github-pages", group: :jekyll_plugins

# If you have any plugins, put them here!
group :jekyll_plugins do
gem "jekyll-feed", "~> 0.12"
Expand Down
Loading

0 comments on commit 6ac86ad

Please sign in to comment.