Fix JS tests

Expensify · Oct 25, 2024 · 77aa833 · 77aa833
1 parent 2d1cacb
commit 77aa833
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 6 deletions.
diff --git a/.github/actions/javascript/markPullRequestsAsDeployed/index.js b/.github/actions/javascript/markPullRequestsAsDeployed/index.js
@@ -12726,7 +12726,7 @@ async function run() {
         message += `🚀`;
         message += `\n\nplatform | result\n---|---\n🤖 android 🤖|${androidResult}\n🖥 desktop 🖥|${desktopResult}`;
         message += `\n🍎 iOS 🍎|${iOSResult}\n🕸 web 🕸|${webResult}`;
-        message += `\n🤖 android HybridApp 🤖|${androidHybridResult}\n🍎 iOS HybridApp 🍎|${iOSHybridResult}`;
+        message += `\n🤖🔄 android HybridApp 🤖🔄|${androidHybridResult}\n🍎🔄 iOS HybridApp 🍎🔄|${iOSHybridResult}`;
         if (deployVerb === 'Cherry-picked' && !/no ?qa/gi.test(prTitle ?? '')) {
             // eslint-disable-next-line max-len
             message +=

diff --git a/.github/actions/javascript/markPullRequestsAsDeployed/markPullRequestsAsDeployed.ts b/.github/actions/javascript/markPullRequestsAsDeployed/markPullRequestsAsDeployed.ts
@@ -69,7 +69,7 @@ async function run() {
         message += `🚀`;
         message += `\n\nplatform | result\n---|---\n🤖 android 🤖|${androidResult}\n🖥 desktop 🖥|${desktopResult}`;
         message += `\n🍎 iOS 🍎|${iOSResult}\n🕸 web 🕸|${webResult}`;
-        message += `\n🤖 android HybridApp 🤖|${androidHybridResult}\n🍎 iOS HybridApp 🍎|${iOSHybridResult}`;
+        message += `\n🤖🔄 android HybridApp 🤖🔄|${androidHybridResult}\n🍎🔄 iOS HybridApp 🍎🔄|${iOSHybridResult}`;
 
         if (deployVerb === 'Cherry-picked' && !/no ?qa/gi.test(prTitle ?? '')) {
             // eslint-disable-next-line max-len

diff --git a/tests/unit/markPullRequestsAsDeployedTest.ts b/tests/unit/markPullRequestsAsDeployedTest.ts
@@ -80,15 +80,17 @@ function mockGetInputDefaultImplementation(key: string): boolean | string {
         case 'DEPLOY_VERSION':
             return version;
         case 'IOS':
+        case 'IOS_HYBRID':
         case 'ANDROID':
+        case 'ANDROID_HYBRID':
         case 'DESKTOP':
         case 'WEB':
             return 'success';
         case 'DATE':
         case 'NOTE':
             return '';
         default:
-            throw new Error('Trying to access invalid input');
+            throw new Error(`Trying to access invalid input: ${key}`);
     }
 }
 
@@ -196,7 +198,9 @@ platform | result
 🤖 android 🤖|success ✅
 🖥 desktop 🖥|success ✅
 🍎 iOS 🍎|success ✅
-🕸 web 🕸|success ✅`,
+🕸 web 🕸|success ✅
+🤖🔄 android HybridApp 🤖🔄|success ✅
+🍎🔄 iOS HybridApp 🍎🔄|success ✅`,
                 issue_number: PR.issue_number,
                 owner: 'Expensify',
                 repo: 'App',
@@ -226,7 +230,9 @@ platform | result
 🤖 android 🤖|success ✅
 🖥 desktop 🖥|success ✅
 🍎 iOS 🍎|success ✅
-🕸 web 🕸|success ✅`,
+🕸 web 🕸|success ✅
+🤖🔄 android HybridApp 🤖🔄|success ✅
+🍎🔄 iOS HybridApp 🍎🔄|success ✅`,
                 issue_number: PRList[i + 1].issue_number,
                 owner: 'Expensify',
                 repo: 'App',
@@ -289,6 +295,8 @@ platform | result
 🖥 desktop 🖥|success ✅
 🍎 iOS 🍎|success ✅
 🕸 web 🕸|success ✅
+🤖🔄 android HybridApp 🤖🔄|success ✅
+🍎🔄 iOS HybridApp 🍎🔄|success ✅
 
 @Expensify/applauseleads please QA this PR and check it off on the [deploy checklist](https://github.com/Expensify/App/issues?q=is%3Aopen+is%3Aissue+label%3AStagingDeployCash) if it passes.`,
             issue_number: 3,
@@ -325,7 +333,9 @@ platform | result
 🤖 android 🤖|skipped 🚫
 🖥 desktop 🖥|cancelled 🔪
 🍎 iOS 🍎|failed ❌
-🕸 web 🕸|success ✅`,
+🕸 web 🕸|success ✅
+🤖🔄 android HybridApp 🤖🔄|success ✅
+🍎🔄 iOS HybridApp 🍎🔄|success ✅`,
                 issue_number: PR.issue_number,
                 owner: 'Expensify',
                 repo: 'App',