Merge pull request #43464 from bernhardoj/fix/43169-long-pressing-rea…

…ction-list-doesnt-show-for-first-time Fix long pressing the comment reaction does not open the reactions modal the first time you do it
Expensify · Jun 12, 2024 · 82d0360 · 82d0360
2 parents 033e74c + 6d719bb
commit 82d0360
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/src/hooks/useBasePopoverReactionList/index.ts b/src/hooks/useBasePopoverReactionList/index.ts
@@ -22,6 +22,7 @@ export default function useBasePopoverReactionList({emojiName, emojiReactions, a
                 emojiCodes: [],
                 hasUserReacted: false,
                 users: [],
+                isReady: false,
             };
         }
 
@@ -34,6 +35,7 @@ export default function useBasePopoverReactionList({emojiName, emojiReactions, a
             reactionCount,
             hasUserReacted,
             users,
+            isReady: true,
         };
     }
 

diff --git a/src/pages/home/report/ReactionList/PopoverReactionList/BasePopoverReactionList.tsx b/src/pages/home/report/ReactionList/PopoverReactionList/BasePopoverReactionList.tsx
@@ -21,13 +21,12 @@ function BasePopoverReactionList(props: BasePopoverReactionListPropsWithLocalWit
         preferredLocale,
     });
     // Get the reaction information
-    const {emojiCodes, reactionCount, hasUserReacted, users} = getReactionInformation();
-
+    const {emojiCodes, reactionCount, hasUserReacted, users, isReady} = getReactionInformation();
     useImperativeHandle(ref, () => ({hideReactionList, showReactionList}));
 
     return (
         <PopoverWithMeasuredContent
-            isVisible={isPopoverVisible}
+            isVisible={isPopoverVisible && isReady}
             onClose={hideReactionList}
             anchorPosition={popoverAnchorPosition}
             animationIn="fadeIn"

diff --git a/src/pages/home/report/ReactionList/PopoverReactionList/index.tsx b/src/pages/home/report/ReactionList/PopoverReactionList/index.tsx
@@ -23,10 +23,6 @@ function PopoverReactionList(props: unknown, ref: ForwardedRef<ReactionListRef>)
 
     useImperativeHandle(ref, () => ({showReactionList, hideReactionList, isActiveReportAction}));
 
-    if (reactionListReportActionID === '' || reactionListEmojiName === '') {
-        return null;
-    }
-
     return (
         <BasePopoverReactionList
             ref={innerReactionListRef}