Remove comments

Expensify · Apr 16, 2024 · 86a01f7 · 86a01f7
1 parent 50bcada
commit 86a01f7
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 9 deletions.
diff --git a/src/CONST.ts b/src/CONST.ts
@@ -875,8 +875,7 @@ const CONST = {
     },
     TIMING: {
         CALCULATE_MOST_RECENT_LAST_MODIFIED_ACTION: 'calc_most_recent_last_modified_action',
-        // ASK: Should we also update this name?
-        CHAT_FINDER_RENDER: 'chat_finder',
+        CHAT_FINDER_RENDER: 'search_render',
         CHAT_RENDER: 'chat_render',
         OPEN_REPORT: 'open_report',
         HOMEPAGE_INITIAL_RENDER: 'homepage_initial_render',

diff --git a/src/libs/E2E/reactNativeLaunchingTest.ts b/src/libs/E2E/reactNativeLaunchingTest.ts
@@ -35,7 +35,6 @@ if (!appInstanceId) {
 // import your test here, define its name and config first in e2e/config.js
 const tests: Tests = {
     [E2EConfig.TEST_NAMES.AppStartTime]: require('./tests/appStartTimeTest.e2e').default,
-    // ASK: Should we also update this name?
     [E2EConfig.TEST_NAMES.OpenChatFinderPage]: require('./tests/openChatFinderPageTest.e2e').default,
     [E2EConfig.TEST_NAMES.ChatOpening]: require('./tests/chatOpeningTest.e2e').default,
     [E2EConfig.TEST_NAMES.ReportTyping]: require('./tests/reportTypingTest.e2e').default,

diff --git a/src/libs/E2E/tests/openChatFinderPageTest.e2e.ts b/src/libs/E2E/tests/openChatFinderPageTest.e2e.ts
@@ -9,7 +9,7 @@ import ROUTES from '@src/ROUTES';
 
 const test = () => {
     // check for login (if already logged in the action will simply resolve)
-    console.debug('[E2E] Logging in for chat finding');
+    console.debug('[E2E] Logging in for chat finder');
 
     E2ELogin().then((neededLogin: boolean): Promise<Response> | undefined => {
         if (neededLogin) {
@@ -19,7 +19,7 @@ const test = () => {
             );
         }
 
-        console.debug('[E2E] Logged in, getting chat finding metrics and submitting them…');
+        console.debug('[E2E] Logged in, getting chat finder metrics and submitting them…');
 
         Performance.subscribeToMeasurements((entry) => {
             if (entry.name === CONST.TIMING.SIDEBAR_LOADED) {
@@ -29,7 +29,7 @@ const test = () => {
             }
 
             console.debug(`[E2E] Entry: ${JSON.stringify(entry)}`);
-            if (entry.name !== CONST.TIMING.SEARCH_RENDER) {
+            if (entry.name !== CONST.TIMING.CHAT_FINDER_RENDER) {
                 return;
             }
 

diff --git a/src/pages/ChatFinderPage/index.tsx b/src/pages/ChatFinderPage/index.tsx
@@ -45,7 +45,6 @@ type ChatFinderPageSectionItem = {
 type ChatFinderPageSectionList = ChatFinderPageSectionItem[];
 
 const setPerformanceTimersEnd = () => {
-    // ASK: Should we also update this name?
     Timing.end(CONST.TIMING.CHAT_FINDER_RENDER);
     Performance.markEnd(CONST.TIMING.CHAT_FINDER_RENDER);
 };
@@ -66,7 +65,6 @@ function ChatFinderPage({betas, isSearchingForReports, navigation}: ChatFinderPa
     const [searchValue, debouncedSearchValue, setSearchValue] = useDebouncedState('');
 
     useEffect(() => {
-        // ASK: Should we also update this name?
         Timing.start(CONST.TIMING.CHAT_FINDER_RENDER);
         Performance.markStart(CONST.TIMING.CHAT_FINDER_RENDER);
     }, []);

diff --git a/tests/e2e/config.ts b/tests/e2e/config.ts
@@ -4,7 +4,6 @@ const OUTPUT_DIR = process.env.WORKING_DIRECTORY || './tests/e2e/results';
 // add your test name here …
 const TEST_NAMES = {
     AppStartTime: 'App start time',
-    // ASK: Should we also update this name?
     OpenChatFinderPage: 'Open chat finder page TTI',
     ReportTyping: 'Report typing',
     ChatOpening: 'Chat opening',