Skip to content

Commit

Permalink
Merge pull request #42320 from brunovjk/fix/35391
Browse files Browse the repository at this point in the history
Allow add/remove users to workspace chat
  • Loading branch information
jasperhuangg authored May 28, 2024
2 parents 088fcdc + c7a62cd commit 925340d
Showing 1 changed file with 4 additions and 5 deletions.
9 changes: 4 additions & 5 deletions src/pages/ReportDetailsPage.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ function ReportDetailsPage({policies, report, session, personalDetails}: ReportD
const policy = useMemo(() => policies?.[`${ONYXKEYS.COLLECTION.POLICY}${report?.policyID ?? ''}`], [policies, report?.policyID]);
const isPolicyAdmin = useMemo(() => PolicyUtils.isPolicyAdmin(policy ?? null), [policy]);
const isPolicyEmployee = useMemo(() => PolicyUtils.isPolicyEmployee(report?.policyID ?? '', policies), [report?.policyID, policies]);
const isPolicyExpenseChat = ReportUtils.isPolicyExpenseChat(report);
const shouldUseFullTitle = useMemo(() => ReportUtils.shouldUseFullTitleToDisplay(report), [report]);
const isChatRoom = useMemo(() => ReportUtils.isChatRoom(report), [report]);
const isUserCreatedPolicyRoom = useMemo(() => ReportUtils.isUserCreatedPolicyRoom(report), [report]);
Expand Down Expand Up @@ -152,17 +153,14 @@ function ReportDetailsPage({policies, report, session, personalDetails}: ReportD
subtitle: activeChatMembers.length,
isAnonymousAction: false,
action: () => {
if (isUserCreatedPolicyRoom || isChatThread) {
if (isUserCreatedPolicyRoom || isChatThread || isPolicyExpenseChat) {
Navigation.navigate(ROUTES.ROOM_MEMBERS.getRoute(report?.reportID ?? ''));
} else {
Navigation.navigate(ROUTES.REPORT_PARTICIPANTS.getRoute(report?.reportID ?? ''));
}
},
});
} else if (
(isUserCreatedPolicyRoom && (!participants.length || !isPolicyEmployee)) ||
((isDefaultRoom || ReportUtils.isPolicyExpenseChat(report)) && isChatThread && !isPolicyEmployee)
) {
} else if ((isUserCreatedPolicyRoom && (!participants.length || !isPolicyEmployee)) || ((isDefaultRoom || isPolicyExpenseChat) && isChatThread && !isPolicyEmployee)) {
items.push({
key: CONST.REPORT_DETAILS_MENU_ITEM.INVITE,
translationKey: 'common.invite',
Expand Down Expand Up @@ -205,6 +203,7 @@ function ReportDetailsPage({policies, report, session, personalDetails}: ReportD
isDefaultRoom,
isChatThread,
isPolicyEmployee,
isPolicyExpenseChat,
isUserCreatedPolicyRoom,
participants.length,
report,
Expand Down

0 comments on commit 925340d

Please sign in to comment.