Merge pull request #50783 from thelullabyy/fix/49929-unify-distance-r…

…ates fix: unify distance rates display
Expensify · Nov 8, 2024 · a7b1553 · a7b1553
2 parents 0474d28 + fb3fa5b
commit a7b1553
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 10 deletions.
diff --git a/src/CONST.ts b/src/CONST.ts
@@ -5840,6 +5840,7 @@ const CONST = {
 
     MAX_TAX_RATE_INTEGER_PLACES: 4,
     MAX_TAX_RATE_DECIMAL_PLACES: 4,
+    MIN_TAX_RATE_DECIMAL_PLACES: 2,
 
     DOWNLOADS_PATH: '/Downloads',
     DOWNLOADS_TIMEOUT: 5000,

diff --git a/src/libs/CurrencyUtils.ts b/src/libs/CurrencyUtils.ts
@@ -164,7 +164,8 @@ function convertAmountToDisplayString(amount = 0, currency: string = CONST.CURRE
     return NumberFormatUtils.format(BaseLocaleListener.getPreferredLocale(), convertedAmount, {
         style: 'currency',
         currency,
-        minimumFractionDigits: CONST.MAX_TAX_RATE_DECIMAL_PLACES,
+        minimumFractionDigits: CONST.MIN_TAX_RATE_DECIMAL_PLACES,
+        maximumFractionDigits: CONST.MAX_TAX_RATE_DECIMAL_PLACES,
     });
 }
 

diff --git a/src/libs/PolicyUtils.ts b/src/libs/PolicyUtils.ts
@@ -126,7 +126,7 @@ function getNumericValue(value: number | string, toLocaleDigit: (arg: string) =>
     if (Number.isNaN(numValue)) {
         return NaN;
     }
-    return numValue.toFixed(CONST.CUSTOM_UNITS.RATE_DECIMALS);
+    return numValue;
 }
 
 /**
@@ -158,11 +158,10 @@ function getRateDisplayValue(value: number, toLocaleDigit: (arg: string) => stri
     }
 
     if (withDecimals) {
-        const decimalPart = numValue.toString().split('.').at(1);
-        if (decimalPart) {
-            const fixedDecimalPoints = decimalPart.length > 2 && !decimalPart.endsWith('0') ? 3 : 2;
-            return Number(numValue).toFixed(fixedDecimalPoints).toString().replace('.', toLocaleDigit('.'));
-        }
+        const decimalPart = numValue.toString().split('.').at(1) ?? '';
+        // Set the fraction digits to be between 2 and 4 (OD Behavior)
+        const fractionDigits = Math.min(Math.max(decimalPart.length, CONST.MIN_TAX_RATE_DECIMAL_PLACES), CONST.MAX_TAX_RATE_DECIMAL_PLACES);
+        return Number(numValue).toFixed(fractionDigits).toString().replace('.', toLocaleDigit('.'));
     }
 
     return numValue.toString().replace('.', toLocaleDigit('.')).substring(0, value.toString().length);

diff --git a/tests/unit/PolicyUtilsTest.ts b/tests/unit/PolicyUtilsTest.ts
@@ -34,14 +34,19 @@ describe('PolicyUtils', () => {
                 expect(rate).toEqual('10.50');
             });
 
+            it('should return non-integer value with 4 decimals as is', () => {
+                const rate = PolicyUtils.getRateDisplayValue(10.5312, toLocaleDigitMock, true);
+                expect(rate).toEqual('10.5312');
+            });
+
             it('should return non-integer value with 3 decimals as is', () => {
                 const rate = PolicyUtils.getRateDisplayValue(10.531, toLocaleDigitMock, true);
                 expect(rate).toEqual('10.531');
             });
 
-            it('should return non-integer value with 3+ decimals cut to 3', () => {
-                const rate = PolicyUtils.getRateDisplayValue(10.531345, toLocaleDigitMock, true);
-                expect(rate).toEqual('10.531');
+            it('should return non-integer value with 4+ decimals cut to 4', () => {
+                const rate = PolicyUtils.getRateDisplayValue(10.531255, toLocaleDigitMock, true);
+                expect(rate).toEqual('10.5313');
             });
         });
     });