Merge pull request #43824 from callstack-internal/fix/43276-unnecessa…

…ry-calls-off-triggerUnreadUpdate add debounce and memoization to triggerUnreadUpdate
Expensify · Jun 19, 2024 · af9be0a · af9be0a
2 parents 768da63 + 49336df
commit af9be0a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/src/CONST.ts b/src/CONST.ts
@@ -941,6 +941,7 @@ const CONST = {
         COMMENT_LENGTH_DEBOUNCE_TIME: 500,
         SEARCH_OPTION_LIST_DEBOUNCE_TIME: 300,
         RESIZE_DEBOUNCE_TIME: 100,
+        UNREAD_UPDATE_DEBOUNCE_TIME: 300,
     },
     SEARCH_TABLE_COLUMNS: {
         RECEIPT: 'receipt',

diff --git a/src/libs/UnreadIndicatorUpdater/index.ts b/src/libs/UnreadIndicatorUpdater/index.ts
@@ -1,3 +1,5 @@
+import debounce from 'lodash/debounce';
+import memoize from 'lodash/memoize';
 import type {OnyxCollection} from 'react-native-onyx';
 import Onyx from 'react-native-onyx';
 import * as ReportUtils from '@libs/ReportUtils';
@@ -35,13 +37,16 @@ export default function getUnreadReportsForUnreadIndicator(reports: OnyxCollecti
     );
 }
 
-const triggerUnreadUpdate = () => {
+const memoizedGetUnreadReportsForUnreadIndicator = memoize(getUnreadReportsForUnreadIndicator);
+
+const triggerUnreadUpdate = debounce(() => {
     const currentReportID = navigationRef.isReady() ? Navigation.getTopmostReportId() ?? '-1' : '-1';
 
     // We want to keep notification count consistent with what can be accessed from the LHN list
-    const unreadReports = getUnreadReportsForUnreadIndicator(allReports, currentReportID);
+    const unreadReports = memoizedGetUnreadReportsForUnreadIndicator(allReports, currentReportID);
+
     updateUnread(unreadReports.length);
-};
+}, CONST.TIMING.UNREAD_UPDATE_DEBOUNCE_TIME);
 
 Onyx.connect({
     key: ONYXKEYS.COLLECTION.REPORT,