Skip to content

Commit

Permalink
Merge pull request #47250 from Expensify/andrew-release-tag
Browse files Browse the repository at this point in the history
[No QA]Use `github.event.release.tag_name` instead of `github.ref_name` for releases
  • Loading branch information
roryabraham authored Aug 12, 2024
2 parents ec93cc8 + b152081 commit b7eeeeb
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/platformDeploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ jobs:
- name: Archive Android sourcemaps
uses: actions/upload-artifact@v4
with:
name: android-sourcemap-${{ github.ref_name }}
name: android-sourcemap-${{ github.event.release.tag_name }}
path: android/app/build/generated/sourcemaps/react/productionRelease/index.android.bundle.map

- name: Upload Android build to GitHub artifacts
Expand Down Expand Up @@ -179,7 +179,7 @@ jobs:
- name: Archive desktop sourcemaps
uses: actions/upload-artifact@v4
with:
name: desktop-sourcemap-${{ github.ref_name }}
name: desktop-sourcemap-${{ github.event.release.tag_name }}
path: desktop/dist/www/merged-source-map.js.map

iOS:
Expand Down Expand Up @@ -260,7 +260,7 @@ jobs:
- name: Archive iOS sourcemaps
uses: actions/upload-artifact@v4
with:
name: ios-sourcemap-${{ github.ref_name }}
name: ios-sourcemap-${{ github.event.release.tag_name }}
path: main.jsbundle.map

- name: Upload iOS build to GitHub artifacts
Expand Down Expand Up @@ -353,7 +353,7 @@ jobs:
- name: Archive web sourcemaps
uses: actions/upload-artifact@v4
with:
name: web-sourcemap-${{ github.ref_name }}
name: web-sourcemap-${{ github.event.release.tag_name }}
path: dist/merged-source-map.js.map

- name: Purge Cloudflare cache
Expand All @@ -365,7 +365,7 @@ jobs:
if: ${{ !fromJSON(env.SHOULD_DEPLOY_PRODUCTION) }}
run: |
DOWNLOADED_VERSION="$(wget -q -O /dev/stdout https://staging.new.expensify.com/version.json | jq -r '.version')"
if [[ '${{ github.ref_name }}' != "$DOWNLOADED_VERSION" ]]; then
if [[ '${{ github.event.release.tag_name }}' != "$DOWNLOADED_VERSION" ]]; then
echo "Error: deployed version does not match local version. Something went wrong..."
exit 1
fi
Expand Down

0 comments on commit b7eeeeb

Please sign in to comment.