Merge pull request #31907 from Expensify/monil-fixBadgeWarning

Fix warnings on Settings and Workspace page
Expensify · Nov 28, 2023 · c03a541 · c03a541
2 parents 935608b + fd1319c
commit c03a541
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/pages/settings/InitialSettingsPage.js b/src/pages/settings/InitialSettingsPage.js
@@ -281,9 +281,9 @@ function InitialSettingsPage(props) {
     const getMenuItems = useMemo(() => {
         /**
          * @param {Boolean} isPaymentItem whether the item being rendered is the payments menu item
-         * @returns {Number} the user wallet balance
+         * @returns {String|undefined} the user's wallet balance
          */
-        const getWalletBalance = (isPaymentItem) => isPaymentItem && CurrencyUtils.convertToDisplayString(props.userWallet.currentBalance);
+        const getWalletBalance = (isPaymentItem) => (isPaymentItem ? CurrencyUtils.convertToDisplayString(props.userWallet.currentBalance) : undefined);
 
         return (
             <>

diff --git a/src/pages/workspace/WorkspacesListPage.js b/src/pages/workspace/WorkspacesListPage.js
@@ -114,7 +114,7 @@ function WorkspacesListPage({policies, allPolicyMembers, reimbursementAccount, u
 
     /**
      * @param {Boolean} isPaymentItem whether the item being rendered is the payments menu item
-     * @returns {Number} the user wallet balance
+     * @returns {String|undefined} the user's wallet balance
      */
     function getWalletBalance(isPaymentItem) {
         return isPaymentItem ? CurrencyUtils.convertToDisplayString(userWallet.currentBalance) : undefined;