Skip to content

Commit

Permalink
Fix typecheck on main
Browse files Browse the repository at this point in the history
  • Loading branch information
blazejkustra committed Jan 16, 2024
1 parent 68a28c9 commit c5bb9be
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 6 deletions.
2 changes: 1 addition & 1 deletion src/components/ConfirmModal.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ type ConfirmModalProps = {
onConfirm: () => void;

/** A callback to call when the form has been closed */
onCancel?: (ref?: React.RefObject<HTMLElement>) => void;
onCancel?: () => void;

/** Modal visibility */
isVisible: boolean;
Expand Down
4 changes: 2 additions & 2 deletions src/components/Modal/types.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import type {View, ViewStyle} from 'react-native';
import type {ViewStyle} from 'react-native';
import type {ModalProps} from 'react-native-modal';
import type {ValueOf} from 'type-fest';
import type CONST from '@src/CONST';
Expand All @@ -21,7 +21,7 @@ type BaseModalProps = Partial<ModalProps> & {
shouldSetModalVisibility?: boolean;

/** Callback method fired when the user requests to close the modal */
onClose: (ref?: React.RefObject<View | HTMLDivElement>) => void;
onClose: () => void;

/** State that determines whether to display the modal or not */
isVisible: boolean;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,10 @@ type BaseReportActionContextMenuProps = BaseReportActionContextMenuOnyxProps & {
// eslint-disable-next-line react/no-unused-prop-types
originalReportID: string;

/** If true, this component will be a small, row-oriented menu that displays icons but not text.
If false, this component will be a larger, column-oriented menu that displays icons alongside text in each row. */
/**
* If true, this component will be a small, row-oriented menu that displays icons but not text.
* If false, this component will be a larger, column-oriented menu that displays icons alongside text in each row.
*/
isMini?: boolean;

/** Controls the visibility of this component. */
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ function PopoverReportActionContextMenu(_props: never, ref: ForwardedRef<ReportA
const [hasUnreadMessages, setHasUnreadMessages] = useState(false);

const contentRef = useRef<View>(null);
const anchorRef = useRef<HTMLElement>(null);
const anchorRef = useRef<View | HTMLDivElement>(null);
const dimensionsEventListener = useRef<EmitterSubscription | null>(null);
const contextMenuAnchorRef = useRef<ContextMenuAnchor | null>(null);
const contextMenuTargetNode = useRef<HTMLElement | null>(null);
Expand Down

0 comments on commit c5bb9be

Please sign in to comment.