Fix: User is able to send message with max character limit

Expensify · Oct 9, 2024 · c7227f8 · c7227f8
1 parent 3a6676e
commit c7227f8
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 1 deletion.
diff --git a/src/components/AttachmentModal.tsx b/src/components/AttachmentModal.tsx
@@ -132,6 +132,8 @@ type AttachmentModalProps = {
     fallbackSource?: AvatarSource;
 
     canEditReceipt?: boolean;
+
+    shouldDisableSendButton?: boolean;
 };
 
 function AttachmentModal({
@@ -158,6 +160,7 @@ function AttachmentModal({
     shouldShowNotFoundPage = false,
     type = undefined,
     accountID = undefined,
+    shouldDisableSendButton = false,
 }: AttachmentModalProps) {
     const styles = useThemeStyles();
     const StyleUtils = useStyleUtils();
@@ -589,7 +592,7 @@ function AttachmentModal({
                                         textStyles={[styles.buttonConfirmText]}
                                         text={translate('common.send')}
                                         onPress={submitAndClose}
-                                        isDisabled={isConfirmButtonDisabled}
+                                        isDisabled={isConfirmButtonDisabled || shouldDisableSendButton}
                                         pressOnEnter
                                     />
                                 </Animated.View>

diff --git a/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.tsx b/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.tsx
@@ -86,6 +86,8 @@ type AttachmentPickerWithMenuItemsProps = {
 
     /** The personal details of everyone in the report */
     reportParticipantIDs?: number[];
+
+    shouldDisableAttachmentItem?: boolean;
 };
 
 /**
@@ -110,6 +112,7 @@ function AttachmentPickerWithMenuItems({
     onItemSelected,
     actionButtonRef,
     raiseIsScrollLikelyLayoutTriggered,
+    shouldDisableAttachmentItem,
 }: AttachmentPickerWithMenuItemsProps) {
     const isFocused = useIsFocused();
     const theme = useTheme();
@@ -236,6 +239,7 @@ function AttachmentPickerWithMenuItems({
                             triggerAttachmentPicker();
                         },
                         shouldCallAfterModalHide: true,
+                        disabled: shouldDisableAttachmentItem,
                     },
                 ];
                 return (

diff --git a/src/pages/home/report/ReportActionCompose/ReportActionCompose.tsx b/src/pages/home/report/ReportActionCompose/ReportActionCompose.tsx
@@ -432,6 +432,7 @@ function ReportActionCompose({
                                 onConfirm={addAttachment}
                                 onModalShow={() => setIsAttachmentPreviewActive(true)}
                                 onModalHide={onAttachmentPreviewClose}
+                                shouldDisableSendButton={hasExceededMaxCommentLength}
                             >
                                 {({displayFileInModal}) => (
                                     <>
@@ -451,6 +452,7 @@ function ReportActionCompose({
                                             onAddActionPressed={onAddActionPressed}
                                             onItemSelected={onItemSelected}
                                             actionButtonRef={actionButtonRef}
+                                            shouldDisableAttachmentItem={hasExceededMaxCommentLength}
                                         />
                                         <ComposerWithSuggestions
                                             ref={(ref) => {