Made code DRY for syncTax

Expensify · Jul 3, 2024 · c816f5a · c816f5a
1 parent 4bb20b4
commit c816f5a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 79 deletions.
diff --git a/src/libs/actions/connections/NetSuiteCommands.ts b/src/libs/actions/connections/NetSuiteCommands.ts
@@ -264,85 +264,7 @@ function updateNetSuiteSubsidiary(policyID: string, newSubsidiary: SubsidiaryPar
 }
 
 function updateNetSuiteSyncTaxConfiguration(policyID: string, isSyncTaxEnabled: boolean) {
-    const onyxData: OnyxData = {
-        optimisticData: [
-            {
-                onyxMethod: Onyx.METHOD.MERGE,
-                key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
-                value: {
-                    connections: {
-                        netsuite: {
-                            options: {
-                                config: {
-                                    syncOptions: {
-                                        syncTax: isSyncTaxEnabled,
-                                    },
-                                    // TODO: Fixing in the PR for Import Mapping https://github.com/Expensify/App/pull/44743
-                                    // pendingFields: {
-                                    //     syncTax: CONST.RED_BRICK_ROAD_PENDING_ACTION.UPDATE,
-                                    // },
-                                    errorFields: {
-                                        syncTax: null,
-                                    },
-                                },
-                            },
-                        },
-                    },
-                },
-            },
-        ],
-        successData: [
-            {
-                onyxMethod: Onyx.METHOD.MERGE,
-                key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
-                value: {
-                    connections: {
-                        netsuite: {
-                            options: {
-                                config: {
-                                    syncOptions: {
-                                        syncTax: isSyncTaxEnabled,
-                                    },
-                                    // TODO: Fixing in the PR for Import Mapping https://github.com/Expensify/App/pull/44743
-                                    // pendingFields: {
-                                    //     syncTax: null
-                                    // },
-                                    errorFields: {
-                                        syncTax: null,
-                                    },
-                                },
-                            },
-                        },
-                    },
-                },
-            },
-        ],
-        failureData: [
-            {
-                onyxMethod: Onyx.METHOD.MERGE,
-                key: `${ONYXKEYS.COLLECTION.POLICY}${policyID}`,
-                value: {
-                    connections: {
-                        netsuite: {
-                            options: {
-                                config: {
-                                    syncOptions: {
-                                        syncTax: !isSyncTaxEnabled,
-                                    },
-                                    // pendingFields: {
-                                    //     syncTax: null,
-                                    // },
-                                    errorFields: {
-                                        syncTax: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('common.genericErrorMessage'),
-                                    },
-                                },
-                            },
-                        },
-                    },
-                },
-            },
-        ],
-    };
+    const onyxData = updateNetSuiteSyncOptionsOnyxData(policyID, CONST.NETSUITE_CONFIG.SYNC_OPTIONS.SYNC_TAX, isSyncTaxEnabled, !isSyncTaxEnabled);
 
     const params = {
         policyID,

diff --git a/src/pages/workspace/accounting/netsuite/import/NetSuiteImportPage.tsx b/src/pages/workspace/accounting/netsuite/import/NetSuiteImportPage.tsx
@@ -81,6 +81,7 @@ function NetSuiteImportPage({policy}: WithPolicyConnectionsProps) {
                         onToggle={(isEnabled: boolean) => {
                             updateNetSuiteSyncTaxConfiguration(policyID, isEnabled);
                         }}
+                        pendingAction={config?.syncOptions.pendingFields?.syncTax}
                         errors={ErrorUtils.getLatestErrorField(config ?? {}, CONST.NETSUITE_CONFIG.SYNC_OPTIONS.SYNC_TAX)}
                         onCloseError={() => Policy.clearNetSuiteErrorField(policyID, CONST.NETSUITE_CONFIG.SYNC_OPTIONS.SYNC_TAX)}
                     />