Skip to content

Commit

Permalink
Merge pull request #39996 from nkdengineer/fix/39907
Browse files Browse the repository at this point in the history
fix: Infinite skeleton loading when navigate
  • Loading branch information
cristipaval authored Apr 15, 2024
2 parents 447f0f7 + e10aa1c commit e01d063
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/libs/actions/Welcome.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ let hasSelectedPurpose: boolean | undefined;
let hasProvidedPersonalDetails: boolean | undefined;
let isFirstTimeNewExpensifyUser: boolean | undefined;
let hasDismissedModal: boolean | undefined;
let hasSelectedChoice: boolean | undefined;
let isLoadingReportData = true;

type DetermineOnboardingStatusProps = {
Expand Down Expand Up @@ -89,7 +88,7 @@ function isOnboardingFlowCompleted({onCompleted, onNotCompleted}: HasCompletedOn
* - Whether we have loaded all reports the server knows about
*/
function checkOnReady() {
const hasRequiredOnyxKeysBeenLoaded = [isFirstTimeNewExpensifyUser, hasSelectedChoice, hasDismissedModal].every((value) => value !== undefined);
const hasRequiredOnyxKeysBeenLoaded = [isFirstTimeNewExpensifyUser, hasDismissedModal].every((value) => value !== undefined);

if (isLoadingReportData || !hasRequiredOnyxKeysBeenLoaded) {
return;
Expand Down

0 comments on commit e01d063

Please sign in to comment.