Skip to content

Commit

Permalink
Merge pull request #27483 from Expensify/georgia-midtonePatch
Browse files Browse the repository at this point in the history
Fix undefined color keys
  • Loading branch information
grgia authored Sep 15, 2023
2 parents 7cae1dc + 67913fe commit e48121c
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 5 deletions.
2 changes: 1 addition & 1 deletion src/components/FormHelpMessage.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ function FormHelpMessage(props) {
{props.isError && (
<Icon
src={Expensicons.DotIndicator}
fill={themeColors.success}
fill={themeColors.danger}
/>
)}
<View style={[styles.flex1, props.isError && styles.ml2]}>
Expand Down
4 changes: 2 additions & 2 deletions src/components/TabSelector/TabSelector.js
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,10 @@ const getBackgroundColor = (position, routesLength, tabIndex) => {

return position.interpolate({
inputRange,
outputRange: _.map(inputRange, (i) => (i === tabIndex ? themeColors.midtone : themeColors.appBG)),
outputRange: _.map(inputRange, (i) => (i === tabIndex ? themeColors.border : themeColors.appBG)),
});
}
return themeColors.midtone;
return themeColors.border;
};

function TabSelector({state, navigation, onTabPress, position}) {
Expand Down
2 changes: 1 addition & 1 deletion src/pages/ReimbursementAccount/BankAccountStep.js
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ function BankAccountStep(props) {
<View style={[styles.ml1]}>
<Icon
src={Expensicons.Lock}
fill={themeColors.BRAND_COLORS.blue400}
fill={themeColors.link}
/>
</View>
</PressableWithoutFeedback>
Expand Down
2 changes: 1 addition & 1 deletion src/pages/settings/Profile/CustomStatus/StatusPage.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ function StatusPage({draftStatus, currentUserPersonalDetails}) {
<StaticHeaderPageLayout
title={localize.translate('statusPage.status')}
onBackButtonPress={navigateBackToSettingsPage}
backgroundColor={themeColors.midtone}
backgroundColor={themeColors.PAGE_BACKGROUND_COLORS[ROUTES.SETTINGS_STATUS]}
image={MobileBackgroundImage}
footer={footerComponent}
>
Expand Down
1 change: 1 addition & 0 deletions src/styles/themes/default.js
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,7 @@ darkTheme.PAGE_BACKGROUND_COLORS = {
[SCREENS.HOME]: darkTheme.sidebar,
[SCREENS.SETTINGS.PREFERENCES]: colors.blue500,
[SCREENS.SETTINGS.WORKSPACES]: colors.pink800,
[ROUTES.SETTINGS_STATUS]: colors.green700,
[ROUTES.I_KNOW_A_TEACHER]: colors.tangerine800,
[ROUTES.SETTINGS_SECURITY]: colors.ice500,
};
Expand Down
1 change: 1 addition & 0 deletions src/styles/themes/light.js
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ lightTheme.PAGE_BACKGROUND_COLORS = {
[SCREENS.HOME]: lightTheme.sidebar,
[SCREENS.SETTINGS.PREFERENCES]: colors.blue500,
[SCREENS.SETTINGS.WORKSPACES]: colors.pink800,
[ROUTES.SETTINGS_STATUS]: colors.green700,
[ROUTES.I_KNOW_A_TEACHER]: colors.tangerine800,
[ROUTES.SETTINGS_SECURITY]: colors.ice500,
};
Expand Down

0 comments on commit e48121c

Please sign in to comment.