refactor: remove base64 in cropOrRotateImage

Expensify · Mar 13, 2024 · eb61a54 · eb61a54
1 parent df67dae
commit eb61a54
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 9 deletions.
diff --git a/src/libs/actions/PersonalDetails.ts b/src/libs/actions/PersonalDetails.ts
@@ -382,14 +382,7 @@ function updateAvatar(file: File | CustomRNImageManipulatorResult) {
         },
     ];
 
-    let parameters: UpdateUserAvatarParams = {file};
-
-    // We need to remove the base64 value from the file object, as it is causing crashes on Release builds.
-    // More info: https://github.com/Expensify/App/issues/37963#issuecomment-1989260033
-    if ('base64' in file) {
-        const {base64, ...fileWithoutBase64} = file;
-        parameters = {file: fileWithoutBase64};
-    }
+    const parameters: UpdateUserAvatarParams = {file};
 
     API.write(WRITE_COMMANDS.UPDATE_USER_AVATAR, parameters, {optimisticData, successData, failureData});
 }

diff --git a/src/libs/cropOrRotateImage/index.native.ts b/src/libs/cropOrRotateImage/index.native.ts
@@ -9,7 +9,9 @@ import type {CropOrRotateImage} from './types';
 const cropOrRotateImage: CropOrRotateImage = (uri, actions, options) =>
     new Promise((resolve) => {
         const format = getSaveFormat(options.type);
-        manipulateAsync(uri, actions, {compress: options.compress, format}).then((result) => {
+        // We need to remove the base64 value from the result, as it is causing crashes on Release builds.
+        // More info: https://github.com/Expensify/App/issues/37963#issuecomment-1989260033
+        manipulateAsync(uri, actions, {compress: options.compress, format}).then(({base64, ...result}) => {
             RNFetchBlob.fs.stat(result.uri.replace('file://', '')).then(({size}) => {
                 resolve({
                     ...result,