chore: fixes after code review

Expensify · Jun 24, 2024 · f178843 · f178843
1 parent eda73ca
commit f178843
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/tests/e2e/testRunner.ts b/tests/e2e/testRunner.ts
@@ -26,7 +26,7 @@ import installApp from './utils/installApp';
 import killApp from './utils/killApp';
 import launchApp from './utils/launchApp';
 import * as Logger from './utils/logger';
-import {start, stop} from './utils/measure';
+import * as MeasureUtils from './utils/measure';
 import sleep from './utils/sleep';
 import withFailTimeout from './utils/withFailTimeout';
 
@@ -144,13 +144,13 @@ const runTests = async (): Promise<void> => {
         Logger.log('Launching', appPackage);
         await launchApp('android', appPackage, config.ACTIVITY_PATH, launchArgs);
 
-        start(appPackage);
+        MeasureUtils.start(appPackage);
         await withFailTimeout(
             new Promise<void>((resolve) => {
-                const subscription = server.addTestDoneListener(() => {
+                const removeListener = server.addTestDoneListener(() => {
                     Logger.success(iterationText);
 
-                    const metrics = stop();
+                    const metrics = MeasureUtils.stop();
                     const test = server.getTestConfig();
 
                     if (server.isReadyToAcceptTestResults) {
@@ -170,7 +170,7 @@ const runTests = async (): Promise<void> => {
                             duration: metrics.ram,
                         });
                     }
-                    subscription();
+                    removeListener();
                     resolve();
                 });
             }),

diff --git a/tests/e2e/utils/measure.ts b/tests/e2e/utils/measure.ts
@@ -1,11 +1,12 @@
 import {profiler} from '@perf-profiler/profiler';
 import {getAverageCpuUsage, getAverageFPSUsage, getAverageRAMUsage} from '@perf-profiler/reporter';
 import type {Measure} from '@perf-profiler/types';
-import noop from 'lodash/noop';
 
 let measures: Measure[] = [];
 let polling = {
-    stop: noop,
+    stop: (): void => {
+        throw new Error('Cannot stop polling on a stopped profiler');
+    },
 };
 
 const start = (bundleId: string) => {