Merge pull request #53817 from callstack-internal/chore/remove-report…

…ActionID [No QA] chore: remove reportActionID from report type
Expensify · Dec 10, 2024 · f481d64 · f481d64
2 parents 3982ed0 + ab90c6d
commit f481d64
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 9 deletions.
diff --git a/src/libs/DebugUtils.ts b/src/libs/DebugUtils.ts
@@ -458,7 +458,6 @@ function validateReportDraftProperty(key: keyof Report, value: string) {
         case 'policyID':
         case 'reportName':
         case 'reportID':
-        case 'reportActionID':
         case 'chatReportID':
         case 'type':
         case 'lastMessageTranslationKey':
@@ -595,7 +594,6 @@ function validateReportDraftProperty(key: keyof Report, value: string) {
                 hasParentAccess: CONST.RED_BRICK_ROAD_PENDING_ACTION,
                 isDeletedParentAction: CONST.RED_BRICK_ROAD_PENDING_ACTION,
                 reportName: CONST.RED_BRICK_ROAD_PENDING_ACTION,
-                reportActionID: CONST.RED_BRICK_ROAD_PENDING_ACTION,
                 chatReportID: CONST.RED_BRICK_ROAD_PENDING_ACTION,
                 stateNum: CONST.RED_BRICK_ROAD_PENDING_ACTION,
                 statusNum: CONST.RED_BRICK_ROAD_PENDING_ACTION,

diff --git a/src/types/onyx/Report.ts b/src/types/onyx/Report.ts
@@ -127,9 +127,6 @@ type Report = OnyxCommon.OnyxValueWithOfflineFeedback<
         /** ID of the report */
         reportID: string;
 
-        /** ID of the report action */
-        reportActionID?: string;
-
         /** ID of the chat report */
         chatReportID?: string;
 

diff --git a/src/types/utils/whitelistedReportKeys.ts b/src/types/utils/whitelistedReportKeys.ts
@@ -26,7 +26,6 @@ type WhitelistedReport = OnyxCommon.OnyxValueWithOfflineFeedback<
         policyID: unknown;
         reportName: unknown;
         reportID: string;
-        reportActionID: unknown;
         chatReportID: unknown;
         stateNum: unknown;
         statusNum: unknown;

diff --git a/tests/unit/MiddlewareTest.ts b/tests/unit/MiddlewareTest.ts
@@ -54,7 +54,6 @@ describe('Middleware', () => {
             TestHelper.assertFormDataMatchesObject(
                 {
                     reportID: '1234',
-                    reportActionID: '5678',
                 },
                 ((global.fetch as jest.Mock).mock.calls.at(1) as FormDataObject[]).at(1)?.body,
             );
@@ -109,7 +108,6 @@ describe('Middleware', () => {
             TestHelper.assertFormDataMatchesObject(
                 {
                     reportID: '5555',
-                    reportActionID: '5678',
                 },
                 ((global.fetch as jest.Mock).mock.calls.at(1) as FormDataObject[]).at(1)?.body,
             );

diff --git a/tests/utils/collections/optionData.ts b/tests/utils/collections/optionData.ts
@@ -36,7 +36,6 @@ export default function createRandomOptionData(index: number): OptionData {
         description: randWord(),
         isDeletedParentAction: randBoolean(),
         reportName: randWord(),
-        reportActionID: `reportAction_${index}`,
         chatReportID: `chatReport_${index}`,
         stateNum: rand(Object.values(CONST.REPORT.STATE_NUM)),
         statusNum: rand(Object.values(CONST.REPORT.STATUS_NUM)),