Fixing the approval rules inside the optimistic rules

Expensify · Dec 7, 2024 · f8f5c02 · f8f5c02
1 parent 6a7b207
commit f8f5c02
Showing 1 changed file with 3 additions and 10 deletions.
diff --git a/src/libs/actions/Policy/Member.ts b/src/libs/actions/Policy/Member.ts
@@ -296,17 +296,7 @@ function removeMembers(accountIDs: number[], policyID: string) {
         failureMembersState[email] = {errors: ErrorUtils.getMicroSecondOnyxErrorWithTranslationKey('workspace.people.error.genericRemove')};
     });
 
-    const approvalRules: ApprovalRule[] = policy?.rules?.approvalRules ?? [];
-    const optimisticApprovalRules: ApprovalRule[] = [];
-
     Object.keys(policy?.employeeList ?? {}).forEach((employeeEmail) => {
-        approvalRules.forEach((rule) => {
-            if (employeeEmail === rule?.approver) {
-                return;
-            }
-            optimisticApprovalRules.push(rule);
-        });
-
         const employee = policy?.employeeList?.[employeeEmail];
         optimisticMembersState[employeeEmail] = optimisticMembersState[employeeEmail] ?? {};
         failureMembersState[employeeEmail] = failureMembersState[employeeEmail] ?? {};
@@ -342,6 +332,9 @@ function removeMembers(accountIDs: number[], policyID: string) {
         }
     });
 
+    const approvalRules: ApprovalRule[] = policy?.rules?.approvalRules ?? [];
+    const optimisticApprovalRules = approvalRules.filter((rule) => !emailList.includes(rule?.approver ?? ''));
+
     const optimisticData: OnyxUpdate[] = [
         {
             onyxMethod: Onyx.METHOD.MERGE,