Fix after internal review

Expensify · Jun 25, 2024 · f9578f9 · f9578f9
1 parent bfb7032
commit f9578f9
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/desktop/main.ts b/desktop/main.ts
@@ -141,7 +141,7 @@ const manuallyCheckForUpdates = (menuItem?: MenuItem, browserWindow?: BrowserWin
 
     autoUpdater
         .checkForUpdates()
-        .catch((error: Error) => {
+        .catch((error: unknown) => {
             isSilentUpdating = false;
             return {error};
         })

diff --git a/src/libs/Navigation/switchPolicyID.ts b/src/libs/Navigation/switchPolicyID.ts
@@ -32,11 +32,11 @@ function getActionForBottomTabNavigator(action: StackNavigationAction, state: Na
         return;
     }
 
-    let name;
+    let name: string | undefined;
     let params: Record<string, string | undefined>;
     if (isCentralPaneName(action.payload.name)) {
         name = action.payload.name;
-        params = action.payload.params;
+        params = action.payload.params as Record<string, string | undefined>;
     } else {
         const actionPayloadParams = action.payload.params as ActionPayloadParams;
         name = actionPayloadParams.screen;

diff --git a/src/libs/Notification/clearReportNotifications/index.native.ts b/src/libs/Notification/clearReportNotifications/index.native.ts
@@ -34,7 +34,7 @@ const clearReportNotifications: ClearReportNotifications = (reportID: string) =>
             Log.info(`[PushNotification] found ${reportNotificationIDs.length} notifications to clear`, false, {reportID});
             reportNotificationIDs.forEach((notificationID) => Airship.push.clearNotification(notificationID));
         })
-        .catch((error: Error) => {
+        .catch((error: unknown) => {
             Log.alert(`${CONST.ERROR.ENSURE_BUGBOT} [PushNotification] BrowserNotifications.clearReportNotifications threw an error. This should never happen.`, {reportID, error});
         });
 };

diff --git a/src/libs/actions/Session/index.ts b/src/libs/actions/Session/index.ts
@@ -768,7 +768,7 @@ function authenticatePusher(socketID: string, channelName: string, callback: Cha
             Log.info('[PusherAuthorizer] Pusher authenticated successfully', false, {channelName});
             callback(null, response as ChannelAuthorizationData);
         })
-        .catch((error: Error) => {
+        .catch((error: unknown) => {
             Log.hmmm('[PusherAuthorizer] Unhandled error: ', {channelName, error});
             callback(new Error('AuthenticatePusher request failed'), {auth: ''});
         });