Skip to content

Commit

Permalink
Merge pull request #10796 from Expensify/OSBotify-cherry-pick-staging…
Browse files Browse the repository at this point in the history
…-10780

🍒 Cherry pick PR #10780 to staging 🍒
  • Loading branch information
OSBotify authored Sep 2, 2022
2 parents 7964a32 + 76aad98 commit fe53e66
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 12 deletions.
4 changes: 2 additions & 2 deletions android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,8 @@ android {
minSdkVersion rootProject.ext.minSdkVersion
targetSdkVersion rootProject.ext.targetSdkVersion
multiDexEnabled rootProject.ext.multiDexEnabled
versionCode 1001019604
versionName "1.1.96-4"
versionCode 1001019605
versionName "1.1.96-5"
buildConfigField "boolean", "IS_NEW_ARCHITECTURE_ENABLED", isNewArchitectureEnabled().toString()

if (isNewArchitectureEnabled()) {
Expand Down
2 changes: 1 addition & 1 deletion ios/NewExpensify/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
</dict>
</array>
<key>CFBundleVersion</key>
<string>1.1.96.4</string>
<string>1.1.96.5</string>
<key>ITSAppUsesNonExemptEncryption</key>
<false/>
<key>LSApplicationQueriesSchemes</key>
Expand Down
2 changes: 1 addition & 1 deletion ios/NewExpensifyTests/Info.plist
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,6 @@
<key>CFBundleSignature</key>
<string>????</string>
<key>CFBundleVersion</key>
<string>1.1.96.4</string>
<string>1.1.96.5</string>
</dict>
</plist>
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "new.expensify",
"version": "1.1.96-4",
"version": "1.1.96-5",
"author": "Expensify, Inc.",
"homepage": "https://new.expensify.com",
"description": "New Expensify is the next generation of Expensify: a reimagination of payments based atop a foundation of chat.",
Expand Down
7 changes: 3 additions & 4 deletions src/libs/actions/Report.js
Original file line number Diff line number Diff line change
Expand Up @@ -1103,13 +1103,12 @@ Onyx.connect({
*/
function deleteReportComment(reportID, reportAction) {
const sequenceNumber = reportAction.sequenceNumber;

// We are not updating the message content here so the message can re-appear as strike-throughed
// if the user goes offline. The API will update the message content to empty strings on success.
const optimisticReportActions = {
[sequenceNumber]: {
pendingAction: CONST.RED_BRICK_ROAD_PENDING_ACTION.DELETE,
message: [{
html: '',
text: '',
}],
},
};

Expand Down
9 changes: 8 additions & 1 deletion src/pages/home/report/ReportActionItemFragment.js
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,12 @@ const propTypes = {
/** Should this fragment be contained in a single line? */
isSingleLine: PropTypes.bool,

// Additional styles to add after local styles
style: PropTypes.oneOfType([
PropTypes.arrayOf(PropTypes.object),
PropTypes.object,
]),

...windowDimensionsPropTypes,

/** localization props */
Expand All @@ -69,6 +75,7 @@ const defaultProps = {
isSingleLine: false,
tooltipText: '',
source: '',
style: [],
};

const ReportActionItemFragment = (props) => {
Expand Down Expand Up @@ -119,7 +126,7 @@ const ReportActionItemFragment = (props) => {
<Text
family="EMOJI_TEXT_FONT"
selectable={!canUseTouchScreen() || !props.isSmallScreenWidth}
style={[EmojiUtils.containsOnlyEmojis(text) ? styles.onlyEmojisText : undefined, styles.ltr]}
style={[EmojiUtils.containsOnlyEmojis(text) ? styles.onlyEmojisText : undefined, styles.ltr, ...props.style]}
>
{StyleUtils.convertToLTR(Str.htmlDecode(text))}
{props.fragment.isEdited && (
Expand Down
1 change: 1 addition & 0 deletions src/pages/home/report/ReportActionItemMessage.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ const ReportActionItemMessage = (props) => {
attachmentInfo={props.action.attachmentInfo}
source={lodashGet(props.action, 'originalMessage.source')}
loading={props.action.isLoading}
style={props.style}
/>
))}
</View>
Expand Down

0 comments on commit fe53e66

Please sign in to comment.