-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add teamdot check to SideBarUtils.js #11244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
|
Adding the CP label, guides are running into this in prod https://expensify.slack.com/archives/C036S0BVAHH/p1663955934830269 |
Going to self merge this. Tim is OOO today, and guides are running into this, impacting their workflow. |
@alex-mechler looks like this was merged without passing tests. Please add a note explaining why this was done and remove the |
See above, guides were running into this, impacting 121 assignments |
(cherry picked from commit 85584c3)
…-11244 🍒 Cherry pick PR #11244 to staging 🍒
🚀 Deployed to production by @luacmartins in version: 1.2.5-2 🚀
|
🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
The checklist was not completed because we wanted to hotfix this asap #11244 (comment) |
@tgolen will you review please?
Details
While you were working on #10800, we added another bypass to the beta in #10855. As a result, SideBarUtils didn't have this check. This PR adds the extra bypass check to SideBarUtils as well
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/229968
Tests
- [ ] Verify that no errors appear in the JS console
QA Steps
- [ ] Verify that no errors appear in the JS console