Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add teamdot check to SideBarUtils.js #11244

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Conversation

alex-mechler
Copy link
Contributor

@tgolen will you review please?

Details

While you were working on #10800, we added another bypass to the beta in #10855. As a result, SideBarUtils didn't have this check. This PR adds the extra bypass check to SideBarUtils as well

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/229968

Tests

  1. (Dev) turned off all forced betas
  2. Signed into an account that was not on the beta, but had an assigned guide
  3. Verified I saw the #admins room in the sidebar

image

- [ ] Verify that no errors appear in the JS console

QA Steps

  1. On OldDot, from a public domain account (gmail.com for example), create a new corporate policy
  2. Navigate to NewDot and sign in to the same account
  3. Verify you see the #admins room in the side bar

image

- [ ] Verify that no errors appear in the JS console

@alex-mechler alex-mechler requested a review from tgolen September 23, 2022 17:08
@alex-mechler alex-mechler requested a review from a team as a code owner September 23, 2022 17:08
@alex-mechler alex-mechler self-assigned this Sep 23, 2022
@melvin-bot melvin-bot bot requested review from marcochavezf and removed request for a team September 23, 2022 17:08
Copy link
Contributor

@marcochavezf marcochavezf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@github-actions
Copy link
Contributor

⚠️ ⚠️ Heads up! This pull request has the CP Staging label. ⚠️ ⚠️
Merging it will cause it to be immediately deployed to staging, even if the open StagingDeployCash deploy checklist is locked.

@alex-mechler
Copy link
Contributor Author

Adding the CP label, guides are running into this in prod https://expensify.slack.com/archives/C036S0BVAHH/p1663955934830269

@alex-mechler
Copy link
Contributor Author

Going to self merge this. Tim is OOO today, and guides are running into this, impacting their workflow.

@alex-mechler alex-mechler merged commit 85584c3 into main Sep 23, 2022
@alex-mechler alex-mechler deleted the amechler-add-team-dot-check branch September 23, 2022 18:16
@melvin-bot
Copy link

melvin-bot bot commented Sep 23, 2022

@alex-mechler looks like this was merged without passing tests. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Sep 23, 2022
@alex-mechler
Copy link
Contributor Author

See above, guides were running into this, impacting 121 assignments

OSBotify pushed a commit that referenced this pull request Sep 23, 2022
OSBotify added a commit that referenced this pull request Sep 23, 2022
@OSBotify
Copy link
Contributor

🚀 Deployed to production by @luacmartins in version: 1.2.5-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/AndrewGable in version: 1.3.28-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@marcochavezf
Copy link
Contributor

The checklist was not completed because we wanted to hotfix this asap #11244 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants