Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deploy Checklist: New Expensify 2023-06-14 #20782

Closed
OSBotify opened this issue Jun 14, 2023 · 19 comments
Closed

Deploy Checklist: New Expensify 2023-06-14 #20782

OSBotify opened this issue Jun 14, 2023 · 19 comments
Assignees
@applausebot
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jun 14, 2023 •
edited by AndrewGable
Loading

Release Version: 1.3.28-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

Internal QA:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads
@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jun 14, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.28-0 🚀

@justinpersaud justinpersaud added 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging and removed 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging labels Jun 14, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.28-1 🚀

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.28-3 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.28-3 has been deployed to staging 🎉

@mvtglobally
Copy link

We are starting QA as the new build is available. Are you able to help to check off all the old PRs ?

@Julesssss Julesssss mentioned this issue Jun 15, 2023
Closed
6 tasks
@Julesssss
Copy link
Contributor

Checking off #20814. It's a regression, but not worth blocking the deploy.

@marcaaron
Copy link
Contributor

Checking off #20832 as this is a new feature and it not working does not have any bad effects on the app.

@OSBotify
Copy link
Contributor Author

👏 Heads up @Expensify/applauseleads 👏
A new pull request has been 🍒 cherry-picked 🍒 to staging, and will be deployed to staging in version 1.3.28-5 🚀

@OSBotify
Copy link
Contributor Author

🎉 All set?…You bet! @Expensify/applauseleads https://github.com/Expensify/App/releases/tag/1.3.28-5 has been deployed to staging 🎉

@Beamanator
Copy link
Contributor

checked off #20879 b/c it's an exact dupe of #20867

Also checked off #20220 because it's a straight revert of a small onyx refactor, and we tested once the revert was merged.

@mvtglobally
Copy link

@mountiny Regression is almost completed, checking few last PRs

Current fails summary
PR #17288 is failing #20832
PR #19377 is failing #20835 & #20836
PR #20336 is failing #20847. Pending IOS validation
PR #20545 is failing #19920. Repro in Prod checking off
PR #20556 is failing #20313
PR #20639 is failing #20878. Repro in prod
PR #20671 is failing #20882

@mountiny
Copy link
Contributor

Checking #20671 as the found issue is not significant enough to be a blocker

Checking #20639 off since its repro in prod

checking #20556 off since its not failing with new issue but one platform seems not to be fixed

Checking #20545 off since the issue is repro in prod

Checking #20336 off too since the issue is repro in production

checking #17288 its a backend issue

@mvtglobally
Copy link

Last open issues

#20477 pending validation
#20350 is failing. Getting issue in a few
#20228 failing #20899. Repro in prod
#20014 I think was deployed before. Can you pls double check

@mvtglobally
Copy link

mvtglobally commented Jun 16, 2023 •
edited
Loading

Checking off #20477

PR #20350 issue found #20903. Repro in prod.

@mountiny
Copy link
Contributor

#20014 I think was deployed before. Can you pls double check

I agree, seems like it

PR #20350 issue found #20903. Repro in prod.

Not sure if that is necessarilly an issue either.

Thanks! 3 blockers left.

@mvtglobally
Copy link

Regression is completed

@AndrewGable
Copy link
Contributor

Checked off #20350 and #20228 as they were reproducible in production. We discussed blockers here: https://expensify.slack.com/archives/C01GTK53T8Q/p1686927569956089

Added one deploy blocker as we want to include it with the release.

@AndrewGable
Copy link
Contributor

Deploy blocker was resolved, deploying now

@AndrewGable
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@applausebot applausebot

Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@justinpersaud @AndrewGable @Beamanator @Julesssss @marcaaron @mountiny @applausebot @mvtglobally @OSBotify