[Regression in PR][$250] Clicking on "New Messages" jumps to newest messages, skipping over any messages marked unread report by @chauchausoup

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to any chat
2. Click at Mark as Unread
3. Click on New Messages button

Expected Result:

Clicking "new messages" should jump directly to the message marked as Unread

Actual Result:

Clicking "new messages" jumps to the bottom of the message thread, skipping over the message marked as unread

Workaround:

Unknown

Platform:

Where is this issue occurring?

• Web

Version Number: 1.2.11-2
Reproducible in staging?: Y
Reproducible in production?: Y
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos:
https://user-images.githubusercontent.com/43996225/193866710-b8402785-759a-4f1f-aa86-80b0878cb3c9.mov
https://user-images.githubusercontent.com/43996225/193866742-10e455e5-acd7-4d2d-862a-b61a85c3e9c5.mp4
Expensify/Expensify Issue URL:
Issue reported by: @chauchausoup
Slack conversation: https://expensify.slack.com/archives/C01GTK53T8Q/p1664725500869019
View all open jobs on GitHub

[melvin-bot]

Triggered auto assignment to @greg-schroeder (AutoAssignerTriage), see https://stackoverflow.com/c/expensify/questions/4749 for more details.

[greg-schroeder]

I reproduced this on the desktop app:

2022-10-04_14-57-19.mp4

Adjusted some of the OP to make it clearer

[melvin-bot]

Triggered auto assignment to @srikarparsi (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[melvin-bot]

Triggered auto assignment to @conorpendergrast (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @eVoloshchak (External)

[melvin-bot]

Current assignee @srikarparsi is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

@conorpendergrast, @eVoloshchak, @srikarparsi Whoops! This issue is 2 days overdue. Let's get this updated quick!

[conorpendergrast]

Oops, I'll get to this today, sorry!

[JmillsExpensify]

This is just my opinion, but to me that's worse than any bug. It signals that we're no longer in control and likely need to change something about our process.

I agree with @marcaaron here. @conorpendergrast @srikarparsi I think we need to treat this an a top priority for today and get the RCA published. We've got to figure out how we avoid this in the future, and especially changing defined/designed behaviors in the app.

[conorpendergrast]

Before we do that, let's agree the behaviour we expect. Discussing that in Slack now!

[conorpendergrast]

Based on the Slack discussion and the original design (Expensify internal doc link), I agree that I triaged this incorrectly and identified it as a bug when it was not a bug, and we should revert with an RCA 👍

This is a “feature bug” (I disagree with the design) not a “bug” (the design is working as expected), because the function of the new messages button is:

Tapping it will bring you to the bottom of the chat

[conorpendergrast]

Reversion PR is here: #13230
And @srikarparsi is working on an RCA!

[conorpendergrast]

Scroll up, Melv

[melvin-bot]

@conorpendergrast, @srikarparsi Whoops! This issue is 2 days overdue. Let's get this updated quick!

[srikarparsi]

Issue reverted here: #13230

Will close after the PR gets deployed and I respond to @conorpendergrast's comments in the RCA

[melvin-bot]

Triggered auto assignment to @tjferriss (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[conorpendergrast]

I'm re-assigning to another BugZero team member in case there are any further steps, as I'm going on sabbatical in 30 minutes!

[srikarparsi]

PR to address one change in the RCA: #13518
Will bring up the other proposed changes from the RCA in slack

[trjExpensify]

👋 Hey everyone! Can you give me an update on why this issue is still open, and what we need to do to close it out? I'm trying to piece it together:

1. The PR to revert the change has been merged
2. The linked PR with some action from the RCA has been closed add comment to explain scroll to bottom #13518
3. Potentially something about other proposed changed from the RCA are in slack, but not sure where that is or what (if any) actions we need to take from that?

Thanks!

[melvin-bot]

@tjferriss, @srikarparsi Whoops! This issue is 2 days overdue. Let's get this updated quick!

[srikarparsi]

hey @trjExpensify! I think this issue is ready to be closed out, the PR has been reverted, the RCA has been completed, and I'm talking to marc about the proposed changes in the RCA but I believe that can be continued with this issue closed. @tjferriss @tjferriss please reopen it though if there's something that I'm missing.