[$250] Migrate BaseOptionsSelector.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/components/OptionsSelector/BaseOptionsSelector.js
  • type: React.Component
  • has state values: true
  • has refs: true
  • has context: false
  • lifecycle methods: componentDidMount,componentWillUnmount,componentDidUpdate

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~018a6f55da7cfbd26a
• Upwork Job ID: 1727071636393496576
• Last Price Increase: 2023-11-21

[s-alves10]

I'd love to work on this.

[dayana7204]

I am ready to work on this ticket. :)

[melvin-bot]

📣 @dayana7204! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[olexyt]

I can work on this issue.

[rayane-djouah]

Can I work on this issue?

[mejed-alkoutaini]

I'm able to work on this if needed!

[mkhutornyi]

I'd like to work on this.

[KrAbhas]

I can work on this

[dexexpert]

I hope to work on this task.

[Piotrfj]

Hi I'm Piotr from Callstack - expert contributor group - will start investigation in this area

[melvin-bot]

📣 @Piotrfj! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[Piotrfj]

Today im OOO

[Piotrfj]

PR is under internal review now

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~018a6f55da7cfbd26a

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @shubham1206agra (External)

[thienlnam]

Just added the External label to get a C+ assigned to this issue. The PR is ready to review here

cc @shubham1206agra

[shubham1206agra]

@thienlnam Looks like checklist is not complete. Should I wait for review?

[thienlnam]

Ah good point, let's have the contributor complete that first

[Piotrfj]

Link to PR: #31606

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[roryabraham]

I think we're going to revert the PR because it caused many regressions. That said, I did a substantial amount of refactoring to get this component to a much better place in #37353. @Piotrfj I hope you use it as a reference to help clean up this component. and I want to review the PR as well

[roryabraham]

Created a slack thread to discuss: https://expensify.slack.com/archives/C01GTK53T8Q/p1709156803359359

[Piotrfj]

Update: re-refactoring is ready to be tested, it fixes all the regression issues I was aware of. Please test it (especially the tags, because I could not yet replicate the scenario on my site).
The fix is based on the @roryabraham solution, so special thanks for him!
Link to PR: #37494

[roryabraham]

Sorry for the back-and-forth, but coming from this discussion I see that OptionsSelector is essentially deprecated, so I propose that we actually close the above PR and this issue, and plan to focus on removing the deprecated OptionsSelector altogether

[Piotrfj]

@roryabraham let me know about the final decision about this issue

[roryabraham]

Yes, let's not invest time and money refactoring something that's deprecated. Let's instead invest resources in removing it completely