-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/16184 base options selector re refactoring #37494
Fix/16184 base options selector re refactoring #37494
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that many deps. arrays don't include all required items. I understand it could be. So please verify that everything is current.
Running perf tests a second time |
@Piotrfj can you take a look at the failing test?
|
OptionsSelector is now deprecated |
…4-base-options-selector-re-refactoring # Conflicts: # src/components/OptionsSelector/BaseOptionsSelector.js
Was discussing about this internally and we agree that since this component is deprecated and the last time we tried to migrate it created a lot of regressions, it is better to just close this issue. |
Based on this #16184 (comment) we can close this PR |
Details
Fixed Issues
$ #16184
PROPOSAL: #16184 (comment)
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Kapture.2024-01-09.at.16.41.22.mp4
MacOS: Desktop
Kapture.2024-01-10.at.23.25.12.mp4