[HOLD for payment 2023-07-28] [$250] Migrate RadioButtons.js to function component

[marcaaron]

Class Component Migration

Filenames

• src/components/RadioButtons.js
  • type: React.Component
  • has state values: true
  • has refs: false
  • has context: false
  • lifecycle methods: none

Task

• We currently have some class components in our codebase that we would like to refactor to a function component.
• Here's a link with some general advice on how to refactor a class component to a function component: https://react.dev/reference/react/Component#alternatives
• If you need additional guidance, please ask in #expensify-open-source
• Test for any regressions and verify that there are no breaking changes

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0167493f0dce0f663f
• Upwork Job ID: 1678837331340034048
• Last Price Increase: 2023-07-11

[s-alves10]

I'd love to work on this.

[dayana7204]

I am ready to work on this ticket. :)

[melvin-bot]

📣 @dayana7204! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[dayana7204]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01be516fe8babc58d6

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[olexyt]

I can work on this issue.

[rayane-djouah]

Can I work on this?

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0167493f0dce0f663f

[melvin-bot]

Triggered auto assignment to @greg-schroeder (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @s77rt (External)

[rayane-djouah]

Can I work on this issue?

[alexxxwork]

I would love to work on this issue

[payal-lathidadiya]

dibs?

[alpeshl]

Can I work on this?

[kmwamasali]

would like to work on this

[yh-0218]

I can work on this task. Thanks.

[to-ai]

I am able to work on this task.

[mkhutornyi]

I'd like to work on this.

[PhantomOz]

####Here is my proposal for how I will fix this issue:

• I will use the React Hooks API to convert the class component to a function component. Specifically, I will use the useState hook to manage the state values, the useRef hook to create and access the refs, and the useEffect hook to replicate the componentDidMount behavior.
• I will also use the React.memo function to wrap the function component and optimize its rendering performance. This will ensure that the component only re-renders when its props change.
• I will test the refactored component on all platforms (iOS, Android, web, desktop) to make sure that it works as expected and does not introduce any regressions or breaking changes.

[s77rt]

Thank you all for your interest here.

• @rayane-djouah Skipping since you are "assigned" to another migration (here)
• @alexxxwork Skipping since you should get assigned to another migration (here)
• @payal-lathidadiya Let's do it! 🚀

🎀 👀 🎀 C+ reviewed

[melvin-bot]

Triggered auto assignment to @robertjchen, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[robertjchen]

Sounds good, let's do it!

[melvin-bot]

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Upwork job

[melvin-bot]

📣 @payal-lathidadiya 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[payal-lathidadiya]

PR is up for review

cc: @s77rt @robertjchen

[melvin-bot]

@robertjchen, @s77rt, @greg-schroeder, @payal-lathidadiya Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[s77rt]

Not overdue. PR is merged.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.43-7 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [NoQA] refactor: migrate RadioButtons to function component #22770

If no regressions arise, payment will be issued on 2023-07-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @s77rt requires payment
• @payal-lathidadiya requires payment

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[greg-schroeder]

Assigned: July 12th
Merged: July 19th

Payments:

@payal-lathidadiya - C = $250
@s77rt - C+ = $250

[greg-schroeder]

Please accept the offer @payal-lathidadiya and you'll be paid accordingly! All set to go here otherwise.

[payal-lathidadiya]

accepted, thank you