[NoQA] refactor: migrate RadioButtons to function component #22770

payal-lathidadiya · 2023-07-12T19:31:10Z

Details

Migrate RadioButtons.js to function component

Fixed Issues

Tests

[DEV] I think the simplest way to test it, without the account with a wallet, is to hardcode questions. You can do it by changing these lines in AdditionalDetailsStep.js:

 if (!_.isEmpty(this.props.walletAdditionalDetails.questions)) {
       ...
 }

to:

 const questions = [{answer: ['1251', '6253', '113', 'None of the above', 'Skip Question'], prompt: 'Which number goes with your address on MASONIC AVE?', type: 'street.number.b'}];
 if (!_.isEmpty(questions)) {
     return (
         <ScreenWrapper
             style={[styles.flex1]}
             keyboardAvoidingViewBehavior="height"
         >
             <HeaderWithBackButton
                 title={this.props.translate('additionalDetailsStep.headerTitle')}
                 onBackButtonPress={() => Wallet.setAdditionalDetailsQuestions(null)}
             />
             <IdologyQuestions
                 questions={questions}
                 idNumber={this.props.walletAdditionalDetails.idNumber}
             />
         </ScreenWrapper>
     );
 }

Access the Idology question section inside Enable Payments Page by entering:
http://localhost:8080/enable-payments
To test this on other platform Desktop, android/ios app, you can send link for this to some chat and click to open that
Click/Press the radio button, verify styling and behavior

NOTES:

Deep-link into the enable-payments page:
- Android: adb shell am start -a android.intent.action.VIEW -d new-expensify://enable-payments
- iOS: xcrun simctl openurl booted new-expensify://enable-payments
- Web/mWeb: go to /enable-payments in the browser
- There's no deeplinking set up for the desktop app yet, so we'll just trust that the layout will be the same
Verify that no errors appear in the JS console

Offline tests

QA Steps

NA

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-07-12T19:31:15Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s77rt · 2023-07-13T08:47:03Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

s77rt · 2023-07-13T08:49:13Z

@payal-lathidadiya Can you please merge main to fix the lint issue and update the QA steps to better easy steps that does not require code change (ask in Slack if in doubt).

BTW, for deep links you can simply send your self a link and click on it.

payal-lathidadiya · 2023-07-13T10:27:15Z

update the QA steps to better easy steps that does not require code change (ask in Slack if in doubt).

@s77rt thanks for review and feedback.

I was going through past development in this module, but couldn't really find easy way to test this locally.
I got few information from recent development here and some reference from this

Sure, I can further check for help in slack if there is better way to approach testing of this. thanks for callout.

BTW, for deep links you can simply send your self a link and click on it.

Not sure I followed, can you explain a bit more.

s77rt · 2023-07-13T11:20:17Z

@payal-lathidadiya I see, in case no clear QA tests are found we can probably skip this.

Not sure I followed, can you explain a bit more.

I'm just suggesting an alternative way to access deep link, instead of going through adb and xcrun to access a deep link, you can just go to a chat and send the deep link you want to access then click on it. This is much easier and works on all platforms including Desktop.

payal-lathidadiya · 2023-07-13T12:12:45Z

Not sure I followed, can you explain a bit more.

I'm just suggesting an alternative way to access deep link, instead of going through adb and xcrun to access a deep link, you can just go to a chat and send the deep link you want to access then click on it. This is much easier and works on all platforms including Desktop.

Awh! gotcha. this is helpful. thanks

payal-lathidadiya · 2023-07-18T18:44:13Z

@s77rt Gentle reminder in case you missed this!

s77rt · 2023-07-18T18:50:06Z

I didn't 😅 I thought we are waiting for the QA steps from the Slack thread. Well let's just treat this as noQa and move on. Please update the title and prefix it with [NoQA] and remove the QA steps.

s77rt

LGTM! 🚀

robertjchen

LGTM!

melvin-bot · 2023-07-19T05:55:48Z

Congrats, that’s your 5th PR merged! 🎉 Do you know about the ContributorPlus role? It’s an opportunity to earn more in the Expensify Open Source community. Keep up the great work - thanks!

OSBotify · 2023-07-19T05:59:25Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-19T18:00:26Z

🚀 Deployed to staging by https://github.com/robertjchen in version: 1.3.43-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-07-20T18:21:27Z

🚀 Deployed to staging by https://github.com/robertjchen in version: 1.3.43-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-07-21T18:52:27Z

🚀 Deployed to staging by https://github.com/robertjchen in version: 1.3.44-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-22T00:19:35Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.43-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-07-25T01:26:24Z

🚀 Deployed to production by https://github.com/marcaaron in version: 1.3.44-2 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

refactor: migrate RadioButtons to function component

d195865

payal-lathidadiya requested a review from a team as a code owner July 12, 2023 19:31

melvin-bot bot requested review from s77rt and removed request for a team July 12, 2023 19:31

payal-lathidadiya mentioned this pull request Jul 12, 2023

[HOLD for payment 2023-07-28] [$250] Migrate RadioButtons.js to function component #16194

Closed

1 task

Merge branch 'Expensify:main' into refactor/migrate-radiobuttons

d78fdf3

payal-lathidadiya changed the title ~~refactor: migrate RadioButtons to function component~~ [NoQA] refactor: migrate RadioButtons to function component Jul 18, 2023

s77rt approved these changes Jul 18, 2023

View reviewed changes

melvin-bot bot requested a review from robertjchen July 18, 2023 19:01

robertjchen approved these changes Jul 19, 2023

View reviewed changes

robertjchen merged commit ee2d4fd into Expensify:main Jul 19, 2023

OSBotify mentioned this pull request Jul 19, 2023

Deploy Checklist: New Expensify 2023-07-19 #23183

Closed

42 tasks

OSBotify mentioned this pull request Jul 21, 2023

Deploy Checklist: New Expensify 2023-07-21 #23362

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NoQA] refactor: migrate RadioButtons to function component #22770

[NoQA] refactor: migrate RadioButtons to function component #22770

payal-lathidadiya commented Jul 12, 2023 •

edited

Loading

melvin-bot bot commented Jul 12, 2023

s77rt commented Jul 13, 2023 •

edited

Loading

s77rt commented Jul 13, 2023

payal-lathidadiya commented Jul 13, 2023

s77rt commented Jul 13, 2023

payal-lathidadiya commented Jul 13, 2023

payal-lathidadiya commented Jul 18, 2023

s77rt commented Jul 18, 2023

s77rt left a comment

robertjchen left a comment

melvin-bot bot commented Jul 19, 2023

OSBotify commented Jul 19, 2023

OSBotify commented Jul 19, 2023

OSBotify commented Jul 20, 2023

OSBotify commented Jul 21, 2023

OSBotify commented Jul 22, 2023

OSBotify commented Jul 25, 2023

[NoQA] refactor: migrate RadioButtons to function component #22770

[NoQA] refactor: migrate RadioButtons to function component #22770

Conversation

payal-lathidadiya commented Jul 12, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 12, 2023

s77rt commented Jul 13, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

s77rt commented Jul 13, 2023

payal-lathidadiya commented Jul 13, 2023

s77rt commented Jul 13, 2023

payal-lathidadiya commented Jul 13, 2023

payal-lathidadiya commented Jul 18, 2023

s77rt commented Jul 18, 2023

s77rt left a comment

Choose a reason for hiding this comment

robertjchen left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jul 19, 2023

OSBotify commented Jul 19, 2023

OSBotify commented Jul 19, 2023

OSBotify commented Jul 20, 2023

OSBotify commented Jul 21, 2023

OSBotify commented Jul 22, 2023

OSBotify commented Jul 25, 2023

payal-lathidadiya commented Jul 12, 2023 •

edited

Loading

s77rt commented Jul 13, 2023 •

edited

Loading