Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment][$1000] Chat - "Report no longer exists" message upon removing image that has deleted thread #19559

Closed
1 of 6 tasks
kbecciv opened this issue May 24, 2023 · 83 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@kbecciv
Copy link

kbecciv commented May 24, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Open staging.new.expensify.com
  2. Send an image to a chat
  3. Make a thread on that message using Reply in thread
  4. From the thread chat, leave the thread by Details > Leave thread
  5. Delete the image

Expected Result:

Image removed successfully without any error

Actual Result:

Empty image returned with the error "Report no longer exists" after deletion

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.17.2

Reproducible in staging?: Yes

Reproducible in production?: yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Recording.2819.mp4
Removed.Image.Thread.mp4

Expensify/Expensify Issue URL:

Issue reported by: @kerupuksambel

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684468035059069

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~0170002ec496e4cb5d
  • Upwork Job ID: 1661664481181433856
  • Last Price Increase: 2023-06-08
@kbecciv kbecciv added Daily KSv2 Bug Something is broken. Auto assigns a BugZero manager. labels May 24, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 24, 2023

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot
Copy link

melvin-bot bot commented May 24, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@conorpendergrast
Copy link
Contributor

Nice, all reproduced

image

@conorpendergrast conorpendergrast added the External Added to denote the issue can be worked on by a contributor label May 25, 2023
@melvin-bot melvin-bot bot changed the title Chat - "Report no longer exists" message upon removing image that has deleted thread [$1000] Chat - "Report no longer exists" message upon removing image that has deleted thread May 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 25, 2023

Job added to Upwork: https://www.upwork.com/jobs/~0170002ec496e4cb5d

@melvin-bot
Copy link

melvin-bot bot commented May 25, 2023

Current assignee @conorpendergrast is eligible for the External assigner, not assigning anyone new.

@melvin-bot
Copy link

melvin-bot bot commented May 25, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label May 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented May 25, 2023

Triggered auto assignment to @cristipaval (External), see https://stackoverflow.com/c/expensify/questions/7972 for more details.

@conorpendergrast
Copy link
Contributor

Reproduced on Staging and Production, by the way

@aidear3
Copy link

aidear3 commented May 25, 2023

I think rendering doesn't seem to work reliably.
Leave this problem to me and I will fix it.

@melvin-bot
Copy link

melvin-bot bot commented May 25, 2023

📣 @JavSFDev! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

  1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
  2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
  3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
    Screen Shot 2022-11-16 at 4 42 54 PM
    Format:
Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

@DanutGavrus
Copy link
Contributor

Proposal

Please re-state the problem that we are trying to solve in this issue.

Empty image returned with the error "Report no longer exists" after deletion.

What is the root cause of that problem?

After creating & leaving the thread, then deleting the attachment

the back-end responds with:

So, we update Onyx with the failure data.

  • We still see the message after refreshing the page.
  • We don't see the message after deleting the data in the Onyx database, and then refresh the page.

It looks like even though the back-end responds with this data, the attachment is actually deleted, so after deleting the data in the local database & refreshing the page, the message dissapears.

What changes do you think we should make in order to solve the problem?

Have someone from back-end investigate step by step the call for this case in order to see where the problem occurs.

@melvin-bot melvin-bot bot added the Overdue label May 29, 2023
@cristipaval
Copy link
Contributor

I think this issue might have the same root cause as this one. Maybe we could put it on hold and test it again when the other one gets fixed? What do you think @mananjadhav ?

@melvin-bot melvin-bot bot removed the Overdue label May 29, 2023
@mananjadhav
Copy link
Collaborator

Yeah I agree, we should put this one on Hold.

@conorpendergrast conorpendergrast changed the title [$1000] Chat - "Report no longer exists" message upon removing image that has deleted thread HOLD for #19078 [$1000] Chat - "Report no longer exists" message upon removing image that has deleted thread May 30, 2023
@conorpendergrast
Copy link
Contributor

On hold for #19078!

@Christinadobrzyn
Copy link
Contributor

Similar issue reported here - #19707 - do you think we could combine these into one job? cc @mananjadhav @cristipaval

@cristipaval
Copy link
Contributor

The issues are different, but they might have the same root cause. My recommendation is to also put yours on hold for this one. What do you @mananjadhav think?

@melvin-bot
Copy link

melvin-bot bot commented Jun 1, 2023

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

@melvin-bot melvin-bot bot added the Overdue label Jun 1, 2023
@cristipaval cristipaval added the Awaiting Payment Auto-added when associated PR is deployed to production label Oct 3, 2023
@cristipaval cristipaval changed the title [$1000] Chat - "Report no longer exists" message upon removing image that has deleted thread [HOLD for payment][$1000] Chat - "Report no longer exists" message upon removing image that has deleted thread Oct 4, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 6, 2023
@cristipaval
Copy link
Contributor

friendly bump, @anmurali

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 6, 2023
@cristipaval
Copy link
Contributor

👀

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Overdue Daily KSv2 labels Oct 9, 2023
@cristipaval
Copy link
Contributor

I'll ping @anmurali internally. She was ooo last Friday that's why I think this one got delayed.

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 20, 2023

@anmurali, @cristipaval Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Oct 23, 2023
@cristipaval cristipaval added Bug Something is broken. Auto assigns a BugZero manager. and removed Bug Something is broken. Auto assigns a BugZero manager. labels Oct 23, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2023

Triggered auto assignment to @conorpendergrast (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot removed the Overdue label Oct 23, 2023
@melvin-bot

This comment was marked as outdated.

@cristipaval
Copy link
Contributor

@conorpendergrast, could you please handle the payment here? 🙏 I discussed with @anmurali on NewDot and she is swamped these days.

@cristipaval
Copy link
Contributor

The Web-E PR is in production now, so this should be closed after we pay the reporting bonus to @kerupuksambel. It's the old amount, 250$, @anmurali.

This is the only payment due here, @conorpendergrast.

@conorpendergrast
Copy link
Contributor

Absolutely!

@conorpendergrast
Copy link
Contributor

Paid and contract ended. Good to close @cristipaval ?

@cristipaval
Copy link
Contributor

Paid and contract ended. Good to close @cristipaval ?

Thanks! Let's close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

10 participants