[HOLD for payment][$2000] "report no longer exists" message appears when try to edit message

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. go to any chat
2. send any message
3. Hover over your sent message and click "Reply in Thread"
4. Go to thread
5. Click your profile icon in the new chat thread > click "Leave thread"
6. Find previous chat
7. Hover over the last sent message and click the edit pencil
8. Type an edit to your previously sent message > enter
9. Get a "Report no longer exists" error

Expected Result:

user should be able to edit the message

Actual Result:

report no longer exists message appears when try to edit message

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.19-2
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-05-24.at.7.25.07.PM.mov

Recording.779.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1684936594996169

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01d37108580b2e2ecb
• Upwork Job ID: 1692659620193611776
• Last Price Increase: 2023-09-07

[melvin-bot]

Triggered auto assignment to @Christinadobrzyn (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[c3024]

Proposal

User is not able to edit message. Presently, on clicking the tick nothing happens.

What is the root cause of the problem?

Here at line 936, parser.getRemovedMarkdownLinks is called.

App/src/libs/actions/Report.js

Lines 934 to 937 in 9671004

	const markdownOriginalComment = parser.htmlToMarkdown(originalHtml).trim();
	const htmlForNewComment = parser.replace(newCommentText);
	const removedLinks = parser.getRemovedMarkdownLinks(markdownOriginalComment, newCommentText);
	return removeLinksFromHtml(htmlForNewComment, removedLinks);

It comes from

https://github.com/Expensify/expensify-common/blob/68abe48ad71a98604fdbf5e8e960023ed5807ec2/lib/ExpensiMark.js#L10-L11

and none of the functions were bind here so the functions are unrecognized.

What changes do you think we should make in order to solve the problem?

For each function in this ExpensiMark, add
this.function = this.function.bind(this);

What alternative solutions did you explore? (Optional)

None.

[Christinadobrzyn]

I can reproduce this but I think it might be the same fix as this - #19559 (comment) asking

[c3024]

What does Leave Thread do exactly? Is it same as clicking on Conceirge chat with the thread continuing to exist or does it mean deleting the thread altogether?

[Christinadobrzyn]

Great questions - @c3024!

What does Leave Thread do exactly?

My understanding is it allows a user to 'unsubscribe' from a chat thread (generally a group thread) where they no longer need to participate. V2 should have a mute option

Is it same as clicking on Conceirge chat with the thread continuing to exist or does it mean deleting the thread altogether?

So the thread will exist, you just can choose to exit it to no longer be part of it

cc @stitesExpensify - just in case I'm wrong

I've added a Hold label as we'll wait to see if this root issue is similar to #19559 (comment)

[Christinadobrzyn]

Still on hold

[Christinadobrzyn]

Still on hold for - #19559 (comment)

[Christinadobrzyn]

Still on hold for - #19559 (comment)

[Christinadobrzyn]

Still on hold for - #19559 (comment)

[Christinadobrzyn]

hold for - #19559 (comment)

[Christinadobrzyn]

I'm going to be ooo until July 31st so going to unassign and assign a new teammate.

At this time, we're on hold for #19559 (comment)

I'll take this back if it's still on hold when I return

[tylerkaraszewski]

The auth PR above is waiting on updates based on @chiragsalian's review feedback. The Web-E PR is waiting on the auth PR.

[mvtglobally]

Issue not reproducible during KI retests. (First week)

[Christinadobrzyn]

keeping a watch on KI retests!

[cristipaval]

Issue not reproducible during KI retests. (First week)

Interesting.
A fix was merged and will hit staging with the next Web-E deployment.

[melvin-bot]

@tylerkaraszewski, @Christinadobrzyn, @aimane-chnaif Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[Christinadobrzyn]

If this is not reproducible in KI retests, I'm assuming we'll still pay this out? @cristipaval

If payment is happening that looks like it will be

Payouts due:

Issue Reporter: $250 @gadhiyamanan (paid in upwork)
Contributor: NA
Contributor+: NA

Eligible for 50% #urgency bonus? N - since it's internal

Upwork job https://www.upwork.com/jobs/~01ea964ec786dd78e1

[cristipaval]

@Christinadobrzyn The fix is now in production, and this issue can be closed after the payments. The fix was implemented completely internally in Auth and Web-E. No C+ did a code review. We're paying the reporting bonus only in the other issue with the same root cause.

[Christinadobrzyn]

Thanks @cristipaval it looks like this reporter is different from the one in #19559

So I could add this reporter to that other issue to ensure they are paid, or I could just pay them here. I think it might be better to combine the reporter payments into one GH.

If that's the case then there would be no payments issued through this Upwork job. What do you think?

[cristipaval]

Thanks @cristipaval it looks like this reporter is different from the one in #19559

So I could add this reporter to that other issue to ensure they are paid, or I could just pay them here. I think it might be better to combine the reporter payments into one GH.

If that's the case then there would be no payments issued through this Upwork job. What do you think?

I don't know how the payment process works. You can pay them the easier it is for you.

[mvtglobally]

Issue not reproducible during KI retests. (Second week)

[Christinadobrzyn]

I'm going to pay @gadhiyamanan for reporting this in this GH.

@gadhiyamanan can you accept my job here - https://www.upwork.com/jobs/~01ea964ec786dd78e1

[gadhiyamanan]

@Christinadobrzyn offer accepted, thanks

[melvin-bot]

@tylerkaraszewski, @cristipaval, @Christinadobrzyn, @aimane-chnaif Whoops! This issue is 2 days overdue. Let's get this updated quick!

[cristipaval]

What's the payment status here? Can we close the issue?

[Christinadobrzyn]

Sorry for the delay- paid out based on #19707 (comment)