Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payments - Error message is missing after setting the only bank account as default #20565

Closed
5 of 6 tasks
kbecciv opened this issue Jun 10, 2023 · 6 comments
Closed
5 of 6 tasks
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Jun 10, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Issue found when executing PR #20246

Action Performed:

  1. Log in to the account without the beta wallet
  2. Go to Settings > Preferences > enable Use Staging Server
  3. Add a new bank account:
  • Wells Fargo
  • Username: user_good
  • password: pass_good
  • Mobile verification code: credential_good
  • Plaid saving
  1. Go to Settings > Payments
  2. Click your bank account and then click Make default payment method

Expected Result:

Error message should be shown

Actual Result:

Error message is not shown

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.26.1

Reproducible in staging?: Yes

Reproducible in production?: N/A

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6087872_video_20__1_.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jun 10, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jun 10, 2023

Triggered auto assignment to @marcochavezf (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@kbecciv
Copy link
Author

kbecciv commented Jun 10, 2023

QA team is unable to verify this issue in production.

@marcochavezf
Copy link
Contributor

Working on it, I tested locally with a gmail account (without the beta wallet), and the server responded with 200 (no error).

@melvin-bot melvin-bot bot removed the Overdue label Jun 12, 2023
@marcochavezf
Copy link
Contributor

Removing the label since if you only have one payment method, it should be set to default automatically. So we shouldn't show the "Make default payment method" in this case. More details here.

@marcochavezf marcochavezf removed the DeployBlockerCash This issue or pull request should block deployment label Jun 12, 2023
@marcochavezf
Copy link
Contributor

Closing this one in favor of this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants