Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If there's only one payment method, it should be set to default automatically #20629

Closed
6 tasks done
marcochavezf opened this issue Jun 12, 2023 · 38 comments
Closed
6 tasks done

If there's only one payment method, it should be set to default automatically #20629

marcochavezf opened this issue Jun 12, 2023 · 38 comments
Assignees
@marcochavezf @allroundexperts
Labels
Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Monthly KSv2

Comments

@marcochavezf
Copy link
Contributor

marcochavezf commented Jun 12, 2023 •
edited by melvin-bot bot
Loading

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

Coming from this issue and this convo, if there's only one payment method, it should be set to default automatically. Thus we shouldn't show the "Make default payment method" option for that case.

Action Performed:

  1. Log in to the account without the beta wallet
  2. Go to Settings > Preferences > enable Use Staging Server
  3. Add a new bank account:
  • Wells Fargo
  • Username: user_good
  • password: pass_good
  • Mobile verification code: credential_good
  • Plaid saving
  1. Go to Settings > Payments
  2. Click your bank account

Expected Result:

It should show only the "Delete" option.

Actual Result:

It shows the "Make default payment method" option.

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number:
Reproducible in staging?:
Reproducible in production?:
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Expensify/Expensify Issue URL:
Issue reported by:
Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011e6fba2ba1167bb8
  • Upwork Job ID: 1668390335163146240
  • Last Price Increase: 2023-06-12
@marcochavezf marcochavezf added Daily KSv2 Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff labels Jun 12, 2023
@marcochavezf marcochavezf self-assigned this Jun 12, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 12, 2023

Job added to Upwork: https://www.upwork.com/jobs/~011e6fba2ba1167bb8

@melvin-bot
Copy link

melvin-bot bot commented Jun 12, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @allroundexperts (Internal)

@marcochavezf marcochavezf mentioned this issue Jun 12, 2023
Closed
6 tasks
@allroundexperts
Copy link
Contributor

@marcochavezf Is there anything to review here?

@marcochavezf
Copy link
Contributor Author

Hi @allroundexperts, not yet

@melvin-bot melvin-bot bot added the Overdue label Jun 16, 2023
@marcochavezf
Copy link
Contributor Author

Not overdue

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 19, 2023
@marcochavezf
Copy link
Contributor Author

Not overdue

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jun 27, 2023

@marcochavezf, @allroundexperts Eep! 4 days overdue now. Issues have feelings too...

@marcochavezf
Copy link
Contributor Author

No update

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jun 27, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 3, 2023

@marcochavezf, @allroundexperts Eep! 4 days overdue now. Issues have feelings too...

@marcochavezf
Copy link
Contributor Author

No update

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 4, 2023
@marcochavezf
Copy link
Contributor Author

No update

@melvin-bot melvin-bot bot added Overdue and removed Overdue labels Jul 7, 2023
@marcochavezf
Copy link
Contributor Author

No update

@melvin-bot melvin-bot bot removed the Overdue label Jul 10, 2023
@melvin-bot melvin-bot bot added the Overdue label Oct 30, 2023
@marcochavezf
Copy link
Contributor Author

No update

@melvin-bot melvin-bot bot removed the Overdue label Oct 30, 2023
@melvin-bot melvin-bot bot added the Overdue label Nov 8, 2023
@marcochavezf
Copy link
Contributor Author

No update

@melvin-bot melvin-bot bot removed the Overdue label Nov 8, 2023
@marcochavezf marcochavezf added Monthly KSv2 and removed Weekly KSv2 labels Nov 8, 2023
@melvin-bot melvin-bot bot added the Overdue label Dec 11, 2023
@marcochavezf
Copy link
Contributor Author

No update

@melvin-bot melvin-bot bot removed the Overdue label Dec 11, 2023
@melvin-bot melvin-bot bot added the Overdue label Jan 12, 2024
@marcochavezf
Copy link
Contributor Author

No update

@melvin-bot melvin-bot bot removed the Overdue label Jan 12, 2024
@melvin-bot melvin-bot bot added the Overdue label Feb 13, 2024
@marcochavezf
Copy link
Contributor Author

No update

@melvin-bot melvin-bot bot removed the Overdue label Feb 13, 2024
@melvin-bot melvin-bot bot added the Overdue label Mar 15, 2024
@marcochavezf
Copy link
Contributor Author

No update

@melvin-bot melvin-bot bot removed the Overdue label Mar 15, 2024
@melvin-bot melvin-bot bot added the Overdue label Apr 16, 2024
@marcochavezf
Copy link
Contributor Author

No update, focused on higher priority issues

@melvin-bot melvin-bot bot removed the Overdue label Apr 17, 2024
@melvin-bot melvin-bot bot added the Overdue label May 20, 2024
@marcochavezf
Copy link
Contributor Author

No update

@melvin-bot melvin-bot bot removed the Overdue label May 27, 2024
@melvin-bot melvin-bot bot added the Overdue label Jun 28, 2024
@marcochavezf
Copy link
Contributor Author

I am closing this one for now to focus on bugs/issues with higher priority

@melvin-bot melvin-bot bot removed the Overdue label Jun 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcochavezf marcochavezf

@allroundexperts allroundexperts

Labels
Improvement Item broken or needs improvement. Internal Requires API changes or must be handled by Expensify staff Monthly KSv2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcochavezf @allroundexperts