[HOLD for payment 2023-06-28] [$1000] Inconsistent behavior when copying mentions with different methods

[kavimuru]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Post a comment with text and a mention
2. Select the posted comment and press CTRL + C to copy it
3. Paste the copied content elsewhere
4. Hover over the posted comment on step 1 and click on copy to clipboard icon
5. Paste the content elsewhere
6. Post a mention comment only and select the posted comment and use ctrl + c to copy the content
7. Compare the contents copied with the above different copy methods

Expected Result:

All copy methods should result in the same copied content

Actual Result:

When copying a posted comment which has a text and a mention using selection and ctrl + c copy method the content being copied is different from the other methods. The copied content appends this ""

Workaround:

Can the user still use Expensify without this being fixed? Have you informed them of the workaround?

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.28-3
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

2023-06-15.11.43.07.mp4

Recording.976.mp4

Expensify/Expensify Issue URL:
Issue reported by: @Nathan-Mulugeta
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1686818464264869

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~014a3e659d43c036c7
• Upwork Job ID: 1669428313148706816
• Last Price Increase: 2023-06-15

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @Julesssss (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[Julesssss]

While this does seem to be a regression, I really don't think it's bad enough to block the already very long deploy. I looked through the checklist, but nothing stood out as an obvious cause.

[dan1d]

Proposal

Please re-state the problem that we are trying to solve in this issue.

When copying a posted comment which has a text and a mention using selection and ctrl + c copy method the content being copied is different from the other methods. The copied content appends this hola [@[email protected]](details?login=danielfromarg%40gmail.com)

What is the root cause of that problem?

this is the root cause:

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Line 173 in f15e6dc

const content = selection || messageHtml;

when selecting text the content its mixed between html and markdown

When selecting the text content gets set as html

When you don't select anything and copy to clipboard you'll see that content gets set as markdown style:

What changes do you think we should make in order to solve the problem?

we need to parse the html here:

App/src/pages/home/report/ContextMenu/ContextMenuActions.js

Line 177 in f15e6dc

Clipboard.setString(parser.htmlToMarkdown(content));

in a way that parser.htmlToMarkdown(content) returns the same output regardless of markdown or html

Currently the output from parser.htmlToMarkdown(content) when selecting content to copy is:
hola [@[email protected]](details?login=danielfromarg%40gmail.com)
and the output of parser.htmlToMarkdown(content) when just clicking on copy to clipboard is:
hola @[email protected]

What alternative solutions did you explore? (Optional)

No

[melvin-bot]

📣 @dan1d! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[dan1d]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~012f00923e496a3daf

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~014a3e659d43c036c7

[melvin-bot]

Current assignee @isabelastisser is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @sobitneupane (External)

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.29-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix: Mention is selected as anchor tag #20894

If no regressions arise, payment will be issued on 2023-06-28. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@sobitneupane] The PR that introduced the bug has been identified. Link to the PR:
• [@sobitneupane] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@sobitneupane] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@sobitneupane] Determine if we should create a regression test for this bug.
• [@sobitneupane] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@isabelastisser] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[sobitneupane]

@sobitneupane, to confirm, are we waiting for proposals?

@isabelastisser Nope.

This is a regression from #20447 and fixed by #20894.

cc: @tienifr @eVoloshchak

[isabelastisser]

I will be OOO until July 5, so assigning another team member. SO for reference.

Bug zero member only needs to process the payment on June 28, thanks!

[melvin-bot]

Triggered auto assignment to @michaelhaxhiu (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[Julesssss]

Not overdue. We're waiting on payment

[Julesssss]

@michaelhaxhiu ready for payment

[michaelhaxhiu]

So, the payment owed is just the bug reporting bonus it seems? (for @Nathan-Mulugeta)

[michaelhaxhiu]

Invited Nathan to accept the job offer for bug reporting bonus.

[Nathan-Mulugeta]

Just accepted the offer @michaelhaxhiu

[michaelhaxhiu]

paid.