-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web - Workspace name missing after #announce or #admins #22647
Comments
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Triggered auto assignment to @bondydaa ( |
This is from #20512. The specific commit is |
This is intentional. I think we should update test rail so that QA team won't get confused. |
@0xmiroslav @grgia Pragmatically speaking, how is the user expected to know which workspace is which? My workspaces look like this now: I know that we, the contributors and testers, are not typical real users, but now I'm basically left with colors to distinguish my workspaces. And I'm colorblind. |
yup, after this refactor, all avatars are quite similar and hard to distinguish which one is which chat. |
cc: @shawnborton |
Keep in mind that most people will only have one workspace, and people can also upload a custom avatar. |
coolio sounds like this isn't a blocker and is expected then. Once #20512 goes to prod it'll post the comment about updating testing steps so let's make sure we get those updated. Going to close this out for now. |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
It should show workspace name after #announce or #admins to identify policy
Actual Result:
The workspace name missing after #announce or #admins
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.39-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen.Recording.2023-07-11.at.6.42.05.PM.mov
Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689081311895289
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: