Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web - Workspace name missing after #announce or #admins #22647

Closed
1 of 6 tasks
kbecciv opened this issue Jul 11, 2023 · 9 comments
Closed
1 of 6 tasks

Web - Workspace name missing after #announce or #admins #22647

kbecciv opened this issue Jul 11, 2023 · 9 comments
Assignees

Comments

@kbecciv
Copy link

kbecciv commented Jul 11, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Create a workspace if not created
  2. Check workspace name in LHN

Expected Result:

It should show workspace name after #announce or #admins to identify policy

Actual Result:

The workspace name missing after #announce or #admins

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.39-5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screenshot 2023-07-11 at 7 02 40 PM

Screen.Recording.2023-07-11.at.6.42.05.PM.mov

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1689081311895289

View all open jobs on GitHub

@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Jul 11, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Jul 11, 2023

Triggered auto assignment to @bondydaa (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@cubuspl42
Copy link
Contributor

This is from #20512. The specific commit is 6bc4f8c27c658fa4836b13d687a75182b93b11b6. The change looks intentional, but I cannot understand the reasoning.

@0xmiros
Copy link
Contributor

0xmiros commented Jul 11, 2023

This is intentional. I think we should update test rail so that QA team won't get confused.
cc: @grgia

@cubuspl42
Copy link
Contributor

@0xmiroslav @grgia Pragmatically speaking, how is the user expected to know which workspace is which?

My workspaces look like this now:

image

I know that we, the contributors and testers, are not typical real users, but now I'm basically left with colors to distinguish my workspaces.

And I'm colorblind.

@0xmiros
Copy link
Contributor

0xmiros commented Jul 11, 2023

yup, after this refactor, all avatars are quite similar and hard to distinguish which one is which chat.
In addition to color, tooltip is the only way to find which workspace, though still not possible on mobile.
I think team already planned to update.

@0xmiros
Copy link
Contributor

0xmiros commented Jul 11, 2023

cc: @shawnborton

@shawnborton
Copy link
Contributor

Keep in mind that most people will only have one workspace, and people can also upload a custom avatar.

@bondydaa
Copy link
Contributor

coolio sounds like this isn't a blocker and is expected then.

Once #20512 goes to prod it'll post the comment about updating testing steps so let's make sure we get those updated.

Going to close this out for now.

@bondydaa bondydaa removed the DeployBlockerCash This issue or pull request should block deployment label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants