Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Checklist: New Expensify 2023-07-13 #22783

Closed
53 tasks done
OSBotify opened this issue Jul 13, 2023 · 13 comments
Closed
53 tasks done

Deploy Checklist: New Expensify 2023-07-13 #22783

OSBotify opened this issue Jul 13, 2023 · 13 comments
Assignees
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash

Comments

@OSBotify
Copy link
Contributor

OSBotify commented Jul 13, 2023

Release Version: 1.3.40-5
Compare Changes: production...staging

This release contains changes from the following pull requests:

Deploy Blockers:

Deployer verifications:

  • I checked the App Timing Dashboard and verified this release does not cause a noticeable performance regression.
  • I checked Firebase Crashlytics and verified that this release does not introduce any new crashes. More detailed instructions on this verification can be found here.
  • I checked GitHub Status and verified there is no reported incident with Actions.

cc @Expensify/applauseleads

@mvtglobally mvtglobally added the 🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging label Jul 13, 2023
@francoisl francoisl self-assigned this Jul 13, 2023
@OSBotify
Copy link
Contributor Author

🚀 All staging deploys are complete, @Expensify/applauseleads please begin QA on version https://github.com/Expensify/App/releases/tag/1.3.40-0 🚀

@Julesssss
Copy link
Contributor

Cherry-picked #22801

@cristipaval
Copy link
Contributor

Checking off deploy blocker #22803

@mvtglobally
Copy link

#22651 is failing #22826

@francoisl
Copy link
Contributor

francoisl commented Jul 13, 2023

@francoisl
Copy link
Contributor

francoisl commented Jul 13, 2023

  • Fix for 22833 tested on staging, checking off
  • Checking 22801 off, QAed internally

@francoisl
Copy link
Contributor

  • Checking 21583 off, Maria did most platforms and I did Android

@francoisl
Copy link
Contributor

  • Checking 22862 off, it's likely not a bug and also happening on production

@francoisl
Copy link
Contributor

cc @Julesssss - discussed in Slack but re-posting here - everything is checked (except the GH status to check last minute) so feel free to close and ship once regression tests are finished. Thanks!

@Julesssss
Copy link
Contributor

Checklist is complete.

@mvtglobally
Copy link

Regression is completed

@Julesssss
Copy link
Contributor

Found a new issue in Firebase, but it's non-fatal and not worth blocking. Created an issue here

@Julesssss
Copy link
Contributor

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔐 LockCashDeploys 🔐 Prevent new code from being deployed to staging StagingDeployCash
Projects
None yet
Development

No branches or pull requests

6 participants