[HOLD Issue #309277][$1000] LHN - Chat that doesn't have a message does not disappears from the LHN

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

Scenario "empty DMs"

1. Go to https://staging.new.expensify.com/
2. Login with any account
3. Search for a user that you don't have any messages with and open the chat. Don't send any message
4. Navigate away from the conversation by clicking any other available conversation in the LHN list

Scenario "empty threads"

1. Go to https://staging.new.expensify.com/
2. Login with any account
3. Select any user
4. Select "Reply in Tread" option

Expected Result:

1. Conversation with no messages should disappear from LHN conversation list
2. Thread report is not displayed until the comment is posted

Actual Result:

1. Conversation that doesn't have any messages doesn't disappear from from LHN
2. Thread report is displayed when the comment is not posted

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.37.1

Reproducible in staging?: Yes

Reproducible in production?: Yes

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Scenario "empty DMs"

Bug6117623_Recording__322.mp4

Scenario "empty threads"

Recording.3738.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~013fc034f8ebadf86c
• Upwork Job ID: 1681415083049984000
• Last Price Increase: 2023-08-01

[melvin-bot]

Triggered auto assignment to @alexpensify (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[dukenv0307]

@alexpensify

One more thing, if the user creates a new room and doesn't send any message, could we should hide the room report in LHN? If not, we should add condition to check if this report is room or not?

As I mentioned in my proposal above, could you help to confirm? And then I can update my proposal as expected

[alexpensify]

I'll review soon and update.

[alexpensify]

This one is on my testing list for the week.

[kbecciv]

Hi @alexpensify We have Slack discussion about the opening "empty threads" and for starting "empty DMs" https://expensify.slack.com/archives/C049HHMV9SM/p1689466696046149, how would you like me to handle the opening "empty threads? Would you like me to create another GH ticket or combine? @quinthar would like to fully test that shared solution on both flows. Thank you in advance.

[alexpensify]

@kbecciv - let's add the additional flow to this GH. Please update the original GH to include the flow that David mentioned, Thanks!

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~013fc034f8ebadf86c

[melvin-bot]

Current assignee @alexpensify is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @rushatgabhane (External)

[alexpensify]

Adding the external label for now. @rushatgabhane - could you please review the proposal and identify if it will work to address both flows? Thanks!

[kbecciv]

@alexpensify I added two scenarios, please let me know if anything else I need to do. Thanks

[dukenv0307]

@alexpensify @kbecciv I have a bit curious. Could you help me to confirm?

1. Currently, When clicking reply in the thread, The App will redirect to the thread report, and the new report is created in LHN. But if the user clicks on another report, the thread report will disappear.
   We don't want to display the thread report in LHN when the user clicks on reply in the thread eventhough the report screen is on this thread chat, right?
   I want to confirm that because maybe it is intentional as mentioned here
   

   App/src/libs/ReportUtils.js

   Lines 2098 to 2103 in 2d2008a

   	// Include the currently viewed report. If we excluded the currently viewed report, then there
   	// would be no way to highlight it in the options list and it would be confusing to users because they lose
   	// a sense of context.
   	if (report.reportID === currentReportId) {
   	return true;
   	}

2. If the user creates a new room and doesn't send any message, could we should hide the room report in LHN?

[alexpensify]

@quinthar - you were part of the Slack thread that mentioned the other flow. Can you share more feedback for @dukenv0307's questions? Thanks!

[alexpensify]

I'll start a discussion tomorrow to confirm the flows.

[alexpensify]

I started a discussion here: https://expensify.slack.com/archives/C049HHMV9SM/p1690236131313079?thread_ts=1689466696.046149&cid=C049HHMV9SM

[quinthar]

Hi there, great questions. First, I'd like to expand the problem description. The problem consists of two parts:

Problem 1

When you create a DM/thread, it is shared with the other party immediately, before you even type. It appears as unread on their LHN, which reveals that you are thinking about writing something to them, but haven't yet. This is a confusing privacy violation.

Problem 2

When you a DM/thread, if you choose not to post anything, you and the party still see it in your LHNs forever.

Solution

Do not notify the server of the new DM/thread until after the user has actually posted the first message. If they do not post a message, then the server should never know that you even considered it.

[alexpensify]

@dukenv0307 are there other questions or are you good to prepare your updated proposal that includes both flows?

[dukenv0307]

@quinthar Thanks for your clarification.

If the user creates a new room without a message, could we hide the room report in LHN?

Could you also help to confirm this point?

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[alexpensify]

Weekly Update: On Hold

[cristipaval]

As far as I saw lately, this is not reproducible anymore and the empty chats are hidden from the LHN.

[cristipaval]

@alexpensify could you confirm and close the issue?

[alexpensify]

I'm catching up from being OOO, I will test tomorrow.

[alexpensify]

Still on my testing list

[alexpensify]

Yeah, I confirmed too, and will close this GH.

[dukenv0307]

@alexpensify I think contributors should be eligible for compensation in this issue. The solution provided was valid at the time, contributors assigned and the process of reviewing the pull request had already begun. However, due to subsequent changes, the solution became outdated.

There were many precedents to this like here and here.

Thanks!

cc @rushatgabhane @cristipaval

[alexpensify]

@dukenv0307 - I'll review the feedback and follow up later this week.

[alexpensify]

Still on my review list

[alexpensify]

Thanks for your patience here. Since the examples shared here, there have been a few updates to the partial payment process. I need to ask a few questions and would like your opinions:

1. What compensation do you think is the percent due here for the work input here - 0, 25, 50, OR 100%?
2. Reasoning why has been shared here.

@dukenv0307 and @rushatgabhane - please reply, Thanks!

[dukenv0307]

@alexpensify Thanks for looking into this!

According to the precedents mentioned here and many others, the payout should be 100%. The work is almost complete here but unfortunately it's outdated due to changes outside of our control.

[alexpensify]

Thanks for sharing @dukenv0307!

@rushatgabhane - can you share some feedback or if you agree? Thanks!

[rushatgabhane]

@alexpensify I'm gonna ask this in C+ channel

https://expensify.slack.com/archives/C02NK2DQWUX/p1695651864238459

[Christinadobrzyn]

Also reached out to BZ about payment - https://expensify.slack.com/archives/C01SKUP7QR0/p1695743819720659

[alexpensify]

@rushatgabhane I should have included this before but there is a process for partial payments. The summary is:

Ask the C+ or contributor what compensation they think they’re due and ask them to provide reasoning why. Also ask them to present their compensation request as a percent of the job price where standard payments are 0, 25, 50 and 100%.

From there, I will review and plan accordingly. I'd still appreciate if you shared a percent here. Thanks!

[alexpensify]

Not overdue, waiting for feedback. @rushatgabhane when you get a chance can you share the percentage number? Thanks!

[cristipaval]

Just sharing my thoughts here:

• The C+ did review the proposals and jumped into the conversation, but there was no real code review or testing. 25% should be fine for them.
• The assigned contributor spent some time on the accepted solution and encountered some challenges. They raised them here, and there was some back and forth. Paying 100% is fair in this case.

[alexpensify]

Thanks, I will start this payment breakdown.

[alexpensify]

Here is the payment summary:

• External issue reporter N/A
• Contributor that fixed the issue @dukenv0307 $1000
• Contributor+ that helped on the issue and/or PR @rushatgabhane $250

Upwork Job: https://www.upwork.com/jobs/~01b0decd73ba4f11c0

*If applicable, the bonuses will be applied on the final payment

Extra Notes regarding payment: This payment breakdown has been in discussion but here is the summary #22806 (comment)

[alexpensify]

@dukenv0307 - I've sent a proposal via Upwork. Please accept and I can complete the process, thanks!

[dukenv0307]

@dukenv0307 - I've sent a proposal via Upwork. Please accept and I can complete the process, thanks!

@alexpensify accepted, thank you!

[JmillsExpensify]

$250 payment approved for @rushatgabhane based on BZ summary.

[alexpensify]

Everyone has been paid! I've completed the process in Upwork for @dukenv0307.