-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-10-09] [ECard Settings] - Create the Expensify card page #22873
Comments
Job added to Upwork: https://www.upwork.com/jobs/~016ad3175064113565 |
Triggered auto assignment to Contributor Plus for review of internal employee PR - @narefyev91 ( |
This one also could be built in isolation for now. Sure, there is no way to navigate to this page in product yet until the issue on HOLD is complete. But we can create the page as a standalone and test it by direct navigation + some mock data. |
@pasyukevich mind commenting here so we can assign this to you? |
Hi! |
@narefyev91 Whoops! This issue is 2 days overdue. Let's get this updated quick! |
@narefyev91 Checking in to see if you'll be able to review this today? |
Hey @joekaufmanexpensify! Absolutely - will be done today 100%. But seems PR is not fully ready - no done checklist from contributor - will be checking during the day |
TY! |
The PR is available here - #26915 |
@pac-guerreiro can you please finish steps to make PR ready - fill the whole checklist - also i see some comments were not addressed - can you please react on them somehow |
@joekaufmanexpensify please take a look on PR - i left comment with next steps! Thanks! |
Thanks! I see the fix is up already. @narefyev91 should be ready for another review now! |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-09. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
@pasyukevich, @narefyev91, @grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
@pasyukevich, @narefyev91, @grgia Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it! |
not overdue, @joekaufmanexpensify could you help with $500 C+ review payment to @narefyev91 |
I believe Nicolay is with CallStack, so all of their payment is handled separately. But LMK if that's not correct @narefyev91 ! |
That's correct - thank you :-) |
Great, closing this out in that case |
HOLD ON #22872
Design Doc Section
https://docs.google.com/document/d/1rFxJ78vz5On6zSWzYa51B9v-tyLdC5pUsBeLOLig0t4/edit#bookmark=id.vqu4l2y6dj9k
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: