Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-09] [ECard Settings] - Create the Expensify card page #22873

Closed
grgia opened this issue Jul 14, 2023 · 22 comments
Closed
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff

Comments

@grgia
Copy link
Contributor

grgia commented Jul 14, 2023

HOLD ON #22872

Design Doc Section

https://docs.google.com/document/d/1rFxJ78vz5On6zSWzYa51B9v-tyLdC5pUsBeLOLig0t4/edit#bookmark=id.vqu4l2y6dj9k

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~016ad3175064113565
  • Upwork Job ID: 1679790242871123968
  • Last Price Increase: 2023-07-14
@grgia grgia added the Internal Requires API changes or must be handled by Expensify staff label Jul 14, 2023
@melvin-bot
Copy link

melvin-bot bot commented Jul 14, 2023

Job added to Upwork: https://www.upwork.com/jobs/~016ad3175064113565

@melvin-bot
Copy link

melvin-bot bot commented Jul 14, 2023

Triggered auto assignment to Contributor Plus for review of internal employee PR - @narefyev91 (Internal)

@grgia
Copy link
Contributor Author

grgia commented Aug 31, 2023

cc @pac-guerreiro

@melvin-bot melvin-bot bot added the Overdue label Aug 31, 2023
@marcaaron
Copy link
Contributor

This one also could be built in isolation for now. Sure, there is no way to navigate to this page in product yet until the issue on HOLD is complete. But we can create the page as a standalone and test it by direct navigation + some mock data.

@marcaaron marcaaron changed the title [HOLD #22872][ECard Settings] - Create the Expensify card page [ECard Settings] - Create the Expensify card page Aug 31, 2023
@marcaaron marcaaron added Daily KSv2 and removed Monthly KSv2 labels Aug 31, 2023
@melvin-bot melvin-bot bot removed the Overdue label Aug 31, 2023
@joekaufmanexpensify
Copy link
Contributor

@pasyukevich mind commenting here so we can assign this to you?

@pasyukevich
Copy link
Contributor

pasyukevich commented Sep 4, 2023

Hi!
I'm Eugene from Callstack, an expert contributor group.
I'd like to work on this.

@melvin-bot melvin-bot bot added the Overdue label Sep 4, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 4, 2023

@narefyev91 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot melvin-bot bot added Reviewing Has a PR in review Weekly KSv2 and removed Overdue Daily KSv2 labels Sep 11, 2023
@joekaufmanexpensify
Copy link
Contributor

@narefyev91 Checking in to see if you'll be able to review this today?

@narefyev91
Copy link
Contributor

narefyev91 commented Sep 12, 2023

@narefyev91 Checking in to see if you'll be able to review this today?

Hey @joekaufmanexpensify! Absolutely - will be done today 100%. But seems PR is not fully ready - no done checklist from contributor - will be checking during the day

@joekaufmanexpensify
Copy link
Contributor

TY!

@pac-guerreiro
Copy link
Contributor

The PR is available here - #26915

@narefyev91
Copy link
Contributor

@pac-guerreiro can you please finish steps to make PR ready - fill the whole checklist - also i see some comments were not addressed - can you please react on them somehow

@narefyev91
Copy link
Contributor

@joekaufmanexpensify please take a look on PR - i left comment with next steps! Thanks!

@joekaufmanexpensify
Copy link
Contributor

Thanks! I see the fix is up already. @narefyev91 should be ready for another review now!

@grgia grgia self-assigned this Sep 27, 2023
@melvin-bot melvin-bot bot added Weekly KSv2 Awaiting Payment Auto-added when associated PR is deployed to production and removed Weekly KSv2 labels Oct 2, 2023
@melvin-bot melvin-bot bot changed the title [ECard Settings] - Create the Expensify card page [HOLD for payment 2023-10-09] [ECard Settings] - Create the Expensify card page Oct 2, 2023
@melvin-bot melvin-bot bot removed the Reviewing Has a PR in review label Oct 2, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

Reviewing label has been removed, please complete the "BugZero Checklist".

@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-09. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 Daily KSv2 labels Oct 9, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 13, 2023

@pasyukevich, @narefyev91, @grgia Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

@melvin-bot
Copy link

melvin-bot bot commented Oct 18, 2023

@pasyukevich, @narefyev91, @grgia Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

@grgia
Copy link
Contributor Author

grgia commented Oct 18, 2023

not overdue, @joekaufmanexpensify could you help with $500 C+ review payment to @narefyev91

@melvin-bot melvin-bot bot removed the Overdue label Oct 18, 2023
@joekaufmanexpensify
Copy link
Contributor

I believe Nicolay is with CallStack, so all of their payment is handled separately. But LMK if that's not correct @narefyev91 !

@narefyev91
Copy link
Contributor

I believe Nicolay is with CallStack, so all of their payment is handled separately. But LMK if that's not correct @narefyev91 !

That's correct - thank you :-)

@melvin-bot melvin-bot bot added the Overdue label Oct 23, 2023
@grgia
Copy link
Contributor Author

grgia commented Oct 24, 2023

Great, closing this out in that case

@grgia grgia closed this as completed Oct 24, 2023
@melvin-bot melvin-bot bot removed the Overdue label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Daily KSv2 Internal Requires API changes or must be handled by Expensify staff
Projects
None yet
Development

No branches or pull requests

6 participants