Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Comment Linking! #23229

Closed
roryabraham opened this issue Jul 20, 2023 · 22 comments
Closed

Implement Comment Linking! #23229

roryabraham opened this issue Jul 20, 2023 · 22 comments
Assignees

Comments

@roryabraham
Copy link
Contributor

HOLD on #23223

Part of the Comment Linking project

Main issue: #20282
Doc section: https://docs.google.com/document/d/1v-ZaIRTZL5LIsyPWB0IopBNNgCajf5WC1OA8cVKtd8I/edit#bookmark=id.izionaowheco
Project: Comment Linking

Feature Description

In this issue, we should:

  • Configure deeplinking on a per-reportAction level
  • Create a function that will take already filtered by timestamp reportActions and filter them for gap detection using comparison by reportActionID and previousReportActionID.
  • Develop a function that accepts data and identifies where the gaps exist(from function described above). This function should carefully manage what part of the data should be passed to FlatList, ensuring seamless data management for bidirectional scrolling.
  • Positioning the linked message at the edge of the list, so it appears at the bottom of the screen.

Manual Test Steps

TBD

Automated Tests

TBD

@perunt
Copy link
Contributor

perunt commented Jul 20, 2023

Here we go! 🚀

@melvin-bot melvin-bot bot added Monthly KSv2 and removed Weekly KSv2 labels Aug 21, 2023
@melvin-bot
Copy link

melvin-bot bot commented Aug 21, 2023

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

perunt added a commit to margelo/expensify-app-fork that referenced this issue Oct 2, 2023
perunt added a commit to margelo/expensify-app-fork that referenced this issue Oct 4, 2023
perunt added a commit to margelo/expensify-app-fork that referenced this issue Oct 24, 2023
perunt added a commit to margelo/expensify-app-fork that referenced this issue Oct 25, 2023
@melvin-bot melvin-bot bot closed this as completed Nov 2, 2023
Copy link

melvin-bot bot commented Nov 2, 2023

@perunt, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@github-project-automation github-project-automation bot moved this from HOLD to Done in Comment Linking Nov 2, 2023
perunt added a commit to margelo/expensify-app-fork that referenced this issue Nov 3, 2023
perunt added a commit to margelo/expensify-app-fork that referenced this issue Nov 3, 2023
perunt added a commit to margelo/expensify-app-fork that referenced this issue Nov 7, 2023
perunt added a commit to margelo/expensify-app-fork that referenced this issue Nov 7, 2023
perunt added a commit to margelo/expensify-app-fork that referenced this issue Nov 7, 2023
@roryabraham roryabraham reopened this Nov 8, 2023
@melvin-bot melvin-bot bot added the Monthly KSv2 label Jan 18, 2024
Copy link

melvin-bot bot commented Jan 18, 2024

This issue has not been updated in over 15 days. @perunt eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

perunt added a commit to margelo/expensify-app-fork that referenced this issue Jan 19, 2024
perunt added a commit to margelo/expensify-app-fork that referenced this issue Jan 19, 2024
perunt added a commit to margelo/expensify-app-fork that referenced this issue Jan 25, 2024
perunt added a commit to margelo/expensify-app-fork that referenced this issue Jan 30, 2024
perunt added a commit to margelo/expensify-app-fork that referenced this issue Feb 2, 2024
perunt added a commit to margelo/expensify-app-fork that referenced this issue Feb 6, 2024
perunt added a commit to margelo/expensify-app-fork that referenced this issue Feb 7, 2024
perunt added a commit to margelo/expensify-app-fork that referenced this issue Feb 7, 2024
perunt added a commit to margelo/expensify-app-fork that referenced this issue Feb 12, 2024
perunt added a commit to margelo/expensify-app-fork that referenced this issue Feb 13, 2024
perunt added a commit to margelo/expensify-app-fork that referenced this issue Feb 13, 2024
perunt added a commit to margelo/expensify-app-fork that referenced this issue Feb 13, 2024
perunt added a commit to margelo/expensify-app-fork that referenced this issue Feb 13, 2024
perunt added a commit to margelo/expensify-app-fork that referenced this issue Feb 19, 2024
perunt added a commit to margelo/expensify-app-fork that referenced this issue Mar 1, 2024
perunt added a commit to margelo/expensify-app-fork that referenced this issue Mar 12, 2024
perunt added a commit to margelo/expensify-app-fork that referenced this issue Mar 12, 2024
perunt added a commit to margelo/expensify-app-fork that referenced this issue Mar 13, 2024
perunt added a commit to margelo/expensify-app-fork that referenced this issue Mar 19, 2024
perunt added a commit to margelo/expensify-app-fork that referenced this issue Mar 20, 2024
roryabraham added a commit that referenced this issue Mar 20, 2024
HIGH: (Comment linking: Step 4) Main "glue" PR for Comment Linking
@melvin-bot melvin-bot bot closed this as completed Apr 5, 2024
Copy link

melvin-bot bot commented Apr 5, 2024

@perunt, this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Comment Linking Apr 5, 2024
@roryabraham
Copy link
Contributor Author

this is done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants