[HOLD for #26498][$1000] Chat - It's not here" displayed when click on back bin after all request money was deleted

[lanitochka17]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

Precondition: user should be logged in

1. Open app
2. Tap on any 1:1 conversation with user
3. Make a two request money in a row
4. Tap on the requested money fiend in chat
5. Tap on the first requested money
6. Tap on 3 dots button > delete
7. Tap on back button
8. Tap on the remaining requested money
9. Tap on 3 dots button > delete
10. Tap on back button

Expected Result:

User should be navigated back to the DM

Actual Result:

Step 8: has navigated to the same page
Step 10: user has navigated to the "It's not here" page

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.53.1

Reproducible in staging?: Yes

Reproducible in production?: No

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

Bug6162479_screen-20230812-175610.mp4

Expensify/Expensify Issue URL:

Issue reported by: Applause - Internal Team

Slack conversation:

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01c14c4b05f0985c77
• Upwork Job ID: 1694085407589380096
• Last Price Increase: 2023-08-29

[OSBotify]

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[melvin-bot]

Triggered auto assignment to @grgia (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

[tymatein]

Proposal

Please re-state the problem that we are trying to solve in this issue.
When deleting the requested money, the navigation is set incorrectly.

What is the root cause of that problem?
The first problem with the duplicate screen is caused by redundant navigation to the report route with reportID.
The second problem with the error screen is caused by the omission of the second call to the goBack function. This leaves an invalid ID in the navigation stack.

What changes do you think we should make in order to solve the problem?
Make additional call of Navigation.goBack if needed and avoid useless navigation to avoid redundancy in the navigation stack.

diff --git a/src/libs/actions/IOU.js b/src/libs/actions/IOU.js
index 5660bc31a8..65357e22a8 100644
--- a/src/libs/actions/IOU.js
+++ b/src/libs/actions/IOU.js
@@ -965,14 +965,21 @@ function deleteMoneyRequest(transactionID, reportAction, isSingleTransactionView
     if (isSingleTransactionView && shouldDeleteTransactionThread && !shouldDeleteIOUReport) {
         // Pop the deleted report screen before navigating. This prevents navigating to the Concierge chat due to the missing report.
         Navigation.goBack();
-        Navigation.navigate(ROUTES.getReportRoute(iouReport.reportID));
+        if (!Navigation.isActiveRoute(ROUTES.getReportRoute(iouReport.reportID))) {
+            Navigation.navigate(ROUTES.getReportRoute(iouReport.reportID));
+        }
         return;
     }
 
     if (shouldDeleteIOUReport) {
         // Pop the deleted report screen before navigating. This prevents navigating to the Concierge chat due to the missing report.
         Navigation.goBack();
-        Navigation.navigate(ROUTES.getReportRoute(iouReport.chatReportID));
+        if (Navigation.isActiveRoute(ROUTES.getReportRoute(iouReport.reportID))) {
+            Navigation.goBack();
+        }
+        if (!Navigation.isActiveRoute(ROUTES.getReportRoute(iouReport.chatReportID))) {
+            Navigation.navigate(ROUTES.getReportRoute(iouReport.chatReportID));
+        }
     }
 }

What alternative solutions did you explore? (Optional)
No one.
Introduced by commit dc343dd. As that commit is revert of the PR 22787 it would be safer to just fix this issue than do revert.

Reminder: Please use plain English, be brief and avoid jargon. Feel free to use images, charts or pseudo-code if necessary. Do not post large multi-line diffs or write walls of text. Do not create PRs unless you have been hired for this job.

[luacmartins]

This is not a blocker. It's been the case since we introduced the feature.

[ShogunFire]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The navigation is wrong when we delete iou transaction

What is the root cause of that problem?

When we delete a transaction in single transaction view we navigate to the iou report and return but we should not return if the iou is also deleted because we need to navigate to the chat report

What changes do you think we should make in order to solve the problem?

When we delete a transaction from the transaction view we should remove the test on shouldDeleteIOUReport because we have to goBack in every cases, and we need to remove the return so that it goes back to the chat report if we delete the iou report.

if (isSingleTransactionView && shouldDeleteTransactionThread) {

    Navigation.goBack(ROUTES.getReportRoute(iouReport.reportID));

}
if (shouldDeleteIOUReport) {
    Navigation.goBack(ROUTES.getReportRoute(iouReport.chatReportID));
}

Note: we add the fallback route so that it also works when we deeplink but the goback with fallback route doesn't work at the moment for reports and this will only work when this PR got merged: #26498

[melvin-bot]

@grgia 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[grgia]

@luacmartins is this a bug or something that is going to be cleaned up internally? Or can I make this external

[luacmartins]

You can make this external

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01c14c4b05f0985c77

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @sophiepintoraetz (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mollfpr (External)

[adelekennedy]

on hold still

[adelekennedy]

still holding

[adelekennedy]

@mollfpr is this still on hold?

[mollfpr]

@adelekennedy Yes!

[adelekennedy]

deprioritizing for the hold

[adelekennedy]

I believe this is still on hold!

[adelekennedy]

@mollfpr it looks like the connected PR was deployed a bit ago - are we still on hold here?

[mollfpr]

I can't reproduce the issue on 1.4.14-0 Develop.

[adelekennedy]

hmm - I also can't reproduce @lanitochka17 will you see if you're still running into this?

[adelekennedy]

I still can't reproduce on IOS, closing