[HOLD for payment 2024-01-30] [HOLD for payment 2024-01-25] [$250] [TS migration] Migrate 'GetAssistance' page to TypeScript

[melvin-bot]

TypeScript migration

Make sure you read through our TypeScript's style guide, cheatsheet and PropTypes conversion table before you start working on this migration issue.

Files

Path	Dependencies
src/pages/GetAssistancePage.js	20

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01f1b78d822a1c7910
• Upwork Job ID: 1744724518595629056
• Last Price Increase: 2024-01-09
• Automatic offers:
• cubuspl42 | Reviewer | 28092355
• DylanDylann | Contributor | 28102317

Issue Owner

Current Issue Owner: @anmurali

[melvin-bot]

This issue has not been updated in over 15 days. eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[melvin-bot]

@melvin-bot[bot], this Monthly task hasn't been acted upon in 6 weeks; closing.

If you disagree, feel encouraged to reopen it -- but pick your least important issue to close instead.

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01f1b78d822a1c7910

[melvin-bot]

Triggered auto assignment to @anmurali (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @cubuspl42 (External)

[pecanoro]

@AnshuAgarwal24 I understand the decision must have been frustrating and I am sorry this wasn't the outcome you expected. I agree with you that by contributing, people improve their skills. However, there was a substantial gap in your TypeScript knowledge that was preventing you from completing the task and debugging basic errors that you encountered. We can always help with one-off problems but since this is a paid task, it doesn't sound reasonable to finish half of the job for you.

As we mentioned, we totally encourage you to apply again in the future once you have practiced more and gained some experience with Typescript. As a start, my advice would be to check how @DylanDylann has solved all the problems you encountered in the PR he created and even doing so with some of the other Typescript tasks that many other contributors have created, it is a great learning opportunity.

[DylanDylann]

@cubuspl42 The PR is ready for review, I will upload IOS video right after running successfully 😄

[cubuspl42]

@AnshuAgarwal24 We reached out to you in private, explaining our decision. We made extra effort to be respectful and clear. I'm sorry that that didn't work. Let me be extra clear.

If you found me incapable of solving the issue, you could have assigned it to someone else.

That's what we just did.

TypeScript migration is a special category of issues, not using the proposal system. Before assigning, we don't interview or background check Contributors, as that hasn't been needed so far. In this category, we depend on Contributors' honesty and ability to self-estimate their skills. You either weren't honest or highly over-estimated your skills.

I consider this thread closed for discussion.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.26-2 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [Migration]: migrate GetAssistancePage to typescript #34553

If no regressions arise, payment will be issued on 2024-01-25. 🎊

For reference, here are some details about the assignees on this issue:

• @cubuspl42 requires payment automatic offer (Reviewer)
• @DylanDylann requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@cubuspl42] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.29-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• [TS Migration]: fix type while migrating GetAssistancePage to typescript #34715

If no regressions arise, payment will be issued on 2024-01-30. 🎊

For reference, here are some details about the assignees on this issue:

• @cubuspl42 requires payment automatic offer (Reviewer)
• @DylanDylann requires payment automatic offer (Contributor)

[melvin-bot]

BugZero Checklist: The PR adding this new feature has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@cubuspl42] Please propose regression test steps to ensure the new feature will work correctly on production in further releases.
• [@anmurali] Link the GH issue for creating/updating the regression test once above steps have been agreed upon.

[pecanoro]

@anmurali Ready for payment

[anmurali]

@cubuspl42 abd @DylanDylann are both paid
@cubuspl42 @pecanoro does this need a regression test? If yes, please add the steps. If no, @pecanoro you can close the GH!

[pecanoro]

No, it does not need one, so closing