[HOLD for payment 2024-02-19] [HOLD for #19642][$1000] mWeb - Non-Responsive view in legal name screen

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to settings-> Click Profile
2. Click personal details -> Click legal name
3. Focus on any text field -> Swipe up to scroll

Expected Result:

This screen should be responsive

Actual Result:

Non-responsive view on Legal name screen

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.60.1
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Image.from.iOS.3.mov

RPReplay_Final1693491380.MP4

Expensify/Expensify Issue URL:
Issue reported by: @DinalJivani
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692911380405329

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~016ea2797105a3c164
• Upwork Job ID: 1701114239326281728
• Last Price Increase: 2023-11-27
• Automatic offers:
• fedirjh | Reviewer | 28119719
• suneox | Contributor | 28119720

[melvin-bot]

Triggered auto assignment to @adelekennedy (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[ishpaul777]

same issue is happening contact method verifucation I reported this a while ago i think should be added as reporter @kbecciv -
https://app.slack.com/client/T03SC9DTT/C049HHMV9SM/thread/C049HHMV9SM-1692911380.405329

[adelekennedy]

@ishpaul777 can you point to where you reported this? The link above redirects me to this issues thread.

[ishpaul777]

https://expensify.slack.com/archives/C049HHMV9SM/p1691507520738229

I reported the behaviour, it was not a well formatted bug report.

[adelekennedy]

ah - so it looks like you asked about the bug but were told not to report it because it may have been related to an upcoming PR. In that case I'm not sure that it would count as it was never a formal bug report, I'm asking internally about this

[ishpaul777]

@adelekennedy any update?

[adelekennedy]

Yeah - this won't count for the reporting bonus as it wasn't made into an actual issue

[ishpaul777]

Ok, thanks for clarification

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~016ea2797105a3c164

[melvin-bot]

Current assignee @adelekennedy is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @0xmiroslav (External)

[adelekennedy]

wow - missed making this external

[PiyushChandra17]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Legal Name screen is not responsive

What is the root cause of that problem?

In order for the screen to be responsive, media queries are required, there's no media queries set.

What changes do you think we should make in order to solve the problem?

Since the problem occurs in mWeb, we should add the following media queries here

@media screen and (max-width: 479px) { 
    .css-view-175oi2r {
        overflow: hidden;
    }
}

This style will override the original style and should fix the problem.

What alternative solutions did you explore? (Optional)

NA

Result:

Simulator.Screen.Recording.-.iPhone.13.-.2023-09-11.at.23.35.51.mp4

[adelekennedy]

@0xmiroslav to review

[0xmiros]

@PiyushChandra17 thanks for your proposal. The root cause is not correct.

[melvin-bot]

📣 @fedirjh 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

[melvin-bot]

📣 @suneox 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

[suneox]

Hi @fedirjh, the PR is ready to review

[DinalJivani]

Hello @fedirjh
I haven't received Upwork offer automatically. Please send me offer manually when you are around.
Thanks

[mallenexpensify]

@adelekennedy is the BugZero team member who will be managing.
@DinalJivani can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~0154c21d13eb0e8dfe

[DinalJivani]

@mallenexpensify cc: @adelekennedy
I haven’t received any upwork invite yet!

Did you meant “apply to the Upwork job you sent?”

[mallenexpensify]

Invited now @DinalJivani , can you please accept the job and reply here once you have?
https://www.upwork.com/jobs/~0154c21d13eb0e8dfe

Also.. for the bug report on 8/24, pay was $250 then.

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.4.39-8 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• 26401 avoid scroll on virtual viewport #35256

If no regressions arise, payment will be issued on 2024-02-19. 🎊

For reference, here are some details about the assignees on this issue:

• @suneox requires payment automatic offer (Contributor)
• @fedirjh requires payment automatic offer (Reviewer)
• @DinalJivani requires payment (Needs manual offer from BZ)

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@fedirjh] The PR that introduced the bug has been identified. Link to the PR:
• [@fedirjh] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@fedirjh] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@fedirjh] Determine if we should create a regression test for this bug.
• [@fedirjh] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@adelekennedy] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[suneox]

Hi @mallenexpensify have we miss payment on this issue?

[adelekennedy]

sorry all - was ooo yesterday, @fedirjh to close this out do we need a regression test for this one?

[fedirjh]

@adelekennedy This is not a critical bug, it only affects mobile safari, and it is just a minor design issue, no need for regression test.

[mallenexpensify]

Confirming @suneox has been paid

[suneox]

Confirming @suneox has been paid

@mallenexpensify Thank you I have received payment