Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

26401 avoid scroll on virtual viewport #35256

Merged

Conversation

suneox
Copy link
Contributor

@suneox suneox commented Jan 26, 2024

Details

Fixed Issues

$ #26401
PROPOSAL: #26401 (comment)

Tests

  1. Go to settings-> Click Profile
  2. Click personal details -> Click legal name
  3. Focus on any text field -> Swipe up to scroll
  4. Verify after scrolling to the bottom, the unexpected space is not display and the user can continue to scroll up
  • Verify that no errors appear in the JS console

Offline tests

QA Steps

  1. Go to settings-> Click Profile
  2. Click personal details -> Click legal name
  3. Focus on any text field -> Swipe up to scroll
  4. Verify after scrolling to the bottom, the unexpected space is not display and the user can continue to scroll up
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Screen.Recording.2024-01-27.at.00.14.39.mov
Android: mWeb Chrome
Screen.Recording.2024-01-27.at.00.13.30.mov
iOS: Native
Screen.Recording.2024-01-26.at.18.16.46.mov
iOS: mWeb Safari
Screen.Recording.2024-01-26.at.17.14.27.mov
MacOS: Chrome / Safari
Screen.Recording.2024-01-26.at.17.15.44.mov
MacOS: Desktop
Screen.Recording.2024-01-27.at.00.05.56.mov

@suneox suneox requested a review from a team as a code owner January 26, 2024 17:26
@melvin-bot melvin-bot bot requested review from fedirjh and removed request for a team January 26, 2024 17:26
Copy link

melvin-bot bot commented Jan 26, 2024

@fedirjh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@suneox
Copy link
Contributor Author

suneox commented Jan 29, 2024

Hi @fedirjh I have fix code lint, prettier, and this PR is ready to review

@fedirjh
Copy link
Contributor

fedirjh commented Jan 29, 2024

@suneox Sure, reviewing shortly.

Copy link
Contributor

@fedirjh fedirjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's fix this bug in other places too:

  • Profile display name
  • Add new contact method
  • Workspace settings -> name
  • Private notes: nagivate to report -> click on report header
  • Request money flow: there are several pages (waypoint selection, request flow, set merchant, description..)
  • Task Flow (create, task title edit, task description edit)

@suneox What would happen if we enable shouldAwareViewportScroll by default ? will this affect scrollable views?

import {useCallback, useEffect} from 'react';
import useDebouncedState from '@hooks/useDebouncedState';

export default function useIsInputFocus(enable = false): boolean {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a comment explaining this hook and what it does.

import {useCallback, useEffect} from 'react';
import useDebouncedState from '@hooks/useDebouncedState';

export default function useIsInputFocus(enable = false): boolean {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export default function useIsInputFocus(enable = false): boolean {
export default function useTackInputFocus(enable = false): boolean {

let's rename it to a more verbose name

Comment on lines 196 to 197
const isInputFocus = useIsInputFocus(shouldAwareViewportScroll && Browser.isMobileSafari());
const isAwareViewportScroll = shouldEnableMaxHeight && isInputFocus;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const isInputFocus = useIsInputFocus(shouldAwareViewportScroll && Browser.isMobileSafari());
const isAwareViewportScroll = shouldEnableMaxHeight && isInputFocus;
const isAwareViewportScroll = useTackInputFocus(shouldEnableMaxHeight && shouldAwareViewportScroll && Browser.isMobileSafari());

This could be simplified.

@suneox
Copy link
Contributor Author

suneox commented Jan 30, 2024

Let's fix this bug in other places too:

  • Profile display name
  • Add new contact method
  • Workspace settings -> name
  • Private notes: nagivate to report -> click on report header
  • Request money flow: there are several pages (waypoint selection, request flow, set merchant, description..)
  • Task Flow (create, task title edit, task description edit)

Hi @fedirjh,
I would like to confirm the scope for this PR about the list pages above. Is it an extended scope for this ticket? and some page I can not found step to access ST like

  • Add new contact method
  • Request money flow: request flow, set merchant, description..

and "..." is meaning for how many page?

@suneox What would happen if we enable shouldAwareViewportScroll by default ? will this affect scrollable views?

I'm not sure when we enable shouldAwareViewportScroll will not raise regression due to the scroll behavior on mWeb/Safari can be different for each page structure, so I think we should keep disable by default.

I have checked the list page you have provided above almost work well. Excludes

  • Add new contact method (missing step to open)
  • Request money flow: request flow, set merchant, description.. (missing step to open)
  • Task Flow: task description edit

What do you think if we separate the scope for this ticket?

@fedirjh
Copy link
Contributor

fedirjh commented Jan 31, 2024

I would like to confirm the scope for this PR about the list pages above. Is it an extended scope for this ticket? and some page I can not found step to access ST like

@suneox We already implemented the main fix within the ScreenWrapper which is a global component used by all pages, so we should just add the new prop for all affected pages. The bug is not specific to a single screen, it just affects all screens that have a form within it (small forms specifically). Here is a video that illustrates the affected pages :

CleanShot.2024-01-31.at.18.09.29.mp4
CleanShot.2024-01-31.at.18.14.56.mp4

and "..." is meaning for how many page?

The flow has create and edit forms; affected forms are related to merchant description and waypoint point selector, I have included that in the video.

so I think we should keep disable by default.

Sounds good.

I have checked the list page you have provided above almost work well. Excludes

I have included all affected pages in the video

What do you think if we separate the scope for this ticket?

We are fixing the same bug, and I think we will only apply the new prop; no other changes are required IMO, If any page requires extra changes, then we will handle it on a separate ticket.

@suneox
Copy link
Contributor Author

suneox commented Feb 1, 2024

I have included all affected pages in the video

@fedirjh Thank you for your feedback, I'll update the list page you've provided asap

@suneox
Copy link
Contributor Author

suneox commented Feb 1, 2024

@fedirjh I have updated your feedback and we have a condition shouldEnableMaxHeight for aware view-port scroll so we can go ahead to fix global by set default shouldAwareViewportScroll. and If any page requires extra changes, then we will handle it on another ticket.

@fedirjh
Copy link
Contributor

fedirjh commented Feb 2, 2024

cc @suneox could you please merge main? Also we have some failing tests, could you please fix them?

@suneox
Copy link
Contributor Author

suneox commented Feb 3, 2024

@fedirjh I have syned with latest main

@suneox
Copy link
Contributor Author

suneox commented Feb 5, 2024

@fedirjh Have you got any for this PR?

@fedirjh
Copy link
Contributor

fedirjh commented Feb 5, 2024

Testing it shortly.

@fedirjh
Copy link
Contributor

fedirjh commented Feb 5, 2024

@suneox It seems that the hook used has some delay in it. So the bug is still reproducible with quicker steps :

  1. Open the legal name page
  2. Focus on the input and at the same time scroll the page
  3. The bug occurs
CleanShot.2024-02-06.at.00.51.11.mp4

@suneox
Copy link
Contributor Author

suneox commented Feb 6, 2024

@suneox It seems that the hook used has some delay in it. So the bug is still reproducible with quicker steps :

Let me double-check

@suneox
Copy link
Contributor Author

suneox commented Feb 6, 2024

@fedirjh I have handled the edge case, quickly scrolling after focusing to input

Screen.Recording.2024-02-06.at.23.13.52.mov

@fedirjh
Copy link
Contributor

fedirjh commented Feb 6, 2024

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native
CleanShot.2024-02-06.at.19.04.54.mp4
Android: mWeb Chrome
CleanShot.2024-02-06.at.19.06.18.mp4
iOS: Native
CleanShot.2024-02-06.at.18.52.42.mp4
iOS: mWeb Safari
CleanShot.2024-02-06.at.18.32.37.mp4
MacOS: Chrome / Safari
CleanShot.2024-02-06.at.18.48.58.mp4
MacOS: Desktop
CleanShot.2024-02-06.at.19.08.32.mp4

Copy link
Contributor

@fedirjh fedirjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

import useDebouncedState from '@hooks/useDebouncedState';

/**
* This hook to detech input or text area focus on browser, to avoid scroll on vitual viewport
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* This hook to detech input or text area focus on browser, to avoid scroll on vitual viewport
* This hook to detect input or text area focus on browser, to avoid scroll on virtual viewport

little typo.

@@ -220,12 +227,12 @@ function ScreenWrapper(
{...keyboardDissmissPanResponder.panHandlers}
>
<KeyboardAvoidingView
style={[styles.w100, styles.h100, {maxHeight}]}
style={[styles.w100, styles.h100, {maxHeight}, isAwareViewportScroll && [styles.overflowAuto, styles.overscrollBehaviorContain]]}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
style={[styles.w100, styles.h100, {maxHeight}, isAwareViewportScroll && [styles.overflowAuto, styles.overscrollBehaviorContain]]}
style={[styles.w100, styles.h100, {maxHeight}, isAwareViewportScroll ? [styles.overflowAuto, styles.overscrollBehaviorContain] : {}]}

To avoid applying false to style.

Copy link
Contributor

@fedirjh fedirjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@melvin-bot melvin-bot bot requested a review from luacmartins February 6, 2024 19:25
Copy link
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just some name changes

@@ -79,6 +80,9 @@ type ScreenWrapperProps = {
/** Whether to show offline indicator */
shouldShowOfflineIndicator?: boolean;

/** Whether to avoid scroll on virtual viewport */
shouldAwareViewportScroll?: boolean;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
shouldAwareViewportScroll?: boolean;
shouldAvoidScrollOnVirtualViewport?: boolean;

@@ -109,6 +113,7 @@ function ScreenWrapper(
onEntryTransitionEnd,
testID,
navigation: navigationProp,
shouldAwareViewportScroll = true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
shouldAwareViewportScroll = true,
shouldAvoidScrollOnVirtualViewport = true,

@@ -192,6 +197,8 @@ function ScreenWrapper(
// eslint-disable-next-line react-hooks/exhaustive-deps
}, []);

const isAwareViewportScroll = useTackInputFocus(shouldEnableMaxHeight && shouldAwareViewportScroll && Browser.isMobileSafari());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const isAwareViewportScroll = useTackInputFocus(shouldEnableMaxHeight && shouldAwareViewportScroll && Browser.isMobileSafari());
const isAvoidingViewportScroll = useTackInputFocus(shouldEnableMaxHeight && shouldAvoidScrollOnVirtualViewport && Browser.isMobileSafari());

@@ -220,12 +227,12 @@ function ScreenWrapper(
{...keyboardDissmissPanResponder.panHandlers}
>
<KeyboardAvoidingView
style={[styles.w100, styles.h100, {maxHeight}]}
style={[styles.w100, styles.h100, {maxHeight}, isAwareViewportScroll ? [styles.overflowAuto, styles.overscrollBehaviorContain] : {}]}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
style={[styles.w100, styles.h100, {maxHeight}, isAwareViewportScroll ? [styles.overflowAuto, styles.overscrollBehaviorContain] : {}]}
style={[styles.w100, styles.h100, {maxHeight}, isAvoidingViewportScroll ? [styles.overflowAuto, styles.overscrollBehaviorContain] : {}]}

behavior={keyboardAvoidingViewBehavior}
enabled={shouldEnableKeyboardAvoidingView}
>
<PickerAvoidingView
style={styles.flex1}
style={isAwareViewportScroll ? [styles.h100, {marginTop: 1}] : styles.flex1}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
style={isAwareViewportScroll ? [styles.h100, {marginTop: 1}] : styles.flex1}
style={isAvoidingViewportScroll ? [styles.h100, {marginTop: 1}] : styles.flex1}

@@ -0,0 +1,6 @@
/**
* This hook to detect input or text area focus on browser, on native doesn't support DOM so default return false
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* This hook to detect input or text area focus on browser, on native doesn't support DOM so default return false
* Detects input or text area focus on browsers. Native doesn't support DOM so default to false

import useDebouncedState from '@hooks/useDebouncedState';

/**
* This hook to detect input or text area focus on browser, to avoid scroll on virtual viewport
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* This hook to detect input or text area focus on browser, to avoid scroll on virtual viewport
* Detects input or text area focus on browsers to avoid scrolling on virtual viewports

* This hook to detect input or text area focus on browser, to avoid scroll on virtual viewport
*/
export default function useTackInputFocus(enable = false): boolean {
const [, isInputFocusDebounced, setIsInputFocus] = useDebouncedState(false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we define the first value? Or does that throw lint errors?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @luacmartins I have updated your suggestions and when we define the first value but not using that will throw eslint error.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, let's keep it empty then

@luacmartins
Copy link
Contributor

@suneox can you please merge main? Maybe that will fix the failing test

@suneox
Copy link
Contributor Author

suneox commented Feb 7, 2024

Hi @luacmartins the pipeline has fixed

@luacmartins luacmartins merged commit 82e93b8 into Expensify:main Feb 7, 2024
15 checks passed
@OSBotify
Copy link
Contributor

OSBotify commented Feb 7, 2024

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Feb 8, 2024

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.4.39-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/Beamanator in version: 1.4.39-8 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants