[$2000] The scrollbar does not scroll properly when long pressing up or down arrow key in RHN

[izarutskaya]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Open search by pressing CTRL + K.
2. Long press up or down arrow key.
3. Observe the scrollbar in search option list.

Expected Result:

The scrollbar should be scroll properly.

Actual Result:

The scrollbar does not scroll properly.

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: v1.3.60-1

Reproducible in staging?: Y

Reproducible in production?: Y

If this was caught during regression testing, add the test name, ID and link from TestRail:

Email or phone of affected tester (no customers):

Logs: https://stackoverflow.com/c/expensify/questions/4856

Notes/Photos/Videos: Any additional supporting documentation

2023-08-22_20-27-20.mp4

Recording.1408.mp4

Expensify/Expensify Issue URL:

Issue reported by: @@oleksandr-pantsyr

Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692725411476829

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~01701d970faa399749
• Upwork Job ID: 1699130136055246848
• Last Price Increase: 2023-10-27

[melvin-bot]

Triggered auto assignment to @slafortune (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[pongzu313]

Proposal

Please re-state the problem that we are trying to solve in this issue.

The scrollbar does not scroll properly when long pressing up or down arrow key in RHN

What is the root cause of that problem?

Please take a look at this code.

App/src/components/OptionsSelector/BaseOptionsSelector.js

Lines 259 to 261 in ec95ab0

	updateFocusedIndex(index) {
	this.setState({focusedIndex: index}, () => this.scrollToIndex(index));
	}

App/src/components/OptionsSelector/BaseOptionsSelector.js

Lines 386 to 392 in ec95ab0

	<ArrowKeyFocusManager
	disabledIndexes={this.disabledOptionsIndexes}
	focusedIndex={this.state.focusedIndex}
	maxIndex={this.state.allOptions.length - 1}
	onFocusedIndexChanged={this.props.disableArrowKeysActions ? () => {} : this.updateFocusedIndex}
	shouldResetIndexOnEndReached={false}
	>

The updateFocusedIndex method is called when the user clicks the up or down arrow buttons.
When users press and hold the up and down arrow buttons, the updateFousedIndex function is called several times, but only the last called function works. So the list doesn't scroll one by one.

What changes do you think we should make in order to solve the problem?

Therefore, we need to avoid too many key events being called at once while the list is scrolling by one item.

What alternative solutions did you explore? (Optional)

import lodash from 'lodash';

constructor(props) {
    //...other code...
    // Debounce updateFocusedIndex function
    this.updateFocusedIndex = lodash.debounce(this.updateFocusedIndex, 10); 
}

Result:

20230901_034505.mov

[melvin-bot]

@slafortune Whoops! This issue is 2 days overdue. Let's get this updated quick!

[slafortune]

report looks good, applying the external label

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~01701d970faa399749

[melvin-bot]

Current assignee @slafortune is eligible for the External assigner, not assigning anyone new.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @Ollyws (External)

[slafortune]

@Ollyws what do you think of the proposal presented by @kanno927 ?

Adding a new BZ member, I am out on sabbatical.

[melvin-bot]

Triggered auto assignment to @kevinksullivan (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[Ollyws]

Thanks for the proposal @kanno927 but the use of setTimeout is generally discouraged unless absolutely necessary.

[pongzu313]

@Ollyws Thanks for your kind message.

Proposal

Updated

[melvin-bot]

📣 It's been a week! Do we have any satisfactory proposals yet? Do we need to adjust the bounty for this issue? 💸

[Ollyws]

Will review asap.

[shubham1206agra]

@kevinksullivan Can you put this issue on hold for #31606?

[melvin-bot]

@Ollyws, @kevinksullivan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[melvin-bot]

@Ollyws, @kevinksullivan Eep! 4 days overdue now. Issues have feelings too...

[melvin-bot]

@Ollyws, @kevinksullivan 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@Ollyws, @kevinksullivan 8 days overdue is a lot. Should this be a Weekly issue? If so, feel free to change it!

[melvin-bot]

@Ollyws, @kevinksullivan 10 days overdue. I'm getting more depressed than Marvin.

[melvin-bot]

@Ollyws, @kevinksullivan 12 days overdue. Walking. Toward. The. Light...

[melvin-bot]

This issue has not been updated in over 14 days. @Ollyws, @kevinksullivan eroding to Weekly issue.

[Ollyws]

We should hold this for #31606 given the component is being re-factored.

[kevinksullivan]

sounds good, included that PR in the title.

[Ollyws]

On hold.

[melvin-bot]

This issue has not been updated in over 15 days. @Ollyws, @kevinksullivan eroding to Monthly issue.

P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!

[kevinksullivan]

still held

[dragnoir]

@kevinksullivan pls check #16184 (comment) and https://expensify.slack.com/archives/C01GTK53T8Q/p1709232289899589?thread_ts=1709156803.359359&cid=C01GTK53T8Q

The component we are holding for will not be used. Also the main issue here (search) already use SectionList and not OptionSelector.

Note: even after migrating to SectionList, we still see the issue. The scrollbar does not scroll properly.

[mallenexpensify]

Wasn't able to reproduce and also wasn't able to find scrolling in RHN. Going to close this. Reopen/comment if you disagree.

[mallenexpensify]

Meant to drop in a vid too

2024-04-04_14-19-57.mp4