[HOLD for payment 2023-12-20] [DISTANCE] LOW: PHASE 1: Wave 5 CLEANUP Refactor navigation among screens related to money request features

[hayata-suenaga]

Remove deep-linking support for screens related to money request

In the current code, deep linking to the screen for each step of money request flow is allowed.

There are logics to handle deep linking to a screen that corresponds to a step in the middle of the money request flow. These logics are not scalable and adds additional complexity.

Let's remove the support for deep linking. All screens should be under a single URL and all steps should be completed under that URL.

Relevant Slack discussion: https://expensify.slack.com/archives/C01GTK53T8Q/p1692998235169129

Issue Owner

Current Issue Owner: @anmurali

[tgolen]

We had some more discussion about this in https://expensify.slack.com/archives/C05DWUDHVK7/p1694542449982949 and I believe we should actually double-down on the URL based navigation. It has lots of benefits with the navigation flow (back buttons, screen animations, etc.).

Yes, it is pretty flawed and difficult to understand in its current state. I wouldn't mind taking this issue and having a go at cleaning this up so that it's more predictable and easier to use.

[tgolen]

Two big pieces for this were merged today. I'll keep working on cleanup.

Note to self: Try to remove ONYXKEYS.IOU

[tgolen]

I've been slowing chipping away at this over the last two days and have begun to implement a new way of routing and organizing the feature.

[melvin-bot]

Triggered auto assignment to @anmurali (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

⚠️ Looks like this issue was linked to a Deploy Blocker here

If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results.

If a regression has occurred and you are the assigned CM follow the instructions here.

If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future.

[tgolen]

We're good here 😅

Just waiting for this to wrap up and get paid out.

[melvin-bot]

@tgolen, @anmurali, @jjcoffee Whoops! This issue is 2 days overdue. Let's get this updated quick!

[melvin-bot]

@tgolen, @anmurali, @jjcoffee 6 days overdue. This is scarier than being forced to listen to Vogon poetry!

[tgolen]

Still waiting for @anmurali to pay this out.

[melvin-bot]

@tgolen, @anmurali, @jjcoffee Now this issue is 8 days overdue. Are you sure this should be a Daily? Feel free to change it!

[melvin-bot]

@tgolen, @anmurali, @jjcoffee 12 days overdue now... This issue's end is nigh!

[melvin-bot]

@tgolen, @anmurali, @jjcoffee 12 days overdue now... This issue's end is nigh!

[jjcoffee]

@anmurali Happy New Year! Just a friendly bump for payment 🙇

[anmurali]

https://www.upwork.com/nx/wm/offer/100268863

[jjcoffee]

@anmurali Accepted the offer, thanks!

[melvin-bot]

@tgolen, @anmurali, @jjcoffee Eep! 4 days overdue now. Issues have feelings too...

[anmurali]

Paid.