-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PAID] [$500] help.expensify.com is showing broken "Not found page" #27405
Comments
Triggered auto assignment to @strepanier03 ( |
ProposalPlease re-state the problem that we are trying to solve in this issue.help.expensify.com is showing broken "Not found page" What is the root cause of that problem?The image is broken because wrong image is being pointed to Line 5 in 867d61e
the existing file is called circle-hourglass The overlapping is happening because centered-content class has position: absolute Lines 566 to 570 in 867d61e
What changes do you think we should make in order to solve the problem?We should fix src of image to point to correct image. width: 100%;
height: calc(100vh - 56px);
display: flex;
flex-direction: column;
align-items: center;
justify-content: center;
text-align: center; The result: What alternative solutions did you explore? (Optional) |
Job added to Upwork: https://www.upwork.com/jobs/~0155f0466612861fa0 |
Bug0 Triage Checklist (Main S/O)
|
Triggered auto assignment to @greg-schroeder ( |
Triggered auto assignment to Contributor-plus team member for initial proposal review - @robertKozik ( |
From Original contributor ProposalPlease re-state the problem that we are trying to solve in this issue.help.expensify.com is showing broken "Not found page" What is the root cause of that problem?The image is broken because wrong image is being pointed to Line 5 in 867d61e
the existing file is called circle-hourglass The overlapping is happening because centered-content class has position: absolute Lines 566 to 570 in 867d61e
What changes do you think we should make in order to solve the problem?We should fix src of image to point to correct image. width: 100%;
height: calc(100vh - 56px);
display: flex;
flex-direction: column;
align-items: center;
justify-content: center;
text-align: center; The result: What alternative solutions did you explore? (Optional) |
Able to repro, will follow along. |
@strepanier03, @robertKozik Uh oh! This issue is overdue by 2 days. Don't forget to update your issues! |
Sorry for keeping you waiting @alitoshmatov ! I assume you are the author of the proposal. I've managed to check it and it does the job. Let's proceed with it 🎀 👀 🎀 C+ reviewed |
Triggered auto assignment to @Beamanator, see https://stackoverflow.com/c/expensify/questions/7972 for more details. |
Agreed, it looks like @alitoshmatov submitted the proposal in slack & it looks good, assigning 👍 |
Oh I can't assign you @alitoshmatov until you comment in this issue 😬 |
❌ There was an error making the offer to @alitoshmatov for the Contributor role. The BZ member will need to manually hire the contributor. cc @thienlnam |
❌ There was an error making the offer to @alitoshmatov for the Reporter role. The BZ member will need to manually hire the contributor. cc @thienlnam |
Pr is ready - #27839 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.75-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-10-09. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
For reference, here are some details about the assignees on this issue:
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
@alitoshmatov - I have hired you in Upwork and will pay when you accept the job. I made one contract for both reporting and contributing and will apply a bonus for the reporting job. Thanks! |
@strepanier03 Accepted |
@strepanier03 Friendly bump on payment |
Can this be closed? Or not quite yet? |
I have received payment yet |
@alitoshmatov - I've paid both payments and closed the contract, thanks for your patience there was a lot on my plate to get through. @Beamanator - Unless there's something I'm not aware of that means we don't need it, we're waiting on the BZ checklist responses from @robertKozik and then I can make a regression if needed and close this GH. |
|
Thank you @robertKozik - Looks like we're all set to close since no regression test is needed. Cheers everyone! |
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
Should show correct image and text without any overlapping
Actual Result:
Shows overlapped text with broken image
Workaround:
Can the user still use Expensify without this being fixed? Have you informed them of the workaround?
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.69-0
Reproducible in staging?: n/a
Reproducible in production?: Y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Screen.Recording.2023-08-23.at.18.17.16.mov
Expensify/Expensify Issue URL:
Issue reported by: @alitoshmatov
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1692796609530559
View all open jobs on GitHub
Upwork Automation - Do Not Edit
The text was updated successfully, but these errors were encountered: