[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [HOLD for payment 2023-10-20] [HOLD for payment 2023-10-20] [$500] Android - Inconsistent font weight between QR Share subtitle between Android and other platform

[kbecciv]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Action Performed:

1. Go to Settings => Profile => Share Code
2. Observe the email (subtitle) between android and other platform.

Expected Result:

Font weight of subtitle should be consistent between platform

Actual Result:

Inconsistent font weight between QRShare subtitle between Android and other platform

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

• Android / native
• Android / Chrome
• iOS / native
• iOS / Safari
• MacOS / Chrome / Safari
• MacOS / Desktop

Version Number: 1.3.70.5
Reproducible in staging?: y
Reproducible in production?: y
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-15.at.11.02.57.mov

Expensify/Expensify Issue URL:
Issue reported by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694751464693409

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0142c4ec420bc47997
• Upwork Job ID: 1702786767079575552
• Last Price Increase: 2023-09-15
• Automatic offers:
• hungvu193 | Contributor | 26985823
• hungvu193 | Reporter | 26985825

[melvin-bot]

Job added to Upwork: https://www.upwork.com/jobs/~0142c4ec420bc47997

[melvin-bot]

Triggered auto assignment to @isabelastisser (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

[melvin-bot]

Bug0 Triage Checklist (Main S/O)

• This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
• This bug is not a duplicate report (check E/App issues and #expensify-bugs)
  • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
• This bug is reproducible using the reproduction steps in the OP. S/O
  • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
  • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
• This issue is filled out as thoroughly and clearly as possible
  • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
• I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

[melvin-bot]

Triggered auto assignment to @stephanieelliott (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

[melvin-bot]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @mananjadhav (External)

[kbecciv]

Proposal by: @hungvu193
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1694751464693409

Proposal

Please re-state the problem that we are trying to solve in this issue.

What is the root cause of that problem?

We're using the EXP_NEUE_BOLD but we didn't define the fontWeight for it which caused the issue.

App/src/components/QRShare/index.js

Line 79 in e48121c

family="EXP_NEUE_BOLD"

What changes do you think we should make in order to solve the problem?

Solution 1:
We should add fontWeight: fontWeightBold to our subTitle style here

Solution 2:
Incase we dont want it bold, we should remove family="EXP_NEUE_BOLD or replace it with other regular fontFamily like EXP_NEUE to make it consistent with other platforms.

What alternative solutions did you explore? (Optional)

N/A

[fabrianibrahim]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Inconsistent font weight between QRShare subtitle between Android and other platform

What is the root cause of that problem?

Different font is used in ios

App/src/styles/fontFamily/bold/index.ios.js

Lines 1 to 3 in 76c1559

	const bold = 'ExpensifyNeue-Regular';
	export default bold;

Missing font weight in the component style

App/src/components/Text.js

Lines 51 to 57 in 76c1559

	const componentStyle = {
	color,
	fontSize,
	textAlign,
	fontFamily: fontFamily[family],
	...mergedStyles,
	};

What changes do you think we should make in order to solve the problem?

1. Replace const bold = 'ExpensifyNeue-Regular'; with const bold = 'ExpensifyNeue-Bold'; in src/styles/fontFamily/bold/index.ios.js#L1
2. Add fontWeight conditions in the Text componentStyle:

const componentStyle = {
      color,
      fontSize,
      textAlign,
      fontFamily: fontFamily[family],
      fontWeight: family === 'EXP_NEUE_BOLD' ? fontWeightBold : 400,
      ...mergedStyles,
  };

[melvin-bot]

📣 @fabrianibrahim! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
2. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
3. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[mananjadhav]

I am not sure if we should be changing the font weight across iOS. @shawnborton do you think we need that?

Otherwise I think @hungvu193's proposal is good. Will wait for @jasperhuangg to comment as well. @shawnborton it would also be great if you can confirm whether we need bold in the QRShare.

🎀 👀 🎀 C+ reviewed.

[melvin-bot]

Triggered auto assignment to @jasperhuangg, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[shawnborton]

I think the proposal is flipped, we don't want this to show in bold, we want this to be font weight 400 everywhere. Any idea why it's not that way on Android?

[hungvu193]

I think the proposal is flipped, we don't want this to show in bold, we want this to be font weight 400 everywhere. Any idea why it's not that way on Android?

The reason is we used font Bold for android, but use Regular for other platforms, so if we didn't add fontWeight for it, only Android works.
I think the line family="EXP_NEUE_BOLD was added accidentally because I didn't see any other places in our App that has subtitle bold and we don't pass family as a props for Text, we only use that in our styles, this is the only page in our App that using family as a props instead of passing it through style.

[fabrianibrahim]

I think the proposal is flipped, we don't want this to show in bold, we want this to be font weight 400 everywhere. Any idea why it's not that way on Android?

currently it is using font family EXP_NEUE_BOLD. replacing it to EXP_NEUE will fix this issue

[melvin-bot]

📣 @fabrianibrahim! 📣
Hey, it seems we don’t have your contributor details yet! You'll only have to do this once, and this is how we'll hire you on Upwork.
Please follow these steps:

1. Make sure you've read and understood the contributing guidelines.
2. Get the email address used to login to your Expensify account. If you don't already have an Expensify account, create one here. If you have multiple accounts (e.g. one for testing), please use your main account email.
3. Get the link to your Upwork profile. It's necessary because we only pay via Upwork. You can access it by logging in, and then clicking on your name. It'll look like this. If you don't already have an account, sign up for one here.
4. Copy the format below and paste it in a comment on this issue. Replace the placeholder text with your actual details.
   
   Format:

Contributor details
Your Expensify account email: <REPLACE EMAIL HERE>
Upwork Profile Link: <REPLACE LINK HERE>

[fabrianibrahim]

Contributor details
Your Expensify account email: [email protected]
Upwork Profile Link: https://www.upwork.com/freelancers/~01311d57940876ef13

[melvin-bot]

✅ Contributor details stored successfully. Thank you for contributing to Expensify!

[melvin-bot]

@mananjadhav, @stephanieelliott, @jasperhuangg Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[stephanieelliott]

Hey @jasperhuangg we're looking for your input on this proposal, can you take a look?

[melvin-bot]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix inconsistent font weight between android and other platforms. #28678

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mananjadhav does not require payment (Eligible for Manual Requests)
• @hungvu193 requires payment offer (Contributor)
• @hungvu193 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.83-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix inconsistent font weight between android and other platforms. #28678

If no regressions arise, payment will be issued on 2023-10-20. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mananjadhav does not require payment (Eligible for Manual Requests)
• @hungvu193 requires payment offer (Contributor)
• @hungvu193 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix inconsistent font weight between android and other platforms. #28678

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mananjadhav does not require payment (Eligible for Manual Requests)
• @hungvu193 requires payment offer (Contributor)
• @hungvu193 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.84-10 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

• Fix inconsistent font weight between android and other platforms. #28678

If no regressions arise, payment will be issued on 2023-10-23. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

• External issue reporter
• Contributor that fixed the issue
• Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

• @mananjadhav does not require payment (Eligible for Manual Requests)
• @hungvu193 requires payment offer (Contributor)
• @hungvu193 requires payment offer (Contributor)

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

• Merged PR within 3 business days of assignment - 50% bonus
• Merged PR more than 9 business days after assignment - 50% penalty

[melvin-bot]

BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:

• [@mananjadhav] The PR that introduced the bug has been identified. Link to the PR:
• [@mananjadhav] The offending PR has been commented on, pointing out the bug it caused and why, so the author and reviewers can learn from the mistake. Link to comment:
• [@mananjadhav] A discussion in #expensify-bugs has been started about whether any other steps should be taken (e.g. updating the PR review checklist) in order to catch this type of bug sooner. Link to discussion:
• [@mananjadhav] Determine if we should create a regression test for this bug.
• [@mananjadhav] If we decide to create a regression test for the bug, please propose the regression test steps to ensure the same bug will not reach production again.
• [@stephanieelliott] Link the GH issue for creating/updating the regression test once above steps have been agreed upon:

[melvin-bot]

@mananjadhav, @hungvu193, @stephanieelliott, @jasperhuangg Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!

[mananjadhav]

@stephanieelliott Can you please post the payout summary for this one?

[mananjadhav]

Based on my calculations, the pull request did not get merged within 3 working days of assignment. Please, check out my computations here:

• when @hungvu193 got assigned: 2023-10-02 18:46:38 Z
• when the PR got merged: 2023-10-11 01:47:15 UTC
• days elapsed: 6

On to the next one 🚀

Just a note. I think this issue will be eligible for urgency bonus, it got approved within 3 days and only needed to wait for final review after that.

I also agree with @hungvu193. This should be eligible for urgency bonus.

[stephanieelliott]

Thanks @mananjadhav - I agree the bonus should apply here.

Summarizing payment on this issue:

• Issue reporter: @hungvu193 $50, paid via Upwork
• Contributor: @hungvu193, paid via Upwork $750, request via Upwork
• Contributor+: @mananjadhav $750, request via NewDot

Upwork job is here, 50% bonus is included on final payout

[JmillsExpensify]

$750 payment approved for @mananjadhav based on summary above.