-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HOLD for payment 2023-09-29] [HOLD for payment 2023-09-27] IOU - RHP does not disappear after sending a request money #27724
Comments
Triggered auto assignment to @laurenreidexpensify ( |
Bug0 Triage Checklist (Main S/O)
|
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open
|
Auto-assign attempt failed, all eligible assignees are OOO. |
ProposalPlease re-state the problem that we are trying to solve in this issue.
What is the root cause of that problem?
App/src/pages/iou/steps/MoneyRequestConfirmPage.js Lines 105 to 107 in e23c181
What changes do you think we should make in order to solve the problem?
if (!navigatingBack.current && (_.isEmpty(props.iou.participants) || (props.iou.amount === 0 && !props.iou.receiptPath && !isDistanceRequest) || shouldReset)) {
Navigation.goBack(ROUTES.getMoneyRequestRoute(iouType.current, reportID.current), true);
} What alternative solutions did you explore? (Optional)
|
ProposalPlease re-state the problem that we are trying to solve in this issue.RHP does not disappear after sending a request money What is the root cause of that problem?Let's see here Lines 650 to 652 in 5150f86
When requesting money, we clear the field on ONYX before dismissing the modal. And in here
Because we clear the field before dismissing the modal, this logic will be triggered. It causes wrong navigation. What changes do you think we should make in order to solve the problem?Lines 650 to 652 in 5150f86
In here, we should dismiss modal before clear iou field
And in here we should check if modal.isVisible === false we will return that useEffect like that
What alternative solutions did you explore? (Optional) |
@laurenreidexpensify This issue is blocking other issues that relate to IOU. Could you prioritize taking a look at this? |
Triggered auto assignment to @AndrewGable ( |
The automation failed to assign an engineer here so have re-added. |
@jeet-dhandha and @DylanDylann - Trying to figure out which PR introduced this recently, if you have any leads that would be helpful! |
I can reproduce on staging, I cannot reproduce on production so this does seem like something we introduced recently. |
Interestingly, I cannot reproduce on |
I can't tell if |
If you are the assigned CME please investigate whether the linked PR caused a regression and leave a comment with the results. If a regression has occurred and you are the assigned CM follow the instructions here. If this regression could have been avoided please consider also proposing a recommendation to the PR checklist so that we can avoid it in the future. |
Can't reproduce now |
The regression was introduced in #26854 and this was fixed by @aimane-chnaif in #27793 |
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.71-12 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-09-27. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.72-11 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue: If no regressions arise, payment will be issued on 2023-09-29. 🎊 After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.
As a reminder, here are the bonuses/penalties that should be applied for any External issue:
|
BugZero Checklist: The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed:
|
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
Action Performed:
Expected Result:
The RHP should close and the user should get into a conversation with the user to whom the IOU was sent
Actual Result:
RHP does not close after the IOU is completed
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
Version Number: 1.3.71-5
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation
Bug6205460_Recording__336.mp4
Expensify/Expensify Issue URL:
Issue reported by: Applause - Internal Team
Slack conversation:
View all open jobs on GitHub
The text was updated successfully, but these errors were encountered: