Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HOLD for payment 2023-10-02] [HOLD for payment 2023-09-29] [$500] Web - App crash on request money with Workspace chat #27864

Closed
1 of 6 tasks
kbecciv opened this issue Sep 20, 2023 · 30 comments
Assignees
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor

Comments

@kbecciv
Copy link

kbecciv commented Sep 20, 2023

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!


Action Performed:

  1. Click on FAB icon and select request money option
  2. Enter money and press next button
  3. Select Workspace chat

Expected Result:

App should not crash on request money with Workspace chat

Actual Result:

App crash on request money with Workspace chat

Workaround:

Unknown

Platforms:

Which of our officially supported platforms is this issue occurring on?

  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop

Version Number: 1.3.72.6
Reproducible in staging?: y
Reproducible in production?: n
If this was caught during regression testing, add the test name, ID and link from TestRail:
Email or phone of affected tester (no customers):
Logs: https://stackoverflow.com/c/expensify/questions/4856
Notes/Photos/Videos: Any additional supporting documentation

Screen.Recording.2023-09-20.at.2.14.32.PM.mov
Recording.4625.mp4

Expensify/Expensify Issue URL:
Issue reported by: @gadhiyamanan
Slack conversation: https://expensify.slack.com/archives/C049HHMV9SM/p1695199393524129

View all open jobs on GitHub

Upwork Automation - Do Not Edit
  • Upwork Job URL: https://www.upwork.com/jobs/~011c0a28278a27071e
  • Upwork Job ID: 1704536148374425600
  • Last Price Increase: 2023-09-20
  • Automatic offers:
    • s77rt | Contributor | 26781104
    • gadhiyamanan | Reporter | 26781106
    • namhihi237 | Contributor | 26781279
@kbecciv kbecciv added the DeployBlockerCash This issue or pull request should block deployment label Sep 20, 2023
@OSBotify
Copy link
Contributor

👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

  1. Identify the pull request that introduced this issue and revert it.
  2. Find someone who can quickly fix the issue.
  3. Fix the issue yourself.

@melvin-bot
Copy link

melvin-bot bot commented Sep 20, 2023

Triggered auto assignment to @nkuoch (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.

@s77rt
Copy link
Contributor

s77rt commented Sep 20, 2023

@nkuoch Please assign me & @namhihi237 as this is a regression from #27729

@namhihi237 Please prepare a PR fixing this

@nkuoch nkuoch added the External Added to denote the issue can be worked on by a contributor label Sep 20, 2023
@melvin-bot melvin-bot bot changed the title Web - App crash on request money with Workspace chat [$500] Web - App crash on request money with Workspace chat Sep 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 20, 2023

Job added to Upwork: https://www.upwork.com/jobs/~011c0a28278a27071e

@melvin-bot melvin-bot bot added the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 20, 2023

Triggered auto assignment to @stephanieelliott (External), see https://stackoverflow.com/c/expensify/questions/8582 for more details.

@melvin-bot
Copy link

melvin-bot bot commented Sep 20, 2023

Triggered auto assignment to Contributor-plus team member for initial proposal review - @allroundexperts (External)

@melvin-bot melvin-bot bot removed the Help Wanted Apply this label when an issue is open to proposals by contributors label Sep 20, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 20, 2023

📣 @s77rt 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@melvin-bot
Copy link

melvin-bot bot commented Sep 20, 2023

📣 @gadhiyamanan 🎉 An offer has been automatically sent to your Upwork account for the Reporter role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job

@nkuoch
Copy link
Contributor

nkuoch commented Sep 20, 2023

Can't assign @namhihi237 because he didn't comment

@namhihi237
Copy link
Contributor

@nkuoch Please assign me, Thanks

@melvin-bot
Copy link

melvin-bot bot commented Sep 20, 2023

📣 @namhihi237 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link
Upwork job
Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻
Keep in mind: Code of Conduct | Contributing 📖

@s77rt
Copy link
Contributor

s77rt commented Sep 22, 2023

No payment is due here since it's a regression except for the bug reporter

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Weekly KSv2 labels Sep 25, 2023
@melvin-bot melvin-bot bot changed the title [HOLD for payment 2023-09-29] [$500] Web - App crash on request money with Workspace chat [HOLD for payment 2023-10-02] [HOLD for payment 2023-09-29] [$500] Web - App crash on request money with Workspace chat Sep 25, 2023
@melvin-bot
Copy link

melvin-bot bot commented Sep 25, 2023

The solution for this issue has been 🚀 deployed to production 🚀 in version 1.3.73-1 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

If no regressions arise, payment will be issued on 2023-10-02. 🎊

After the hold period is over and BZ checklist items are completed, please complete any of the applicable payments for this issue, and check them off once done.

  • External issue reporter — @gadhiyamanan paid $50 in Upwork ✅
  • Contributor that fixed the issue
  • Contributor+ that helped on the issue and/or PR

For reference, here are some details about the assignees on this issue:

As a reminder, here are the bonuses/penalties that should be applied for any External issue:

  • Merged PR within 3 business days of assignment - 50% bonus
  • Merged PR more than 9 business days after assignment - 50% penalty

@melvin-bot melvin-bot bot added Daily KSv2 Overdue and removed Weekly KSv2 labels Sep 29, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2023

@nkuoch, @s77rt, @namhihi237 Whoops! This issue is 2 days overdue. Let's get this updated quick!

@melvin-bot
Copy link

melvin-bot bot commented Oct 4, 2023

@nkuoch, @s77rt, @namhihi237 Eep! 4 days overdue now. Issues have feelings too...

@melvin-bot
Copy link

melvin-bot bot commented Oct 6, 2023

@nkuoch, @s77rt, @namhihi237 Still overdue 6 days?! Let's take care of this!

@melvin-bot
Copy link

melvin-bot bot commented Oct 10, 2023

@nkuoch, @s77rt, @namhihi237 10 days overdue. Is anyone even seeing these? Hello?

@melvin-bot
Copy link

melvin-bot bot commented Oct 12, 2023

@nkuoch, @s77rt, @namhihi237 12 days overdue. Walking. Toward. The. Light...

@melvin-bot melvin-bot bot added Weekly KSv2 and removed Daily KSv2 labels Oct 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 16, 2023

This issue has not been updated in over 14 days. @nkuoch, @s77rt, @namhihi237 eroding to Weekly issue.

@melvin-bot melvin-bot bot removed the Overdue label Oct 16, 2023
@mountiny mountiny added the Bug Something is broken. Auto assigns a BugZero manager. label Oct 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 16, 2023

Triggered auto assignment to @CortneyOfstad (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.

@melvin-bot melvin-bot bot added Daily KSv2 and removed Weekly KSv2 labels Oct 16, 2023
@melvin-bot
Copy link

melvin-bot bot commented Oct 16, 2023

Bug0 Triage Checklist (Main S/O)

  • This "bug" occurs on a supported platform (ensure Platforms in OP are ✅)
  • This bug is not a duplicate report (check E/App issues and #expensify-bugs)
    • If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
  • This bug is reproducible using the reproduction steps in the OP. S/O
    • If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
    • If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
  • This issue is filled out as thoroughly and clearly as possible
    • Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
  • I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync

@mountiny
Copy link
Contributor

The bugzero person has been missing here, sorry for the delay

We only need to pay the reporter as this was a regression handled by the author of the offending PR.

@CortneyOfstad could you please pay $50 to @gadhiyamanan for reporting

@CortneyOfstad
Copy link
Contributor

Sounds good @mountiny!

@gadhiyamanan I'll be sending you a payment request shortly. Unfortunately Upwork did not automatically create the job post, and keeps erroring out when I attempt to manually create it 🙃 I will keep checking and will update you ASAP. Thanks for your patience!

@CortneyOfstad
Copy link
Contributor

Job Post

@gadhiyamanan I was finally able to get it to post in Upwork, so please let me know once you accept the proposal and we can get this paid ASAP. Thanks for your patience!

@gadhiyamanan
Copy link
Contributor

@CortneyOfstad offer accepted, thanks!

@CortneyOfstad
Copy link
Contributor

Perfect!

Payment Summary

@gadhiyamanan paid $50 in Upwork as the Bug-Reporter.

@CortneyOfstad
Copy link
Contributor

Are we good to close @mountiny @nkuoch?

@nkuoch nkuoch closed this as completed Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Payment Auto-added when associated PR is deployed to production Bug Something is broken. Auto assigns a BugZero manager. Daily KSv2 Engineering External Added to denote the issue can be worked on by a contributor
Projects
None yet
Development

No branches or pull requests