Bump Onyx to 1.0.100 #28894

chrispader · 2023-10-05T07:48:53Z

@tgolen @marcaaron @blazejkustra

Details

Bump Onyx version to include changes from this PR

Fixed Issues

Related to Expensify/react-native-onyx#353

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

No QA.

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

Screen.Recording.2023-10-09.at.09.54.28.mov

iOS

Android

android.webm

melvin-bot · 2023-10-05T07:49:27Z

@AndrewGable Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chrispader · 2023-10-05T14:30:26Z

Using the latest version of Onyx means, that any (nested) value retrieved from Onyx in the app will from now on be undefined instead of null.

We might need to do a broader investigation, if this change might affect some parts of the app, especially when we compare Onyx values like value === null or _.isNull(value).

I checked the whole app for .pendingAction, since this attribute in IOU requests caused the tests to fail, but couldn't find any explicit null checks, only "falsy" checks...

marcaaron · 2023-10-05T21:09:14Z

@chrispader Are we holding merging this on that investigation? Or how did you want to proceed here?

marcaaron · 2023-10-05T21:09:53Z

Also I think we can limit it to the usage of Onyx.connect() because withOnyx() should remove any null values.

marcaaron · 2023-10-05T22:05:23Z

@chrispader please test on all platforms and share videos and/or images after the PR checklist

chrispader · 2023-10-07T13:55:36Z

@chrispader Are we holding merging this on that investigation? Or how did you want to proceed here?

Yes, i started doing a more in-depth investigation. I'll let you know when i'm done 👍

chrispader · 2023-10-09T08:08:17Z

Everything seems to work on all platforms 👍 Included screenshots for all platforms and recordings for desktop and android.

cc @marcaaron

chrispader · 2023-10-09T08:10:38Z

should we include version 1.0.102 in this bump already?

tgolen · 2023-10-09T16:18:28Z

Doesn't look like it would include anything useful, but you can if you want I guess.

allroundexperts · 2023-10-10T11:33:09Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-10-10.at.4.47.25.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-10-10.at.4.53.10.PM.mov

Mobile Web - Safari

Screen.Recording.2023-10-10.at.4.51.48.PM.mov

Desktop

Screen.Recording.2023-10-10.at.4.50.19.PM.mov

iOS

Screen.Recording.2023-10-10.at.4.52.32.PM.mov

Android

Screen.Recording.2023-10-10.at.4.54.02.PM.mov

allroundexperts

Testing well!

melvin-bot · 2023-10-10T12:00:48Z

🎯 @allroundexperts, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #29174.

tgolen · 2023-10-10T13:30:46Z

I feel like we should bump it in a separate PR to avoid scope creep of this PR.

This is fine. I've got a PR that I need to bump it to the latest version anyway.

mountiny · 2023-10-10T13:51:19Z

Thanks @allroundexperts Lets get this one merged in this deploy 🙏 @marcaaron @AndrewGable

package.json

src/libs/EmojiUtils.js

marcaaron · 2023-10-10T22:03:52Z

src/pages/home/sidebar/SidebarLinks.js

@@ -70,7 +70,7 @@ function SidebarLinks({onLinkClick, insets, optionListItems, isLoading, priority
        const unsubscribeOnyxModal = onyxSubscribe({
            key: ONYXKEYS.MODAL,
            callback: (modalArg) => {
-                if (_.isNull(modalArg)) {
+                if (_.isNull(modalArg) || _.isUndefined(modalArg)) {


Maybe it would be better to check if modalArg is not what we are looking for instead of checking if it's something we are not looking for (null, undefined, etc).

did you mean it like this?

Maybe it would be better to check if modalArg is what we are looking for instead of checking if it's something we are not looking for (null, undefined, etc).

If so, what would it be that we're looking for. I think it's better to just early-return in case of nullish values.

If not, what do you mean by that?

I meant something like - is it supposed to be a string? If so, then neither null or undefined are String

Ok, got it! Thanks!

In this case, ONYXKEYS.MODAL is an object, so we'll still have to check for null, because null is treated as type object

OSBotify · 2023-10-13T23:36:32Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-16T21:49:21Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-17T23:14:06Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.85-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-18T00:00:36Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.86-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-18T23:58:06Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.86-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Christoph Pader and others added 5 commits September 28, 2023 12:54

bump onyx

178093c

Merge branch 'main' into @chrispader/bump-onyx-to-1-0-95

b2f1a55

Merge branch 'main' into @chrispader/bump-onyx-to-1-0-95

ec15921

fix: tests

ff26337

Merge branch 'main' into @chrispader/bump-onyx-to-1-0-95

6cda511

chrispader requested a review from a team as a code owner October 5, 2023 07:48

melvin-bot bot removed the request for review from a team October 5, 2023 07:49

melvin-bot bot requested a review from AndrewGable October 5, 2023 07:49

chore: update onyx

8c78fa8

chrispader marked this pull request as draft October 5, 2023 07:51

chrispader added 3 commits October 5, 2023 10:40

fix: MigrationTest

dac1361

fix: MigrationTest

cec1f18

fix: last test

ca4bd90

chrispader marked this pull request as ready for review October 5, 2023 09:17

marcaaron self-requested a review October 5, 2023 21:10

chrispader added 5 commits October 7, 2023 16:01

Merge branch 'main' into @chrispader/bump-onyx-to-1-0-95

e2f23dc

fix: explicit null check in ReportActionItemEmojiReactions

616ec04

revert change

45aaca8

remove explicit null check

ed7d7e5

Merge branch 'main' into @chrispader/bump-onyx-to-1-0-95

4b12487

Merge branch 'main' into @chrispader/bump-onyx-to-1-0-95

638d725

allroundexperts approved these changes Oct 10, 2023

View reviewed changes

melvin-bot bot mentioned this pull request Oct 10, 2023

[HOLD for payment 2023-10-24] Payment issue for E/App PR#28894 #29174

Closed

jjcoffee mentioned this pull request Oct 10, 2023

[NoQA] Bump onyx - Fix out of order updates #29169

Merged

59 tasks

AndrewGable previously approved these changes Oct 10, 2023

View reviewed changes

marcaaron requested changes Oct 10, 2023

View reviewed changes

package.json Outdated Show resolved Hide resolved

marcaaron reviewed Oct 10, 2023

View reviewed changes

Christoph Pader added 3 commits October 11, 2023 10:08

Merge branch 'main' into @chrispader/bump-onyx-to-1-0-95

82d772c

fix: invalid condition

abb7ee2

set specific onyx version

91156fc

chrispader dismissed AndrewGable’s stale review via 91156fc October 11, 2023 08:18

fix: update condition

c64ee25

chrispader requested a review from marcaaron October 12, 2023 07:16

marcaaron approved these changes Oct 13, 2023

View reviewed changes

marcaaron merged commit 3e5f300 into Expensify:main Oct 13, 2023
13 checks passed

OSBotify mentioned this pull request Oct 16, 2023

Deploy Checklist: New Expensify 2023-10-16 #29717

Closed

tgolen mentioned this pull request Oct 17, 2023

[$500] [HOLD for payment 2023-11-21] Remove multiple withOnyx nestings #28824

Closed

1 task

Pujan92 mentioned this pull request Oct 17, 2023

[HOLD for payment 2023-10-25] [$500] IOU-In distance request, after selecting start waypoint finish section disappears #29748

Closed

6 tasks

OSBotify mentioned this pull request Oct 17, 2023

Deploy Checklist: New Expensify 2023-10-17 #29837

Closed

idanbe4 mentioned this pull request May 17, 2024

[Snyk] Security upgrade expo from 50.0.4 to 51.0.8 be4solutions/App#10

Open

MelvinBot mentioned this pull request May 17, 2024

[Snyk] Security upgrade expo from 50.0.4 to 51.0.8 #42357

Closed

50 tasks

melvin-bot bot mentioned this pull request May 17, 2024

[Snyk] Security upgrade expo from 50.0.4 to 51.0.8 #42358

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump Onyx to 1.0.100 #28894

Bump Onyx to 1.0.100 #28894

chrispader commented Oct 5, 2023 •

edited by mountiny

Loading

melvin-bot bot commented Oct 5, 2023

chrispader commented Oct 5, 2023 •

edited

Loading

marcaaron commented Oct 5, 2023

marcaaron commented Oct 5, 2023

marcaaron commented Oct 5, 2023

chrispader commented Oct 7, 2023 •

edited

Loading

chrispader commented Oct 9, 2023

chrispader commented Oct 9, 2023

tgolen commented Oct 9, 2023

allroundexperts commented Oct 10, 2023 •

edited

Loading

allroundexperts left a comment

melvin-bot bot commented Oct 10, 2023

tgolen commented Oct 10, 2023 •

edited

Loading

mountiny commented Oct 10, 2023

marcaaron Oct 10, 2023

chrispader Oct 11, 2023

marcaaron Oct 11, 2023

chrispader Oct 12, 2023

chrispader Oct 12, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 17, 2023

OSBotify commented Oct 18, 2023

OSBotify commented Oct 18, 2023

Bump Onyx to 1.0.100 #28894

Bump Onyx to 1.0.100 #28894

Conversation

chrispader commented Oct 5, 2023 • edited by mountiny Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Oct 5, 2023

chrispader commented Oct 5, 2023 • edited Loading

marcaaron commented Oct 5, 2023

marcaaron commented Oct 5, 2023

marcaaron commented Oct 5, 2023

chrispader commented Oct 7, 2023 • edited Loading

chrispader commented Oct 9, 2023

chrispader commented Oct 9, 2023

tgolen commented Oct 9, 2023

allroundexperts commented Oct 10, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

allroundexperts left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Oct 10, 2023

tgolen commented Oct 10, 2023 • edited Loading

mountiny commented Oct 10, 2023

marcaaron Oct 10, 2023

Choose a reason for hiding this comment

chrispader Oct 11, 2023

Choose a reason for hiding this comment

marcaaron Oct 11, 2023

Choose a reason for hiding this comment

chrispader Oct 12, 2023

Choose a reason for hiding this comment

chrispader Oct 12, 2023

Choose a reason for hiding this comment

OSBotify commented Oct 13, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 17, 2023

OSBotify commented Oct 18, 2023

OSBotify commented Oct 18, 2023

chrispader commented Oct 5, 2023 •

edited by mountiny

Loading

chrispader commented Oct 5, 2023 •

edited

Loading

chrispader commented Oct 7, 2023 •

edited

Loading

allroundexperts commented Oct 10, 2023 •

edited

Loading

tgolen commented Oct 10, 2023 •

edited

Loading